search for: removefromdisk

...ethod described above. However, > it *would* be necessary on Windows since you can't unlink/replace an > open file on that platform. To fix this, the original archive file must > be closed before performing the move. Yup. If you use the sys::Path class to do the "unlink" (removeFromDisk) then the platform differences should be accounted for. Please don't put the direct unlink call into ArchiveWriter.cpp. > > I've attached a patch that builds the temporary archive in a > stringstream, then writes the temporary file and moves it into place. It > fixes the b...

...>> However, it *would* be necessary on Windows since you can't >> unlink/replace an open file on that platform. To fix this, the >> original archive file must be closed before performing the move. > Yup. If you use the sys::Path class to do the "unlink" > (removeFromDisk) then the platform differences should be accounted > for. Please don't put the direct unlink call into ArchiveWriter.cpp. So this comment means that I should attempt to theoretically support Windows, and close the current archive file before updating it? >> I've attached a patc...

...final archive. This would avoid > writing an extra copy out to disk, and it wouldn't be hard to do this. Yup, that would work too. It would, however, require significant rework in ArchiveWriter.cpp code. >> Yup. If you use the sys::Path class to do the "unlink" >> (removeFromDisk) then the platform differences should be accounted >> for. Please don't put the direct unlink call into ArchiveWriter.cpp. > > So this comment means that I should attempt to theoretically support > Windows, and close the current archive file before updating it? If you use sys...

On Nov 23, 2005, at 8:16, Evan Jones wrote: > (4) Write the foreignST into the TmpArchive file. Is there any reason > that this isn't possible? Then the final archive would be created in a > single pass, and it could just be moved into place. Ah. I see: It needs to be written in order to compute the offsets. However, it would be possible to use a stringstream for this. I think

On Nov 22, 2005, at 23:59, Reid Spencer wrote: >> = {0, >> 0, 4, 0}}} >> (gdb) p archPath >> $3 = {path = {static npos = 4294967295, >> _M_dataplus = {<allocator<char>> = {<No data fields>}, >> _M_p = 0x83545f4 "temp.GNU.a5\b"}, static _S_empty_rep_storage = > What's with the "5\b" at the end? Looks