search for: remove_defaults_from_set

...atch !n with This can be written a bit more naturally as ... let n, remove = if string_prefix op_name "-" then String.sub op_name 1 (String.length op_name-1), true else op_name, false in match n with ... > + let f = if remove then Sysprep_operation.remove_defaults_from_set else Sysprep_operation.add_defaults_to_set in > + f opset You can actually write: (if remove then Sysprep_operation.remove_defaults_from_set else Sysprep_operation.add_defaults_to_set) opset I don't know which way you think is clearer, but I would avoid the >80 character...

...gth op_name-1)) > else > `Add op_name > match op with > > | `Add "" | `Remove "" -> (* error *) > | `Add "defaults" -> Sysprep_operation.add_defaults_to_set opset > | `Remove "defaults" -> Sysprep_operation.remove_defaults_from_set > | opset etc > > The type of op will be [ `Add of string | `Remove of string ]. > Actually you never need to write that type out, as OCaml will infer it > (and check it). It will only appear in error messages if you get the > code wrong. Interesting way, made use of it, tha...

..." | `Remove "" -> + eprintf (f_"%s: --operations: empty operation name\n") + prog; + exit 1 + | `Add "defaults" -> Sysprep_operation.add_defaults_to_set opset + | `Remove "defaults" -> Sysprep_operation.remove_defaults_from_set opset + | `Add "all" -> Sysprep_operation.add_all_to_set opset + | `Remove "all" -> Sysprep_operation.remove_all_from_set opset + | `Add n | `Remove n -> + let f = match op with + | `Add n -> Sysprep_operation.add_to_set +...

On Tuesday 07 January 2014 12:12:43 Richard W.M. Jones wrote: > On Tue, Jan 07, 2014 at 11:16:08AM +0100, Pino Toscano wrote: > > On Friday 27 December 2013 10:58:15 you wrote: > > > virt-sysprep either runs with all default operations or a selected > > > list of operations with the --enable argument. A few times I've > > > found I'd like to use the

...ve (String.sub op_name 1 (String.length op_name-1)) else `Add op_name match op with | `Add "" | `Remove "" -> (* error *) | `Add "defaults" -> Sysprep_operation.add_defaults_to_set opset | `Remove "defaults" -> Sysprep_operation.remove_defaults_from_set opset | etc The type of op will be [ `Add of string | `Remove of string ]. Actually you never need to write that type out, as OCaml will infer it (and check it). It will only appear in error messages if you get the code wrong. Rich. -- Richard Jones, Virtualization Group, Red Hat http://peo...