search for: remoteproc_virtio

...1713 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: git checkout 281310d52c1d63630f54b1ac5cca6e9eb8715b3a # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): drivers//remoteproc/remoteproc_virtio.c: In function 'rp_find_vq': >> drivers//remoteproc/remoteproc_virtio.c:107:27: warning: passing argument 8 of 'vring_new_virtqueue' from incompatible pointer type rproc_virtio_notify, callback, name); ^ In file included from drivers//...

...1713 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: git checkout 281310d52c1d63630f54b1ac5cca6e9eb8715b3a # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): drivers//remoteproc/remoteproc_virtio.c: In function 'rp_find_vq': >> drivers//remoteproc/remoteproc_virtio.c:107:27: warning: passing argument 8 of 'vring_new_virtqueue' from incompatible pointer type rproc_virtio_notify, callback, name); ^ In file included from drivers//...

...0-201713 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: git checkout 281310d52c1d63630f54b1ac5cca6e9eb8715b3a # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/remoteproc/remoteproc_virtio.c: In function 'rp_find_vq': >> drivers/remoteproc/remoteproc_virtio.c:107:27: error: passing argument 8 of 'vring_new_virtqueue' from incompatible pointer type [-Werror=incompatible-pointer-types] rproc_virtio_notify, callback, name); ^~...

...0-201713 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: git checkout 281310d52c1d63630f54b1ac5cca6e9eb8715b3a # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/remoteproc/remoteproc_virtio.c: In function 'rp_find_vq': >> drivers/remoteproc/remoteproc_virtio.c:107:27: error: passing argument 8 of 'vring_new_virtqueue' from incompatible pointer type [-Werror=incompatible-pointer-types] rproc_virtio_notify, callback, name); ^~...

...281310d52c1d63630f54b1ac5cca6e9eb8715b3a make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) include/linux/compiler.h:264:8: sparse: attribute 'no_sanitize_address': unknown attribute >> drivers/remoteproc/remoteproc_virtio.c:106:33: sparse: not enough arguments for function vring_new_virtqueue drivers/remoteproc/remoteproc_virtio.c: In function 'rp_find_vq': drivers/remoteproc/remoteproc_virtio.c:107:27: error: passing argument 8 of 'vring_new_virtqueue' from incompatible pointer type [-Werror=i...

...281310d52c1d63630f54b1ac5cca6e9eb8715b3a make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) include/linux/compiler.h:264:8: sparse: attribute 'no_sanitize_address': unknown attribute >> drivers/remoteproc/remoteproc_virtio.c:106:33: sparse: not enough arguments for function vring_new_virtqueue drivers/remoteproc/remoteproc_virtio.c: In function 'rp_find_vq': drivers/remoteproc/remoteproc_virtio.c:107:27: error: passing argument 8 of 'vring_new_virtqueue' from incompatible pointer type [-Werror=i...

rproc_virtio_dev_release will be called iff virtio_device.dev's reference count drops to 0. Here we just put vdev.dev, and then rproc->dev's cleanup will be done in rproc_virtio_dev_release. Signed-off-by: weiping zhang <zhangweiping at didichuxing.com> --- drivers/remoteproc/remoteproc_virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c index 2946348..b0633fd 100644 --- a/drivers/remoteproc/remoteproc_virtio.c +++ b/drivers/remoteproc/remoteproc_virtio.c @@ -327,7 +327,7 @@ int rproc...

...cd738f874b5ee8a16d4fa55c64d # save the attached .config to linux build tree make ARCH=x86_64 Note: the vhost/linux-next HEAD d01047cb281d27bcedbf705089bdd38d86d20b01 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): drivers/remoteproc/remoteproc_virtio.c: In function 'rproc_virtio_find_vqs': >> drivers/remoteproc/remoteproc_virtio.c:148:9: error: 'ctx' undeclared (first use in this function) ctx ? ctx[i] : false); ^~~ drivers/remoteproc/remoteproc_virtio.c:148:9: note: each undeclared identifier is...

...cd738f874b5ee8a16d4fa55c64d # save the attached .config to linux build tree make ARCH=x86_64 Note: the vhost/linux-next HEAD d01047cb281d27bcedbf705089bdd38d86d20b01 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): drivers/remoteproc/remoteproc_virtio.c: In function 'rproc_virtio_find_vqs': >> drivers/remoteproc/remoteproc_virtio.c:148:9: error: 'ctx' undeclared (first use in this function) ctx ? ctx[i] : false); ^~~ drivers/remoteproc/remoteproc_virtio.c:148:9: note: each undeclared identifier is...

...s to 0" s/call/called/ > or not, if called, put vdev.dev, and then rproc->dev's cleanup will be > done in rproc_virtio_dev_release, otherwise we do cleanup directly. > > Signed-off-by: weiping zhang <zhangweiping at didichuxing.com> > --- > drivers/remoteproc/remoteproc_virtio.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c > index 2946348..1073ea3 100644 > --- a/drivers/remoteproc/remoteproc_virtio.c > +++ b/drivers/remoteproc/remo...

...device, the main work is use put_device instead of kfree. weiping zhang (3): virtio_pci: use put_device instead of kfree virtio: use put_device instead of kfree virtio: put reference count of virtio_device.dev drivers/misc/mic/vop/vop_main.c | 16 +++++++++------- drivers/remoteproc/remoteproc_virtio.c | 2 +- drivers/virtio/virtio_pci_common.c | 17 +++++++++-------- 3 files changed, 19 insertions(+), 16 deletions(-) -- 2.9.4

...device, the main work is use put_device instead of kfree. weiping zhang (3): virtio_pci: use put_device instead of kfree virtio: use put_device instead of kfree virtio: put reference count of virtio_device.dev drivers/misc/mic/vop/vop_main.c | 16 +++++++++------- drivers/remoteproc/remoteproc_virtio.c | 2 +- drivers/virtio/virtio_pci_common.c | 17 +++++++++-------- 3 files changed, 19 insertions(+), 16 deletions(-) -- 2.9.4

...will use this new host virtio ring implementation. Ido, Ohad , Please could you review these patchs ? Best regards Erwan YVIN (1): remoteproc: refactor find_vqs to prepare for vringh Erwan Yvin (1): remoteproc: Add support for host virtio rings (vringh) drivers/remoteproc/remoteproc_virtio.c | 237 +++++++++++++++++++++++++------- include/linux/remoteproc.h | 22 +++ 2 files changed, 208 insertions(+), 51 deletions(-) -- 1.7.9.2

...will use this new host virtio ring implementation. Ido, Ohad , Please could you review these patchs ? Best regards Erwan YVIN (1): remoteproc: refactor find_vqs to prepare for vringh Erwan Yvin (1): remoteproc: Add support for host virtio rings (vringh) drivers/remoteproc/remoteproc_virtio.c | 237 +++++++++++++++++++++++++------- include/linux/remoteproc.h | 22 +++ 2 files changed, 208 insertions(+), 51 deletions(-) -- 1.7.9.2

rproc_virtio_dev_release will be called iff virtio_device.dev's refer count became to 0. Here we should put vdev.dev, and then rproc->dev's cleanup will be done in rproc_virtio_dev_release. Signed-off-by: weiping zhang <zhangweiping at didichuxing.com> --- drivers/remoteproc/remoteproc_virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c index 2946348..b0633fd 100644 --- a/drivers/remoteproc/remoteproc_virtio.c +++ b/drivers/remoteproc/remoteproc_virtio.c @@ -327,7 +327,7 @@ int rproc...

...ecame to 0. Here we should check if we call device_register or not, if called, put vdev.dev, and then rproc->dev's cleanup will be done in rproc_virtio_dev_release, otherwise we do cleanup directly. Signed-off-by: weiping zhang <zhangweiping at didichuxing.com> --- drivers/remoteproc/remoteproc_virtio.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c index 2946348..1073ea3 100644 --- a/drivers/remoteproc/remoteproc_virtio.c +++ b/drivers/remoteproc/remoteproc_virtio.c @@ -304,7 +304...

...are not set by mistake. Based on rproc patch by Rusty. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/lguest/lguest_device.c | 3 +++ drivers/misc/mic/card/mic_virtio.c | 3 +++ drivers/remoteproc/remoteproc_virtio.c | 3 +++ drivers/s390/kvm/kvm_virtio.c | 3 +++ drivers/s390/kvm/virtio_ccw.c | 3 +++ drivers/virtio/virtio_mmio.c | 3 +++ drivers/virtio/virtio_pci.c | 3 +++ 7 files changed, 21 insertions(+) diff --git a/drivers/lguest/lguest_device.c b/drivers/lguest/...

...are not set by mistake. Based on rproc patch by Rusty. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/lguest/lguest_device.c | 3 +++ drivers/misc/mic/card/mic_virtio.c | 3 +++ drivers/remoteproc/remoteproc_virtio.c | 3 +++ drivers/s390/kvm/kvm_virtio.c | 3 +++ drivers/s390/kvm/virtio_ccw.c | 3 +++ drivers/virtio/virtio_mmio.c | 3 +++ drivers/virtio/virtio_pci.c | 3 +++ 7 files changed, 21 insertions(+) diff --git a/drivers/lguest/lguest_device.c b/drivers/lguest/...

...o device_initialize and device_add virtio_pci: don't kfree device on register failure virtio_vop: don't kfree device on register failure virtio_remoteproc: don't kfree device on register failure drivers/misc/mic/vop/vop_main.c | 20 +++++++++++++------- drivers/remoteproc/remoteproc_virtio.c | 13 +++++++++++-- drivers/virtio/virtio.c | 18 +++++++++++++++--- drivers/virtio/virtio_pci_common.c | 8 ++++++-- 4 files changed, 45 insertions(+), 14 deletions(-) -- 2.9.4

...o device_initialize and device_add virtio_pci: don't kfree device on register failure virtio_vop: don't kfree device on register failure virtio_remoteproc: don't kfree device on register failure drivers/misc/mic/vop/vop_main.c | 20 +++++++++++++------- drivers/remoteproc/remoteproc_virtio.c | 13 +++++++++++-- drivers/virtio/virtio.c | 18 +++++++++++++++--- drivers/virtio/virtio_pci_common.c | 8 ++++++-- 4 files changed, 45 insertions(+), 14 deletions(-) -- 2.9.4