search for: remote_disk

Patch 1 was previously posted here: https://www.redhat.com/archives/libguestfs/2020-June/msg00086.html to handle this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1848862 I was able to observe this bug and for me at least disabling readahead seems to cure it. Patches 2 and 3 are simplifications, removing a now-undocumented feature of virt-v2v-copy-to-local and thus simplifying greatly the

...debugging. *) diff --git a/v2v/copy_to_local.ml b/v2v/copy_to_local.ml index 717ba50..2e3b59b 100644 --- a/v2v/copy_to_local.ml +++ b/v2v/copy_to_local.ml @@ -199,9 +199,9 @@ read the man page virt-v2v-copy-to-local(1). | ESXi _ -> let curl_args = [ - "url", Some remote_disk; - "output", Some local_disk; - ] in + "url", Some remote_disk; + "output", Some local_disk; + ] in let curl_args = if sslverify then curl_args else ("insecure", None) :: curl_args in @@ -2...

...7ba50..d791293 100644 --- a/v2v/copy_to_local.ml +++ b/v2v/copy_to_local.ml @@ -198,10 +198,11 @@ read the man page virt-v2v-copy-to-local(1). error (f_"ssh copy command failed, see earlier errors"); | ESXi _ -> - let curl_args = [ - "url", Some remote_disk; - "output", Some local_disk; - ] in + let curl_args = + Curl.safe_args @ [ + "url", Some remote_disk; + "output", Some local_disk; + ] in let curl_args = if sslverify then curl_args el...

It turns out that RHEL 5 Xen conversions don't work if the source disk is located on a block device. See patch 1/4 for the gory details. This patch series proposes a new tool called virt-v2v-copy-to-local which essentially is a way to make new virt-v2v work like the old virt-v2v, ie. copy first, convert after. Of course this is very slow and would only be used as a last resort, but I

...59b..9dfb378 100644 --- a/v2v/copy_to_local.ml +++ b/v2v/copy_to_local.ml @@ -198,22 +198,18 @@ read the man page virt-v2v-copy-to-local(1). error (f_"ssh copy command failed, see earlier errors"); | ESXi _ -> - let curl_args = [ - "url", Some remote_disk; - "output", Some local_disk; - ] in - let curl_args = - if sslverify then curl_args - else ("insecure", None) :: curl_args in - let curl_args = - match cookie with - | None -> curl_args - | Some cookie -&g...

v2 -> v3: - Changes to the Curl API suggested by Pino.

The first commit removes the --dcpath parameter, which just makes the following stuff simpler. Since libvirt has supported getting datacenterpath from VMware since Oct 2015, it's time to drop this hairy parameter. The rest is quite a complicated series of refactorings, followed by a very simple change to add handling of snapshots taken from old virt-v2v. Rich.

v1 -> v2: - Fixed the bug with precedence of if / @. - Add some imperative list operators inspired by Perl, and use those for constructing the Curl arguments, and more. Rich.

Move the Curl wrapper module from virt-v2v to mllib. Use the module when virt-builder issues curl calls. Rich.

.../copy_to_local.ml b/v2v/copy_to_local.ml index 0706f27..ed53277 100644 --- a/v2v/copy_to_local.ml +++ b/v2v/copy_to_local.ml @@ -218,8 +218,8 @@ read the man page virt-v2v-copy-to-local(1). ignore (Curl.run curl_args) | Test -> - let cmd = sprintf "cp %s %s" (quote remote_disk) (quote local_disk) in - if shell_command cmd <> 0 then + let cmd = [| "cp"; remote_disk; local_disk |] in + if run_command cmd <> 0 then error (f_"copy command failed, see earlier errors"); ) disks; diff --git a/v2v/input_libvirt_vce...

Add an optional parameter to disable this behaviour, so the Curl module in v2v won't print user-sensible data (like passwords). --- builder/checksums.ml | 1 - builder/downloader.ml | 1 - builder/sigchecker.ml | 1 - mllib/common_utils.ml | 4 +++- mllib/common_utils.mli | 7 +++++-- v2v/curl.ml | 2 +- 6 files changed, 9 insertions(+), 7 deletions(-) diff --git

...ot; xml; (* For VMware ESXi source, we have to massage the disk path. *) let disks = @@ -149,8 +147,7 @@ read the man page virt-v2v-copy-to-local(1). let url, sslverify = VCenter.map_source_to_https dcpath parsed_uri server remote_disk in - if verbose () then - printf "esxi: source disk %s (sslverify=%b)\n" url sslverify; + debug "esxi: source disk %s (sslverify=%b)" url sslverify; let cookie = VCenter.get_session_cookie password "esx"...

Add a Common_utils.debug function for printing messages only when in verbose mode. Rich.

v2 -> v3: - Renamed List.assoc_ -> List.assoc_lbl. - Rebased on top of current master branch. Rich.

In Std_utils we already extend Char and String. These commits take it a little further by extending List and adding a new Option submodule. All basically simple refactoring. Rich.

This time including the first commit ...