search for: rem_path

Various coding style fixes checkpatch warns about. The goal is not to be 100% checkpatch compliant, but to have more consistent coding style. As this is a trivial patch serie, will land in 24 hours in klibc git, unless of course ml review hits a bugger. Checked with size(3) that the generated kinit, fstype, ipconfig and nfsmount are the same. maximilian attems (4): [klibc] ipconfig: reduce

....c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/usr/kinit/nfsmount/main.c b/usr/kinit/nfsmount/main.c index beda723..b85901a 100644 --- a/usr/kinit/nfsmount/main.c +++ b/usr/kinit/nfsmount/main.c @@ -214,6 +214,7 @@ int nfsmount_main(int argc, char *argv[]) if ((rem_path = strchr(rem_path, ':')) == NULL) { fprintf(stderr, "%s: need a server\n", progname); + free(rem_name); return 1; } @@ -221,6 +222,7 @@ int nfsmount_main(int argc, char *argv[]) if (*rem_path != '/') { fprintf(stderr, "%s: need a path\n", progna...

...nfsmount/mount.c index e3838f4..e0687a6 100644 --- a/usr/kinit/nfsmount/mount.c +++ b/usr/kinit/nfsmount/mount.c @@ -329,9 +329,9 @@ int nfs_mount(const char *pathname, const char *hostname, bail: if (mounted) { if (data->flags & NFS_MOUNT_VER3) - umount_v3(path, clnt); + umount_v3(rem_path, clnt); else - umount_v2(path, clnt); + umount_v2(rem_path, clnt); } ret = -1;

...nfsmount/mount.c index e3838f4..e0687a6 100644 --- a/usr/kinit/nfsmount/mount.c +++ b/usr/kinit/nfsmount/mount.c @@ -329,9 +329,9 @@ int nfs_mount(const char *pathname, const char *hostname, bail: if (mounted) { if (data->flags & NFS_MOUNT_VER3) - umount_v3(path, clnt); + umount_v3(rem_path, clnt); else - umount_v2(path, clnt); + umount_v2(rem_path, clnt); } ret = -1; -- Benjamin Cama <benjamin.cama at telecom-bretagne.eu>

Hi, I'm resending since I got no feedback: I assume that the message was lost... The attached patch fixes a few bugs related to the spoofing portmapper used by nfsmount. Regards, Louis -- Dr Louis Rilling Kerlabs Skype: louis.rilling Batiment Germanium Phone: (+33|0) 6 80 89 08 23 80 avenue des Buttes de Coesmes http://www.kerlabs.com/ 35700 Rennes -------------- next part