search for: reg1235

...ted e-mail. Please ask questions if you don't understand something. I've come across an interesting problem. I'm merging our graph coloring allocator with the code from trunk as of late last week. I have a code where a LiveInterval is spilled and some uses can be rematerialized. %reg1235 is spilled and at least one use is rematted. The remat def instruction is: %reg1235<def> = FsMOVLPDrm %reg1097, 1, %reg1364, 88, Mem:LD(8,8) [tmp17731774 + 0] So this gets entered into ReMatDefs. %reg1461 is created for one of the spill intervals of %reg1235. It is marked as remater...

...> remat it instead of just using the register it was assigned to. I think > it's easy enough to fix this problem, but I don't think this gets at the > deeper issue. Duh. Of course this isn't a problem. We have to remat (or load) this because it's the result of spilling %reg1235. I got confused. :-/ So the real problem is that one of the operands of the remat def was spilled. Perhaps if that happens we mark registers using that remat def as not rematable? -Dave

...was assigned to. I >> think >> it's easy enough to fix this problem, but I don't think this gets >> at the >> deeper issue. > > Duh. Of course this isn't a problem. We have to remat (or load) > this because > it's the result of spilling %reg1235. I got confused. :-/ > > So the real problem is that one of the operands of the remat def was > spilled. > Perhaps if that happens we mark registers using that remat def as not > rematable? We only allow instructions without any register operand and / or a single pic base op...