search for: refcount

...2017 17:04:00 : epoch 59a450e6 : GLUSTER-NODE3 : ganesha.nfsd-2067[work-31] create_nfs4_owner :NFS4 LOCK :CRIT :Related {STATE_OPEN_OWNER_NFSV4 0x7f0274475840: clientid={0x7f036836b0f0 ClientID={Epoch=0x59a450e6 Counter=0x00000008} CONFIRMED Client={0x7f0278001940 name=(24:Linux NFSv4.2 devel-web3) refcount=4} t_delta=0 reservations=1 refcount=466} owner=(24:0x6f70656e2069643a00000027000000000000a95056901336) confirmed=0 seqid=0 refcount=2} doesn't match for {STATE_LOCK_OWNER_NFSV4 0x7f0328479b10: clientid={0x7f036836b0f0 ClientID={Epoch=0x59a450e6 Counter=0x00000008} CONFIRMED Client={0x7f0278001...

...a450e6 : GLUSTER-NODE3 : > ganesha.nfsd-2067[work-31] create_nfs4_owner :NFS4 LOCK :CRIT :Related > {STATE_OPEN_OWNER_NFSV4 0x7f0274475840: clientid={0x7f036836b0f0 > ClientID={Epoch=0x59a450e6 Counter=0x00000008} CONFIRMED > Client={0x7f0278001940 name=(24:Linux NFSv4.2 devel-web3) refcount=4} > t_delta=0 reservations=1 refcount=466} > owner=(24:0x6f70656e2069643a00000027000000000000a95056901336) > confirmed=0 seqid=0 refcount=2} doesn't match for > {STATE_LOCK_OWNER_NFSV4 0x7f0328479b10: clientid={0x7f036836b0f0 > ClientID={Epoch=0x59a450e6 Counter=0x00000008}...

...;normal"> specific authenticators for client 0x560ccad1bb00. > [2019-01-28 21:19:20] DBUG connection/_handle_authentication_mount_default Trying <mount type="default"> specific authenticators for client 0x560ccad1bb00. > [2019-01-28 21:19:20] DBUG auth/auth_addref ...refcount on auth_t (null) is now 2 > [2019-01-28 21:19:20] DBUG auth/auth_add_client Trying to add client 0x560ccad1bb00 to auth 0x560ccad17ad0's (role legacy-global-source) queue. > [2019-01-28 21:19:20] DBUG auth/auth_addref ...refcount on auth_t (null) is now 3 > [2019-01-28 21:19:20] INF...

...quot;> specific authenticators for client 0x560ccad1bb00. >> [2019-01-28 21:19:20] DBUG connection/_handle_authentication_mount_default Trying <mount type="default"> specific authenticators for client 0x560ccad1bb00. >> [2019-01-28 21:19:20] DBUG auth/auth_addref ...refcount on auth_t (null) is now 2 >> [2019-01-28 21:19:20] DBUG auth/auth_add_client Trying to add client 0x560ccad1bb00 to auth 0x560ccad17ad0's (role legacy-global-source) queue. >> [2019-01-28 21:19:20] DBUG auth/auth_addref ...refcount on auth_t (null) is now 3 >> [2019-01-28 2...

vhost checked the counter within the refcnt before decrementing. It really wanted to know that it is the one that has the last reference, as a way to batch freeing resources a bit more efficiently. Note: we only let refcount go to 0 on device release. This works well but we now access the ref counter twice so there's a race: all users might see a high count and decide to defer freeing resources. In the end no one initiates freeing resources until the last reference is gone (which is on VM shotdown so might happen...

vhost checked the counter within the refcnt before decrementing. It really wanted to know that it is the one that has the last reference, as a way to batch freeing resources a bit more efficiently. Note: we only let refcount go to 0 on device release. This works well but we now access the ref counter twice so there's a race: all users might see a high count and decide to defer freeing resources. In the end no one initiates freeing resources until the last reference is gone (which is on VM shotdown so might happen...

On 9/15/20 9:29 AM, Christoph Hellwig wrote: > On Mon, Sep 14, 2020 at 04:53:25PM -0700, Ralph Campbell wrote: >> Since set_page_refcounted() is defined in mm_interal.h I would have to >> move the definition to someplace like page_ref.h or have the drivers >> cal init_page_count() or set_page_count() since get_page() calls >> VM_BUG_ON_PAGE() if refcount == 0. >> I'll move set_page_refcounted() since that...

The current way of handling refcounting in the DP MST helpers is really confusing and probably just plain wrong because it's been hacked up many times over the years without anyone actually going over the code and seeing if things could be simplified. To the best of my understanding, the current scheme works like this: drm_dp_mst...

The current way of handling refcounting in the DP MST helpers is really confusing and probably just plain wrong because it's been hacked up many times over the years without anyone actually going over the code and seeing if things could be simplified. To the best of my understanding, the current scheme works like this: drm_dp_mst...

...>> with devm_memremap_pages() or memremap_pages() but my best reading of >> the code looks like it might be OK. I could use help testing these >> configurations. > > Back in the 4.15 days I could not convince myself that some code paths > blindly assumed that pages with refcount==0 were on an lru list. Since > then, struct page has been reorganized to not collide the ->pgmap back > pointer with the ->lru list and there have been other cleanups for > page pinning that might make this incremental cleanup viable. > > You also need to fix up ext4_break_la...

The current way of handling refcounting in the DP MST helpers is really confusing and probably just plain wrong because it's been hacked up many times over the years without anyone actually going over the code and seeing if things could be simplified. To the best of my understanding, the current scheme works like this: drm_dp_mst...

On Thu, Dec 13, 2018 at 08:25:32PM -0500, Lyude Paul wrote: > The current way of handling refcounting in the DP MST helpers is really > confusing and probably just plain wrong because it's been hacked up many > times over the years without anyone actually going over the code and > seeing if things could be simplified. > > To the best of my understanding, the current scheme wo...

On Fri, 2018-12-14 at 10:29 +0100, Daniel Vetter wrote: > On Thu, Dec 13, 2018 at 08:25:32PM -0500, Lyude Paul wrote: > > The current way of handling refcounting in the DP MST helpers is really > > confusing and probably just plain wrong because it's been hacked up many > > times over the years without anyone actually going over the code and > > seeing if things could be simplified. > > > > To the best of my understandi...

On Tue, Dec 18, 2018 at 04:27:58PM -0500, Lyude Paul wrote: > On Fri, 2018-12-14 at 10:29 +0100, Daniel Vetter wrote: > > On Thu, Dec 13, 2018 at 08:25:32PM -0500, Lyude Paul wrote: > > > The current way of handling refcounting in the DP MST helpers is really > > > confusing and probably just plain wrong because it's been hacked up many > > > times over the years without anyone actually going over the code and > > > seeing if things could be simplified. > > > > > > To t...

On 9/15/20 10:36 PM, Christoph Hellwig wrote: > On Tue, Sep 15, 2020 at 09:39:47AM -0700, Ralph Campbell wrote: >>> I don't think any of the three ->page_free instances even cares about >>> the page refcount. >>> >> Not true. The page_free() callback records the page is free by setting >> a bit or putting the page on a free list but when it allocates a free >> device private struct page to be used with migrate_vma_setup(), it needs to >> increment the refcount. >>...

...; diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c > index 01bbf2c0e144..29ec2f5bbbe2 100644 > --- a/fs/fuse/virtio_fs.c > +++ b/fs/fuse/virtio_fs.c > @@ -37,6 +37,7 @@ struct virtio_fs_vq { > > /* A virtio-fs device instance */ > struct virtio_fs { > + struct kref refcount; > struct list_head list; /* on virtio_fs_instances */ > char *tag; > struct virtio_fs_vq *vqs; > @@ -63,6 +64,27 @@ static inline struct fuse_pqueue *vq_to_fpq(struct virtqueue *vq) > return &vq_to_fsvq(vq)->fud->pq; > } > > +static void release_virt...

...; diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c > index 01bbf2c0e144..29ec2f5bbbe2 100644 > --- a/fs/fuse/virtio_fs.c > +++ b/fs/fuse/virtio_fs.c > @@ -37,6 +37,7 @@ struct virtio_fs_vq { > > /* A virtio-fs device instance */ > struct virtio_fs { > + struct kref refcount; > struct list_head list; /* on virtio_fs_instances */ > char *tag; > struct virtio_fs_vq *vqs; > @@ -63,6 +64,27 @@ static inline struct fuse_pqueue *vq_to_fpq(struct virtqueue *vq) > return &vq_to_fsvq(vq)->fud->pq; > } > > +static void release_virt...

...--git a/include/linux/memremap.h b/include/linux/memremap.h > index e5862746751b..f9224f88e4cd 100644 > --- a/include/linux/memremap.h > +++ b/include/linux/memremap.h > @@ -65,9 +65,10 @@ enum memory_type { > > struct dev_pagemap_ops { > /* > - * Called once the page refcount reaches 1. (ZONE_DEVICE pages never > - * reach 0 refcount unless there is a refcount bug. This allows the > - * device driver to implement its own memory management.) > + * Called once the page refcount reaches 0. The reference count > + * should be reset to one with init_page_cou...

...fuse/virtio_fs.c > > index 01bbf2c0e144..29ec2f5bbbe2 100644 > > --- a/fs/fuse/virtio_fs.c > > +++ b/fs/fuse/virtio_fs.c > > @@ -37,6 +37,7 @@ struct virtio_fs_vq { > > > > /* A virtio-fs device instance */ > > struct virtio_fs { > > + struct kref refcount; > > struct list_head list; /* on virtio_fs_instances */ > > char *tag; > > struct virtio_fs_vq *vqs; > > @@ -63,6 +64,27 @@ static inline struct fuse_pqueue *vq_to_fpq(struct virtqueue *vq) > > return &vq_to_fsvq(vq)->fud->pq; > > } > &g...

...IndirectUser ====================================================== This is my take on Duncan's proposed solution to PR24755 [1]. It involves creating a new type of Constant. A sketch: struct llvm::IndirectUser : llvm::Constant { Constant *Data; // Operand 0 unsigned RefCount; // Metadata (not an operand) /// Get or create an IndirectUser for C. static IndirectUser *GetOrCreateIndirectUser(Constant *C); /// Drop a reference to C's IndirectUser. static void ReleaseIndirectUser(Constant *C); }; Here's how to attach pr...