search for: refcnt

I have a zone "rw" defined as tun0 in interfaces. From that zone, pings to zone "loc" succeed but pings to remote networks (On IPsec VPNs) are rejected in the all2all chain. From my point of view, these pings should be in the rw2cctc chain. (rw to cctc is ACCEPTed in policy.) I must have a hole in my config, where would it be? Thanks, A.

Dear Shorewall Users :-) I''ve been playing with shorewall for some time now - I found it really interesting and easy tool to organise all the rules and so on (beforethat I''ve been using simple iptables rules in shell script ;-) Generally it''s quite easy to be used, but anyway found one problem which I cannot handle myself - or in other words - cannot find appropriate

We need to drop the refcnt of page when we fail to allocate an skb for frag list, otherwise it will be leaked. The bug was introduced by commit 2613af0ed18a11d5c566a81f9a6510b73180660a ("virtio_net: migrate mergeable rx buffers to page frag allocators"). Cc: Michael Dalton <mwdalton at google.com> Cc: Eric D...

We need to drop the refcnt of page when we fail to allocate an skb for frag list, otherwise it will be leaked. The bug was introduced by commit 2613af0ed18a11d5c566a81f9a6510b73180660a ("virtio_net: migrate mergeable rx buffers to page frag allocators"). Cc: Michael Dalton <mwdalton at google.com> Cc: Eric D...

On Tue, 2013-11-19 at 16:05 +0800, Jason Wang wrote: > We need to drop the refcnt of page when we fail to allocate an skb for frag > list, otherwise it will be leaked. The bug was introduced by commit > 2613af0ed18a11d5c566a81f9a6510b73180660a ("virtio_net: migrate mergeable rx > buffers to page frag allocators"). > > Cc: Michael Dalton <mwdalton at...

...current: Sep 3 19:31:38 2007 > diff: 8376(s) hard: 43200(s) soft: 34560(s) > last: Sep 3 17:12:02 2007 hard: 0(s) soft: 0(s) > current: 2096(bytes) hard: 0(bytes) soft: 0(bytes) > allocated: 17 hard: 0 soft: 0 > sadb_seq=1 pid=4820 refcnt=0 > 1.2.3.4 5.6.7.8 > esp mode=tunnel spi=116316636(0x06eed9dc) reqid=0(0x00000000) > E: blowfish-cbc 4a0d645b bd27c956 8ff054fd f530c6ff > A: hmac-sha1 4e188a7e e5a78e6b 4330bf40 63d26fad 67127967 > seq=0x00000000 replay=4 flags=0x00000000 state=mature >...

hi I've some problems with netback 1.what's mmap_pages for, which come from balloon operation ？ mmap_pages = alloc_empty_pages_and_pagevec(MAX_PENDING_REQS) 2.what's the meaning of "refcnt" defined in netif_t (netif->refcnt) 3.irq enable and disable such as disable_irq(netif->irq); why netback use such enable & disable operations while netfront dont use for its irq? 4.blank "resume" operation for netback why netfront has "resueme" defined, while n...

...00000000 replay=4 flags=0x00000000 state=mature created: Feb 16 12:46:01 2009 current: Feb 16 12:47:13 2009 diff: 72(s) hard: 3600(s) soft: 2880(s) last: hard: 0(s) soft: 0(s) current: 0(bytes) hard: 0(bytes) soft: 0(bytes) allocated: 0 hard: 0 soft: 0 sadb_seq=3 pid=5198 refcnt=0 xx.xx.xx.xx yy.yy.yy.yy ah mode=tunnel spi=173186772(0x0a529ed4) reqid=0(0x00000000) A: hmac-sha1 82aaec77 11dfb67c 7fbb7f7c 152c2764 4445ad8e seq=0x00000000 replay=4 flags=0x00000000 state=mature created: Feb 16 12:46:01 2009 current: Feb 16 12:47:13 2009 diff: 72(s) hard: 3600(s) soft: 28...

On Tue, 2013-11-19 at 22:49 +0200, Michael S. Tsirkin wrote: > On Tue, Nov 19, 2013 at 06:03:48AM -0800, Eric Dumazet wrote: > > On Tue, 2013-11-19 at 16:05 +0800, Jason Wang wrote: > > > We need to drop the refcnt of page when we fail to allocate an skb for frag > > > list, otherwise it will be leaked. The bug was introduced by commit > > > 2613af0ed18a11d5c566a81f9a6510b73180660a ("virtio_net: migrate mergeable rx > > > buffers to page frag allocators"). > > >...

...o get hold of the br_ioctl_mutex. This was also quite strange to me, since on the surface it definitely looked like a deadlock, but the strict locking order as I described previously should prevent any deadlocks from happening. Anyways, I decided to test switching up the lock order, since both the refcnt warning and the task stall seemed closely related to the above mentioned locks. When I ran the reproducer again after the patch, both the warning and the stall issue went away. So I guess the patch is still relevant in preventing bugs in some extreme cases -- although the scenario created by the re...

...t/10query.t ........... ok t/collapse.t .......... ok t/create.t ............ ok t/databasemodified.t .. ok t/document.t .......... ok t/exception.t ......... ok t/index.t ............. ok t/parser.t ............ 1/62 new 0x842f698 : SV = IV(0x842f694) at 0x842f698 REFCNT = 1 FLAGS = (IOK,pIOK) IV = 138460792 new 0x82a9420 : SV = IV(0x82a941c) at 0x82a9420 REFCNT = 1 FLAGS = (IOK,pIOK) IV = 138283680 old (1): 0 SV = UNKNOWN(0xff) (0x842f668) at 0x83cfea8 REFCNT = 0 FLAGS = () old (1): 0 SV = UNKNOWN(0xff) (0x83cfea8) at 0x842f5d8 REFCNT = 0 FLAGS...

The "42f5cda5eaf4" commit rightly set SOCK_DONE on peer shutdown, but there is an issue if we receive the SHUTDOWN(RDWR) while the virtio_transport_close_timeout() is scheduled. In this case, when the timeout fires, the SOCK_DONE is already set and the virtio_transport_close_timeout() will not call virtio_transport_reset() and virtio_transport_do_close(). This causes that both sockets

...b 100644 >--- a/net/vmw_vsock/virtio_transport_common.c >+++ b/net/vmw_vsock/virtio_transport_common.c >@@ -1343,6 +1343,7 @@ void virtio_transport_recv_pkt(struct virtio_transport *t, > > if (!skb_set_owner_sk_safe(skb, sk)) { > WARN_ONCE(1, "receiving vsock socket has sk_refcnt == 0\n"); >+ sock_put(sk); Did you have any warning, issue here? IIUC skb_set_owner_sk_safe() can return false only if the ref counter is 0, so calling a sock_put() on it should have no effect except to produce a warning. Thanks, Stefano

On Tue, 2013-11-19 at 23:53 +0200, Michael S. Tsirkin wrote: > Which NIC? Virtio? Prior to 2613af0ed18a11d5c566a81f9a6510b73180660a > it didn't drop packets received from host as far as I can tell. > virtio is more like a pipe than a real NIC in this respect. Prior/after to this patch, you were not posting buffers, so if packets were received on a physical NIC, you were dropping the

Great catch Jason. I agree this now raises the larger issue of how to handle a memory alloc failure in the middle of receive. As Eric mentioned, we can drop the packet and free the remaining (num_buf) frags. Michael, perhaps I'm missing something, but why would you prefer pre-allocating buffers in this case? If the guest kernel is OOM'ing, dropping packets should provide backpressure.

On Wed, 2013-11-20 at 18:06 +0200, Michael S. Tsirkin wrote: > Hmm some kind of disconnect here. > I got you rmanagement about bufferbloat. > > What I am saying is that maybe we should drop packets more > aggressively: when we drop one packet of a flow, why not > drop everything that's queued and is for the same flow? I really hope your TCP flows use SACK ;) Please read

Hi Ziqi, On 8/19/23 11:10, Ziqi Zhao wrote: > In the bug reported by Syzbot, certain bridge devices would have a > leaked reference created by race conditions in dev_ioctl, specifically, > under SIOCBRADDIF or SIOCBRDELIF operations. The reference leak would How would it leak a reference, could you elaborate? The reference is always taken and always released after the call. > be

On Wed, 2013-11-20 at 10:58 +0200, Michael S. Tsirkin wrote: > On Tue, Nov 19, 2013 at 02:00:11PM -0800, Eric Dumazet wrote: > > On Tue, 2013-11-19 at 23:53 +0200, Michael S. Tsirkin wrote: > > > > > Which NIC? Virtio? Prior to 2613af0ed18a11d5c566a81f9a6510b73180660a > > > it didn't drop packets received from host as far as I can tell. > > > virtio

...ex. This was also quite strange to me, since on the > surface it definitely looked like a deadlock, but the strict locking > order as I described previously should prevent any deadlocks from > happening. > > Anyways, I decided to test switching up the lock order, since both the > refcnt warning and the task stall seemed closely related to the above > mentioned locks. When I ran the reproducer again after the patch, both > the warning and the stall issue went away. So I guess the patch is > still relevant in preventing bugs in some extreme cases -- although the > scenar...

Further cleanup of the hv drivers: 1) Cleanup the reference counting mess for both stor and net devices. 2) Handle all block devices using the storvsc driver. 3) Accomodate some host side scsi emulation bugs. 4) In case of scsi errors off-line the device. Regads, K. Y