search for: refactor

Hi guys, I have one question: When refactoring the working code I need or should refactoring the specs too? My old code is: http://pastie.org/private/gpskgtavm4yzutanq1ro3w My new refactored code: http://pastie.org/private/2emgi1hr5iga3m9jib4q and the specs that are still passing without refactoring: http://pastie.org/private/qn3uaoin0...

...Austin, TX emenezes at codeaurora.org Qualcomm Innovation Center, Inc is a member of the Code Aurora Forum -------------- next part -------------- An embedded message was scrubbed... From: Jakob Stoklund Olesen <stoklund at 2pi.dk> Subject: Re: [LLVMdev] [RFC] Hexagon insn table refactoring Date: Mon, 13 Aug 2012 11:47:47 -0700 Size: 3124 URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120814/95e73c2b/attachment.eml> -------------- next part -------------- An embedded message was scrubbed... From: Evandro Menezes <emenezes at codeaurora.org> Subject: Re: [L...

I'm wondering if there are some tips for refactoring in R. I found the following website, which is still preliminary. Is there any program that can help me do refactoring in R? http://www.r-developer.org/projects/show/refactoring

...parate initrd (as it is much easier for us to build an initramfs as part of the kernel compile that *just works* for all the boot environments we care about). For the moment, it *seems* that the requirement is to just add a bunch of mountpoints, but I'm tempted to "fix" my problem by refactoring some of kinit. Currently, kinit is already setup as not much more than a wrapper that ties together the following components of the early boot up sequence: - ipconfig - nfsmount - resume - run-init The filesystem detection bits are also available as 'fstype'. The only thing neede...

Hi all, The PowerPC ELF backend of LLD is not in a particularly good state. It supports one relocation, has one test, and it does not seem to have received any commits other than tree-wide refactors since it was initially committed. It is also structured slightly differently to the other backends which means that refactoring patches that touch all the backends are made more difficult. Is anyone interested in maintaining this backend or would it be better to remove it? Thanks, -- Will Newt...

...gt; The find_inode API allows the User to search all the entries referring > > to a given inode and returns a tsk_dirent structure for each of them. > > > > As I didn't want to change unrelated code, there is a little bit > > of code duplication at the moment. Plan is to refactor the logic > > in a dedicated set of patches. > > The general idea looks ok, but I'd rather see the duplication dealt > with sooner than later. > In the previous submissions, non related changes were rejected therefore I thought that was the custom. Moreover I'll add anoth...

...they''re an approximation because if you use mocks everywhere (as I believe you ought to) then you''re not performing integrations and the specs are necessarily incomplete. Why does that idea matter? Traditionally, we''ve leaned heavily on a suite of unit tests to perform refactorings. In fact, Fowler says the first thing you have to do in order to refactor is grow a set of comprehensive unit tests. Refactoring, by definition, is changing the structure without changing the observable behavior. Implicit in using tests to enable refactoring is the idea that those tests prec...

*TL;DR* We propose some non-trivial refactoring in Clang and LLVM to enable further work on Flang driver. *SUMMARY* We would like to start extracting the driver/frontend code from Clang (alongside the code that the driver/frontend depends on, e.g. Diagnostics) and move the components that could be re-used by non-C-based languages to LLVM...

On Fri, Jul 25, 2014 at 10:08 PM, Yijing Wang <wangyijing at huawei.com> wrote: > Pci_dev_msi_enabled() is used to check whether device > MSI/MSIX enabled. Refactor this function to suuport > checking only device MSI or MSIX enabled. > > Signed-off-by: Yijing Wang <wangyijing at huawei.com> So this patch refactors things so that checks like this: > - if (!dev->msi_enabled) are moved into a function: > + if (!pci_dev...

On Fri, Jul 25, 2014 at 10:08 PM, Yijing Wang <wangyijing at huawei.com> wrote: > Pci_dev_msi_enabled() is used to check whether device > MSI/MSIX enabled. Refactor this function to suuport > checking only device MSI or MSIX enabled. > > Signed-off-by: Yijing Wang <wangyijing at huawei.com> So this patch refactors things so that checks like this: > - if (!dev->msi_enabled) are moved into a function: > + if (!pci_dev...

...stands, ActiveRecord has alot of private and protected methods in the Base class. >> ActiveRecord::Base.methods.size => 427 >> ActiveRecord::Base.protected_methods.size => 32 >> ActiveRecord::Base.private_methods.size => 193 I really loved the suggestion by Courtenay in Refactoring AR::Base.find (http://groups.google.com/group/rubyonrails-core/ browse_thread/thread/2ff2b3ce6732096f/776dae05ffa2d445). It not only makes extending find calls easier, but all wraps up all the find logic in one class. I whipped up a quick example patch for refactoring the calculations library t...

The patches contain some tidy-up work, and refactoring that has arisen as a by-product of my initial work on adding TV support to nv50. Best Regards Joel Holdsworth -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-drm-nouveau-Removed-unneeded-include-in-nvc0_fence.c.patch Type: text/x-patch Size: 726 bytes D...

The new "pending" example feature reminds me of a feature I''ve been bouncing around in my head, to aid in refactoring. Often, when I''m changing existing behaviour, I know that certain aspects of the old behaviour should change. Imagine changing the "it" method to perhaps "not" or "old" or "removed"... The behaviour would be to raise a spec error if the example DO...

A couple months ago I asked how stories and specs might impact each other. [1] If you look at Dan North''s example of what''s in a story [2], and you imagine using the spec framework to drive the design, you can probably imagine a significant bit of overlap in the two. Is that a bad thing? I''m not sure. It has made me a bit uncomfortable though, and I''ve

Hi, Attached are two patches. Patch 1 refactors silk_LPC_analysis_filter(). And Patch 2 optimizes the new function celt_fir_permit_overflow() for ARM NEON. Please recommend a better function name. We did the same internal code review and testing already. Thanks, Linfeng -------------- next part -------------- An HTML attachment was scrubbed....

I was wondering if anyone had any advice/experience with when you refactor controllers. Because the controllers are tied to the URL via the routes, it makes refactorings a little more complicated than they should be in some cases, especially if you don''t want the URLs to change. Of course the various filters with :only/except provide an additional flex poin...

...of things end up 'hidden away' in packages where they don't belong. My gregmisc package is a particularly egregious example, containing something from almost every functional category. I propose that from time to time the R community go through the complete set of packages and 'refactor' the functions and data sets into packages that have clearly defined goals. This should make it easier to ensure that new functions get placed into a location where users can easily find them, reduce the amount of re-implementation/duplication existing functionality, and assist in ensuring in...

...ue to historical reasons, the implementation of XDP in virtio-net is relatively > > > chaotic. For example, the processing of XDP actions has two copies of similar > > > code. Such as page, xdp_page processing, etc. > > > > > > The purpose of this patch set is to refactor these code. Reduce the difficulty > > > of subsequent maintenance. Subsequent developers will not introduce new bugs > > > because of some complex logical relationships. > > > > > > In addition, the supporting to AF_XDP that I want to submit later will also need...

...Wunner <lukas at wunner.de> wrote: > > +bool vga_switcheroo_client_probe_defer(struct pci_dev *pdev) > > +{ > > + if ((pdev->class >> 8) == PCI_CLASS_DISPLAY_VGA) { > Not sure if we want/need this, yet at least. This changes behaviour > which is not what refactoring patches should be doing, right ? if > needed it ought to be a separate patch, imho. Well, the commit message doesn't claim "no functional change", does it? Daniel Vetter explicitly wanted the ability to use the helper in vga_switcheroo audio clients, and those shouldn't ru...

On Tue, Jun 2, 2020 at 6:38 PM Richard Smith via llvm-dev < llvm-dev at lists.llvm.org> wrote: > On Tue, 2 Jun 2020 at 05:08, Andrzej Warzynski via cfe-dev < > cfe-dev at lists.llvm.org> wrote: > >> *TL;DR* >> >> We propose some non-trivial refactoring in Clang and LLVM to enable >> further work on Flang driver. >> >> *SUMMARY* >> We would like to start extracting the driver/frontend code from Clang >> (alongside the code that the driver/frontend depends on, e.g. >> Diagnostics) and move the components that...