search for: recursive_mutex

+llvmdev. I find this pretty surprising. Actually, we already use std::mutex and std::recursive_mutex in clang, lld, and other llvm projects, it's just a coincidence that it hadn't been introduced into LLVM until my commits. I'm not sure what the right thing to do here is. If I understand correctly, it seems like in order to encounter this, a) you must be using GCC, b) you must be usi...

It sounds like this version of libstdc++ doesn't support std::recursive_mutex from C++11. This is really unfortunate, because we were hoping that moving to C++11 would allow us to use standard, portable threading primitives. Does this version of MinGW have any C++11 threading support? Is it just recursive_mutex that is missing, or do we have to avoid std::mutex, std::call...

...> > The win32 version does not support anything thread-related so it's not > C++11 compliant? > > Yaron > > > > 2014-06-20 19:55 GMT+03:00 Reid Kleckner <rnk at google.com>: > >> It sounds like this version of libstdc++ doesn't support >> std::recursive_mutex from C++11. This is really unfortunate, because we >> were hoping that moving to C++11 would allow us to use standard, portable >> threading primitives. >> >> Does this version of MinGW have any C++11 threading support? Is it just >> recursive_mutex that is missing,...

...W, and > only disable this for threads-posix. We can check for > _GLIBCXX_HAS_GTHREADS, but that seems somewhat hackish, so I wonder if > there's a better way. > > To handle the switching, I guess we'll have to go back to the original > option of having llvm::mutex, llvm::recursive_mutex, etc, and then > conditionally typedefing them. Kinda sucks, but still better than getting > rid of it entirely. > > > On Fri, Jun 20, 2014 at 11:09 AM, Reid Kleckner <rnk at google.com> wrote: > >> OK, sounds like we're screwed. >> >> There's two...

As part of my effort to replace our hand-rolled mutexes with std::mutex and std::recursive_mutex, I found that many of the tests were failing on Windows after doing the replacement. One of the reasons was due to the use of a mutex in lib\Support\CrashRecoveryContext.cpp. If this mutex is an std::recursive_mutex or std::mutex, tests fail. If this mutex is a windows CRITICAL_SECTION, the test...

+chandlerc, aaronballman, in case there are additional carryovers and/or issues from the review thread which I've left out. I have a patch up for review[1, 2] that attempts to replace LLVM's mutex implementation with std::mutex and std::recursive_mutex. While the patch seems to work, there are questions surrounding whether or not the approach used is correct. I'll try to summarize the issues as best I can, in hopes of getting some feedback from a broader audience, to make sure this is done correctly: 1) Should support multi-threading be a...