search for: recursive_mkdir

The more I look at this patch, the less I like it. I would summarise why I think it's wrong here, but it's better if you look at the message I posted on the gnulib mailing list here first: http://lists.gnu.org/archive/html/bug-gnulib/2009-11/msg00434.html Directly accessing errno on Windows is wrong: you won't see the true reasons for an error by doing that. However depending on

This started as a simple warning-elimination change. I'll get back to that series shortly ;-) It turned into a factorization and constification exercise during which I got a taste of ocaml. Thanks to Rich Jones for help with a few snippets in generator.ml. The overall result is that many previously-manually-maintained bits from daemon/*.c functions are now hoisted into the automatically-

...; - return NULL; + reply_with_perror ("closedir: /sys/block/%s", devname); + free_stringslen (r, size); + return NULL; } } } diff --git a/daemon/dir.c b/daemon/dir.c index a8f066f..5945862 100644 --- a/daemon/dir.c +++ b/daemon/dir.c @@ -123,8 +123,8 @@ recursive_mkdir (const char *path) r = lstat (path, &buf); if (r == -1) return -1; if (!S_ISDIR (buf.st_mode)) { - errno = ENOTDIR; - return -1; + errno = ENOTDIR; + return -1; } return 0; /* OK - directory exists here already. */ } diff --git a/daemon/ex...