search for: reclaim_any

...below the low threshold > + * we move back to the NOT_RECLAIMING state. > + * > + * reclaim_blk is the last block that we will looked at. s/will // > + > +#ifdef HAVE_CACHE_RECLAIM > + > +static void reclaim_one (void); > +static void reclaim_lru (void); > +static void reclaim_any (void); > +static void reclaim_block (void); > + > +/* See if we need to reclaim blocks. */ > +static void > +reclaim (void) > +{ > + struct stat statbuf; > + uint64_t cache_allocated; > + > + /* If the user didn't set cache-max-size, do nothing. */ > + if (...

...mprove things later if profiling says we need to). > +/* Reclaim a single cache block. */ > +static void > +reclaim_one (int fd, struct bitmap *bm) > +{ > + assert (reclaiming); > + > + if (reclaiming == RECLAIMING_LRU) > + reclaim_lru (fd, bm); > + else > + reclaim_any (fd, bm); > +} > + > +static void > +reclaim_lru (int fd, struct bitmap *bm) > +{ > + uint64_t old_reclaim_blk; > + > + /* Find the next block in the cache. */ > + reclaim_blk = bitmap_next (bm, reclaim_blk+1); > + old_reclaim_blk = reclaim_blk; > + > + /* S...

v3 was broken by a bad rebase, so let's forget about that one. Compared to v2: - Patch 1 is the same except for a minor comment change. - Patch 2 splits the reclaim code into a separate file (filters/cache/reclaim.c) - Addressed Eric's comments from his review of v2. - Retested on Linux and FreeBSD.

...PRIu64 " (offset %" PRIu64 ")", blknum, (uint64_t) offset); @@ -254,3 +287,133 @@ for_each_dirty_block (block_callback f, void *vp) return 0; } + +#ifdef HAVE_CACHE_RECLAIM + +static void reclaim_one (void); +static void reclaim_lru (void); +static void reclaim_any (void); +static void reclaim_block (void); + +/* See if we need to reclaim blocks. */ +static void +reclaim (void) +{ + struct stat statbuf; + uint64_t cache_allocated; + + /* If the user didn't set cache-max-size, do nothing. */ + if (max_size == -1) return; + + /* Check the allocated siz...

...PRIu64 " (offset %" PRIu64 ")", blknum, (uint64_t) offset); @@ -254,3 +287,133 @@ for_each_dirty_block (block_callback f, void *vp) return 0; } + +#ifdef HAVE_CACHE_RECLAIM + +static void reclaim_one (void); +static void reclaim_lru (void); +static void reclaim_any (void); +static void reclaim_block (void); + +/* See if we need to reclaim blocks. */ +static void +reclaim (void) +{ + struct stat statbuf; + uint64_t cache_allocated; + + /* If the user didn't set cache-max-size, do nothing. */ + if (max_size == -1) return; + + /* Check the allocated siz...

...PRIu64 " (offset %" PRIu64 ")", blknum, (uint64_t) offset); @@ -254,3 +290,133 @@ for_each_dirty_block (block_callback f, void *vp) return 0; } + +#ifdef HAVE_CACHE_RECLAIM + +static void reclaim_one (void); +static void reclaim_lru (void); +static void reclaim_any (void); +static void reclaim_block (void); + +/* See if we need to reclaim blocks. */ +static void +reclaim (void) +{ + struct stat statbuf; + uint64_t cache_allocated; + + /* If the user didn't set cache-max-size, do nothing. */ + if (max_size == -1) return; + + /* Check the allocated siz...

...reclaim_state { + NOT_RECLAIMING = 0, + RECLAIMING_LRU = 1, + RECLAIMING_ANY = 2, +}; + +static enum reclaim_state reclaiming = NOT_RECLAIMING; +static uint64_t reclaim_blk; + +static void reclaim_one (int fd, struct bitmap *bm); +static void reclaim_lru (int fd, struct bitmap *bm); +static void reclaim_any (int fd, struct bitmap *bm); +static void reclaim_block (int fd, struct bitmap *bm); + +void +reclaim (int fd, struct bitmap *bm) +{ + struct stat statbuf; + uint64_t cache_allocated; + + /* If the user didn't set cache-max-size, do nothing. */ + if (max_size == -1) return; + + /* Check th...

...reclaim_state { + NOT_RECLAIMING = 0, + RECLAIMING_LRU = 1, + RECLAIMING_ANY = 2, +}; + +static enum reclaim_state reclaiming = NOT_RECLAIMING; +static uint64_t reclaim_blk; + +static void reclaim_one (int fd, struct bitmap *bm); +static void reclaim_lru (int fd, struct bitmap *bm); +static void reclaim_any (int fd, struct bitmap *bm); +static void reclaim_block (int fd, struct bitmap *bm); + +/* See if we need to reclaim blocks. */ +void +reclaim (int fd, struct bitmap *bm) +{ + struct stat statbuf; + uint64_t cache_allocated; + + /* If the user didn't set cache-max-size, do nothing. */ + if...

These are essentially identical to what was previously posted as patches 6/9 through 9/9 here: https://www.redhat.com/archives/libguestfs/2018-December/msg00145.html except that it has been rebased onto the current git master and retested thoroughly. Rich.

Patch 1 is the same as last time, except for a minor comment fix. Patch 2 should address everything that Eric mentioned in his review, and has been retested. Rich.

v4: https://www.redhat.com/archives/libguestfs/2019-January/msg00032.html v5: - Now we set the block size at run time. I'd like to say that I was able to test this change, but unfortunately I couldn't find any easy way to create a filesystem on x86-64 with a block size > 4K. Ext4 doesn't support it at all, and XFS doesn't support block size > page size (and I

This patch series enhances the cache filter in a few ways, primarily adding a "cache-on-read" feature (similar to qemu's copyonread); and adding the ability to limit the cache size and the antecedent of that which is having a method to reclaim cache blocks. As the cache is stored as a sparse temporary file, reclaiming cache blocks simply means punching holes in the temporary file.