search for: receiveq1

...gin{lstlisting} #define VIRTIO_NET_S_LINK_UP 1 #define VIRTIO_NET_S_ANNOUNCE 2 \end{lstlisting} -The following driver-read-only field, \field{max_virtqueue_pairs} only exists if -VIRTIO_NET_F_MQ is set. This field specifies the maximum number -of each of transmit and receive virtqueues (receiveq1\ldots receiveqN -and transmitq1\ldots transmitqN respectively) that can be configured once VIRTIO_NET_F_MQ -is negotiated. - \begin{lstlisting} struct virtio_net_config { u8 mac[6]; @@ -3140,6 +3131,35 @@ struct virtio_net_config { }; \end{lstlisting} +\field{mac}, \field{status}, \f...

...O_NET_S_LINK_UP 1 > #define VIRTIO_NET_S_ANNOUNCE 2 > \end{lstlisting} > > -The following driver-read-only field, \field{max_virtqueue_pairs} only exists if > -VIRTIO_NET_F_MQ is set. This field specifies the maximum number > -of each of transmit and receive virtqueues (receiveq1\ldots receiveqN > -and transmitq1\ldots transmitqN respectively) that can be configured once VIRTIO_NET_F_MQ > -is negotiated. > - > \begin{lstlisting} > struct virtio_net_config { > u8 mac[6]; > @@ -3140,6 +3131,35 @@ struct virtio_net_config { > }; > \end{l...

...y of two status bits depends on two > > different feature flags. > > > > Signed-off-by: Victor Kaplansky <victork at redhat.com> > > --- > > + > > +\item [\field{max_virtqueue_pairs}] tells the driver the maximum > > + number of each of virtqueues (receiveq1\ldots receiveqN and > > + transmitq1\ldots transmitqN respectively) that can be configured > > + on the device once VIRTIO_NET_F_MQ is negotiated. > > + \field{max_virtqueue_pairs} is valid only if VIRTIO_NET_F_MQ is > > + set and can be read by the driver. >...

...y of two status bits depends on two > > different feature flags. > > > > Signed-off-by: Victor Kaplansky <victork at redhat.com> > > --- > > + > > +\item [\field{max_virtqueue_pairs}] tells the driver the maximum > > + number of each of virtqueues (receiveq1\ldots receiveqN and > > + transmitq1\ldots transmitqN respectively) that can be configured > > + on the device once VIRTIO_NET_F_MQ is negotiated. > > + \field{max_virtqueue_pairs} is valid only if VIRTIO_NET_F_MQ is > > + set and can be read by the driver. >...

This set of two patches adds a new field called default_mtu to the configuration area of network devices. The motivation is to allow libvirt to set initial MTU different from 1500 on guests virtual NICs. We also propose to use this new field to report MTU changes by the guest OS to the device to facilitate debugging and mtu tunning. The first patch just clarify the definition of existing fields

This set of two patches adds a new field called default_mtu to the configuration area of network devices. The motivation is to allow libvirt to set initial MTU different from 1500 on guests virtual NICs. We also propose to use this new field to report MTU changes by the guest OS to the device to facilitate debugging and mtu tunning. The first patch just clarify the definition of existing fields

...uot; +\author 1986246365 "Michael S. Tsirkin" \end_header \begin_body @@ -3896,6 +3897,61 @@ Only if VIRTIO_NET_F_CTRL_VQ set \end_inset +\change_inserted 1986246365 1346663522 + 3: reserved +\end_layout + +\begin_layout Description + +\change_inserted 1986246365 1346663550 +4: receiveq1. + 5: transmitq1. + 6: receiveq2. + 7. + transmitq2. + ... + 2 +\emph on +N +\emph default ++2:receivq +\emph on +N +\emph default +, 2 +\emph on +N +\emph default ++3:transmitq +\emph on +N +\emph default + +\begin_inset Foot +status open + +\begin_layout Plain Layout + +\change_inserted 198624636...

...uot; +\author 1986246365 "Michael S. Tsirkin" \end_header \begin_body @@ -3896,6 +3897,61 @@ Only if VIRTIO_NET_F_CTRL_VQ set \end_inset +\change_inserted 1986246365 1346663522 + 3: reserved +\end_layout + +\begin_layout Description + +\change_inserted 1986246365 1346663550 +4: receiveq1. + 5: transmitq1. + 6: receiveq2. + 7. + transmitq2. + ... + 2 +\emph on +N +\emph default ++2:receivq +\emph on +N +\emph default +, 2 +\emph on +N +\emph default ++3:transmitq +\emph on +N +\emph default + +\begin_inset Foot +status open + +\begin_layout Plain Layout + +\change_inserted 198624636...

...uot; +\author 1986246365 "Michael S. Tsirkin" \end_header \begin_body @@ -3896,6 +3897,37 @@ Only if VIRTIO_NET_F_CTRL_VQ set \end_inset +\change_inserted 1986246365 1346663522 + 3: reserved +\end_layout + +\begin_layout Description + +\change_inserted 1986246365 1346663550 +4: receiveq1. + 5: transmitq1. + 6: receiveq2. + 7. + transmitq2. + ... + 2N+2:receivqN, 2N+3:transmitqN +\begin_inset Foot +status open + +\begin_layout Plain Layout + +\change_inserted 1986246365 1346663558 +Only if VIRTIO_NET_F_CTRL_VQ set. + N is indicated by max_virtqueue_pairs field. +\change_unchanged +...

...uot; +\author 1986246365 "Michael S. Tsirkin" \end_header \begin_body @@ -3896,6 +3897,37 @@ Only if VIRTIO_NET_F_CTRL_VQ set \end_inset +\change_inserted 1986246365 1346663522 + 3: reserved +\end_layout + +\begin_layout Description + +\change_inserted 1986246365 1346663550 +4: receiveq1. + 5: transmitq1. + 6: receiveq2. + 7. + transmitq2. + ... + 2N+2:receivqN, 2N+3:transmitqN +\begin_inset Foot +status open + +\begin_layout Plain Layout + +\change_inserted 1986246365 1346663558 +Only if VIRTIO_NET_F_CTRL_VQ set. + N is indicated by max_virtqueue_pairs field. +\change_unchanged +...

...this > case? That would not need a reset. > I'm not sure. It may complicate things. What if all TX vqs are small? What if all RX vqs are small? What if we end up with an unbalanced number of TX vqs and RX vqs? is this allowed by the spec? What if we end up disabling the RX default vq (receiveq1)? I guess we could do it, after checking some conditions. Maybe we can do it in a follow up patch? Do you think it's important for it to be included since day 1? I think that the question is: what's more important, to use all the vqs while blocking some features, or to use part of the vqs...

...depends on two >>> different feature flags. >>> >>> Signed-off-by: Victor Kaplansky <victork at redhat.com> >>> --- >>> + >>> +\item [\field{max_virtqueue_pairs}] tells the driver the maximum >>> + number of each of virtqueues (receiveq1\ldots receiveqN and >>> + transmitq1\ldots transmitqN respectively) that can be configured >>> + on the device once VIRTIO_NET_F_MQ is negotiated. >>> + \field{max_virtqueue_pairs} is valid only if VIRTIO_NET_F_MQ is >>> + set and can be read by the d...

...uot; +\author 1986246365 "Michael S. Tsirkin" \end_header \begin_body @@ -3896,6 +3897,37 @@ Only if VIRTIO_NET_F_CTRL_VQ set \end_inset +\change_inserted 1986246365 1346663522 + 3: reserved +\end_layout + +\begin_layout Description + +\change_inserted 1986246365 1346663550 +4: receiveq1. + 5: transmitq1. + 6: receiveq2. + 7. + transmitq2. + ... + 2N+2:receivqN, 2N+3:transmitqN +\begin_inset Foot +status open + +\begin_layout Plain Layout + +\change_inserted 1986246365 1346663558 +Only if VIRTIO_NET_F_CTRL_VQ set. + N is indicated by max_virtqueue_pairs field. +\change_unchanged +...

...uot; +\author 1986246365 "Michael S. Tsirkin" \end_header \begin_body @@ -3896,6 +3897,37 @@ Only if VIRTIO_NET_F_CTRL_VQ set \end_inset +\change_inserted 1986246365 1346663522 + 3: reserved +\end_layout + +\begin_layout Description + +\change_inserted 1986246365 1346663550 +4: receiveq1. + 5: transmitq1. + 6: receiveq2. + 7. + transmitq2. + ... + 2N+2:receivqN, 2N+3:transmitqN +\begin_inset Foot +status open + +\begin_layout Plain Layout + +\change_inserted 1986246365 1346663558 +Only if VIRTIO_NET_F_CTRL_VQ set. + N is indicated by max_virtqueue_pairs field. +\change_unchanged +...

...VIRTIO_NET_F_CTRL_VQ set @@ -3867,9 +3879,60 @@ Only if VIRTIO_NET_F_CTRL_VQ set \end_inset +\change_inserted 2090695081 1340693122 + \end_layout \begin_layout Description + +\change_inserted 2090695081 1340693866 +When VIRTIO_NET_F_MULTIQUEUE is set and there's N tx/rx queue pairs: 0:receiveq1. + 1:transmitq1. + 2:controlq +\begin_inset Foot +status collapsed + +\begin_layout Plain Layout + +\change_inserted 2090695081 1340693141 +Only if VIRTIO_NET_F_CTRL_VQ set +\end_layout + +\end_inset + + ... + 2N-1 +\begin_inset Foot +status collapsed + +\begin_layout Plain Layout + +\change_insert...

...VIRTIO_NET_F_CTRL_VQ set @@ -3867,9 +3879,60 @@ Only if VIRTIO_NET_F_CTRL_VQ set \end_inset +\change_inserted 2090695081 1340693122 + \end_layout \begin_layout Description + +\change_inserted 2090695081 1340693866 +When VIRTIO_NET_F_MULTIQUEUE is set and there's N tx/rx queue pairs: 0:receiveq1. + 1:transmitq1. + 2:controlq +\begin_inset Foot +status collapsed + +\begin_layout Plain Layout + +\change_inserted 2090695081 1340693141 +Only if VIRTIO_NET_F_CTRL_VQ set +\end_layout + +\end_inset + + ... + 2N-1 +\begin_inset Foot +status collapsed + +\begin_layout Plain Layout + +\change_insert...

...eset. > > > > I'm not sure. It may complicate things. > > What if all TX vqs are small? > What if all RX vqs are small? > What if we end up with an unbalanced number of TX vqs and RX vqs? is this allowed by the spec? > What if we end up disabling the RX default vq (receiveq1)? > > I guess we could do it, after checking some conditions. > Maybe we can do it in a follow up patch? > Do you think it's important for it to be included since day 1? > > I think that the question is: what's more important, to use all the vqs while blocking some featu...

On Sun, Apr 30, 2023 at 04:15:17PM +0300, Alvaro Karsz wrote: > At the moment, if a network device uses vrings with less than > MAX_SKB_FRAGS + 2 entries, the device won't be functional. > > The following condition vq->num_free >= 2 + MAX_SKB_FRAGS will always > evaluate to false, leading to TX timeouts. > > This patch introduces a new variable,