search for: receive_file_data

The handle can only store one error, so if an error path has more than one call to error/perrorf, then the earlier error will be lost and overwritten by the later one. Fix two (more) cases of this. Rich.

...nd file in chunked encoding. */ while (!g->user_cancel) { @@ -829,7 +816,7 @@ guestfs_int_recv_file (guestfs_h *g, const char *filename) goto cancel; } - fadvise_sequential (fd); + guestfs_int_fadvise_sequential (fd); /* Receive the file in chunked encoding. */ while ((r = receive_file_data (g, &buf)) > 0) { diff --git a/src/utils.c b/src/utils.c index a0e8f98..bbb2d12 100644 --- a/src/utils.c +++ b/src/utils.c @@ -35,6 +35,8 @@ #include <sys/wait.h> #include <libintl.h> +#include "ignore-value.h" + /* NB: MUST NOT include "guestfs-internal.h&quo...

The way we used posix_fadvise was wrong, and yet right! Rich.

I've been taking a long hard look at the protocol layer. It has evolved over a long time without any particular direction, and the result is, to say the least, not very organized. These patches take a first step at cleaning up the mess by abstracting out socket operations from the rest of the code. The purpose of this is to allow us to slot in a different connection layer under the

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.