search for: readsetp

...tch: diff -rNu openssh-4.3p2/clientloop.c openssh-4.3p2-alive-fixed/clientloop.c --- openssh-4.3p2/clientloop.c 2005-12-31 07:22:32.000000000 +0200 +++ openssh-4.3p2-alive-fixed/clientloop.c 2006-04-22 19:32:17.000000000 +0300 @@ -456,7 +456,7 @@ client_wait_until_can_do_something(fd_set **readsetp, fd_set **writesetp, int *maxfdp, u_int *nallocp, int rekeying) { - struct timeval tv, *tvp; + static struct timeval tv, *tvp; int ret; /* Add any selections by the channel mechanism. */ @@ -508,12 +508,16 @@ if (options.server_alive_interval == 0 ||...

...s. */ --- channels.c~ Wed Jun 13 15:18:05 2001 +++ channels.c Thu Jul 12 08:32:53 2001 @@ -1160,6 +1160,14 @@ } void +channel_zero_set(fd_set *setp, int maxfdp) +{ + u_int sz = howmany(maxfdp+1, NFDBITS) * sizeof(fd_mask); + + memset(setp, 0, sz); +} + +void channel_prepare_select(fd_set **readsetp, fd_set **writesetp, int *maxfdp, int rekeying) { @@ -1178,8 +1186,8 @@ *writesetp = xmalloc(sz); *maxfdp = n; } - memset(*readsetp, 0, sz); - memset(*writesetp, 0, sz); + channel_zero_set(*readsetp, *maxfdp); + channel_zero_set(*writesetp, *maxfdp); if (!rekeying) channel_hand...

during my seminar of advanced exploitation techniques (SEAT, [1]) i developed some methods to crack into system via DMA (e.g. via firewire). as part of this i developed a program that steals loaded ssh private keys from ssh-agents. i was astonished to find that the keys are not immediately removed from the agent when a timeout occurs, but only the next time the agent is queried via its socket. i

...om efd 12 debug2: channel 0: closing read-efd 12 debug2: channel 0: ibuf empty debug2: channel 0: send eof debug2: channel 0: input drain -> closed ------------------- I have tried my hand at gdb, and this is the output and backtrace before the session hangs. (gdb) wait_until_can_do_something (readsetp=0x7ffff8e4, writesetp=0x7ffff8e0, maxfdp=0x7ffff8dc, nallocp=0x7ffff8d8, max_time_milliseconds=0) at serverloop.c:313 313 if (child_terminated && packet_not_very_much_data_to_write()) (gdb) 317 if (max_time_milliseconds == 0) (gdb) 318 tvp...

...d at xs4all.nl (@ @) The Netherlands ------------------------------oOO--(_)--OOo------------------ --- openssh-2.9.9p2/clientloop.c.orig Tue Sep 18 07:51:14 2001 +++ openssh-2.9.9p2/clientloop.c Thu Oct 11 22:03:09 2001 @@ -320,6 +320,9 @@ client_wait_until_can_do_something(fd_set **readsetp, fd_set **writesetp, int *maxfdp, int *nallocp, int rekeying) { + struct timeval tv; + int n; + /* Add any selections by the channel mechanism. */ channel_prepare_select(readsetp, writesetp, maxfdp, nallocp, rekeying); @@ -364,7 +367,24 @@ * SSH_MSG_IGNORE packet when the timeout exp...

...SH2: login session closed. */ - +enum SessionStatus {SessionOpen, SessionClose, SessionWait}; +static int session_status = SessionOpen; /* In SSH2: login session closed. */ void client_init_dispatch(void); int session_ident = -1; @@ -324,6 +324,10 @@ client_wait_until_can_do_something(fd_set **readsetp, fd_set **writesetp, int *maxfdp, int rekeying) { + struct timeval timer; + struct timeval *timerp; + int rc; + /* Add any selections by the channel mechanism. */ channel_prepare_select(readsetp, writesetp, maxfdp, rekeying); @@ -346,7 +350,15 @@ if (buffer_len(&stderr_buffer) &...

...rom efd 12 debug2: channel 0: closing read-efd 12 debug2: channel 0: ibuf empty debug2: channel 0: send eof debug2: channel 0: input drain -> closed --->hangs<--- -------------------------------------------- below is a backtrace from gdb: (gdb) s 326 ret = select((*maxfdp)+1, *readsetp, *writesetp, NULL, tvp); (gdb) l 321 tv.tv_usec = 1000 * (max_time_milliseconds % 1000); 322 tvp = &tv; 323 } 324 325 /* Wait for something to happen, or the timeout to expire. */ 326 ret = select((*maxfdp)+1, *readsetp...

...login session closed. */ +enum SessionStatus {SessionOpen, SessionClose, SessionWait}; +static int session_status = SessionOpen; /* In SSH2: login session closed. */ static void client_init_dispatch(void); int session_ident = -1; @@ -320,6 +322,10 @@ client_wait_until_can_do_something(fd_set **readsetp, fd_set **writesetp, int *maxfdp, int *nallocp, int rekeying) { + struct timeval timer; + struct timeval *timerp; + int rc; + /* Add any selections by the channel mechanism. */ channel_prepare_select(readsetp, writesetp, maxfdp, nallocp, rekeying); @@ -343,11 +349,12 @@ FD_SET(file...

I'm reading this fine article on O'Reilly: http://linux.oreillynet.com/lpt/a//linux/2001/11/08/ssh_keystroke.html <quote> The paper concludes that the keystroke timing data observable from today's SSH implementations reveals a dangerously significant amount of information about user terminal sessions--enough to locate typed passwords in the session data stream and reduce the

...login session closed. */ +enum SessionStatus {SessionOpen, SessionClose, SessionWait}; +static int session_status = SessionOpen; /* In SSH2: login session closed. */ static void client_init_dispatch(void); int session_ident = -1; @@ -320,6 +322,10 @@ client_wait_until_can_do_something(fd_set **readsetp, fd_set **writesetp, int *maxfdp, int *nallocp, int rekeying) { + struct timeval timer; + struct timeval *timerp; + int rc; + /* Add any selections by the channel mechanism. */ channel_prepare_select(readsetp, writesetp, maxfdp, nallocp, rekeying); @@ -343,7 +349,7 @@ FD_SET(fileno...

...-1) + options->noop_msg_frequency = 0; if (options->compression_level == -1) options->compression_level = 6; if (options->port == -1) --- clientloop.c 2001/03/06 03:34:40 1.36 +++ clientloop.c 2001/03/14 19:11:21 @@ -365,6 +365,10 @@ client_wait_until_can_do_something(fd_set **readsetp, fd_set **writesetp, int *maxfdp) { + struct timeval tv = {0}; + tv.tv_sec = options.noop_msg_frequency; + /* Send a noop message at this frequency as a keepalive. */ + /* Add any selections by the channel mechanism. */ channel_prepare_select(readsetp, writesetp, maxfdp); @@ -403,7 +40...

In the changelog, there is an entry: 20001129 - (djm) Back out all the serverloop.c hacks. sshd will now hang again if there are background children with open fds. Does this mean that this is regarded as expected (and correct) behavior, that should not change in the future, or does it mean that this behavior is a known problem that someone will eventually fix? --Adam -- Adam McKenna

...n. We should > be using mysignal by default now, but it may have > disagreeable results. > > - Ben > Commented out the #define signal (a,b) mysignal(a,b) in bsd-misc.h, recompiled ( make clean && make ) still the same problem exists: (gdb) wait_until_can_do_something (readsetp=0x7ffff8e4, writesetp=0x7ffff8e0, maxfdp=0x7ffff8dc, nallocp=0x7ffff8d8, max_time_milliseconds=0) at serverloop.c:313 313 if (child_terminated && packet_not_very_much_data_to_write()) (gdb) 317 if (max_time_milliseconds == 0) (gdb) 318 tvp...

...in a german gdb howto i found a tip that the backtrace output can help to analyse the problem.... is it a solaris problem ? Greetings Frank sshd: #0 0xff19d618 in _poll () from /usr/lib/libc.so.1 #1 0xff14d53c in select () from /usr/lib/libc.so.1 #2 0x000339a0 in wait_until_can_do_something (readsetp=0xffbee5dc, writesetp=0xffbee5d8, maxfdp=0xffbee5d4, nallocp=0xffbee5d0, max_time_milliseconds=0) at serverloop.c:325 #3 0x00034d6c in server_loop2 (authctxt=0x123ac8) at serverloop.c:776 #4 0x0003ae0c in do_authenticated (authctxt=0x123ac8) at session.c:2265 #5 0x0002ea78 in main (ac=116121...

...Patch against openssh-2.9p2. /Martin diff -ur openssh-2.9p2/clientloop.c openssh-2.9p2.servalive/clientloop.c --- openssh-2.9p2/clientloop.c Fri Apr 20 14:50:51 2001 +++ openssh-2.9p2.servalive/clientloop.c Wed Sep 26 12:58:38 2001 @@ -324,6 +324,9 @@ client_wait_until_can_do_something(fd_set **readsetp, fd_set **writesetp, int *maxfdp, int rekeying) { + struct timeval tv, *tvp = &tv; + int ret; + /* Add any selections by the channel mechanism. */ channel_prepare_select(readsetp, writesetp, maxfdp, rekeying); @@ -356,13 +359,29 @@ /* * Wait for something to happen. This will...

http://bugzilla.mindrot.org/show_bug.cgi?id=52 dtucker at zip.com.au changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |1274 nThis| | ------- You are receiving this mail because: ------- You are the assignee for

Using OpenSSH_8.3p1 I had an open (working) connection to some other box; after a bit of inactivity, some device in the middle seems to have forgotten about the TCP connection (NAT) and broke it. I've got an EscapeChar defined, though; so first I tried to send a BREAK and, when that didn't help (TCP already gone, packets get lost!), I tried (just out of curiosity) a Rekey. Now I can see

...login session closed. */ +enum SessionStatus {SessionOpen, SessionClose, SessionWait}; +static int session_status = SessionOpen; /* In SSH2: login session closed. */ static void client_init_dispatch(void); int session_ident = -1; @@ -320,6 +322,10 @@ client_wait_until_can_do_something(fd_set **readsetp, fd_set **writesetp, int *maxfdp, int *nallocp, int rekeying) { + struct timeval timer; + struct timeval *timerp; + int rc; + /* Add any selections by the channel mechanism. */ channel_prepare_select(readsetp, writesetp, maxfdp, nallocp, rekeying); @@ -343,7 +349,7 @@ FD_SET(fileno...

Heya, Most of the windows ssh clients (putty, securecrt) have anti-idle features. They offer either a null packet or protocol no-op or user defined string to be sent over every x seconds. Is this possible or planned with the OpenSSH client? Our draconian firewall admins have started timing out ssh sessions. Yes I'm aware I could hack up a port forwarding dumb traffic process, but was

...99,6 +138,7 @@ debug("Received SIGCHLD."); child_terminated = 1; signal(SIGCHLD, sigchld_handler); + notify_parent(); errno = save_errno; } @@ -242,6 +282,7 @@ if (fdin != -1 && buffer_len(&stdin_buffer) > 0) FD_SET(fdin, *writesetp); } + notify_prepare(*readsetp); /* * If we have buffered packet data going to the client, mark that @@ -278,6 +319,8 @@ error("select: %.100s", strerror(errno)); } else if (ret == 0 && client_alive_scheduled) client_alive_check(); + + notify_done(*readsetp); } /* @@ -467,6 +510,8 @@ conne...