search for: readpass

The patch below fixes a compile-time warning in readpass.c. MIME-Version: 1.0 Content-Type: application/aegis-patch Subject: openssh.2 - Fix warning in readpass.c Content-Name: openssh.2.C010.patch Content-Disposition: attachment; filename=openssh.2.C010.patch X-Aegis-Project-Name: openssh.2 X-Aegis-Change-Number: 10 # # Fix the following warning in r...

To make readpass.c work on first try with gnome-askpass on RHL 7.1: wget http://bass.directhit.com/openssh_snap/openssh-SNAP-20011023.tar.gz tar xfz openssh-SNAP-20011023.tar.gz cd openssh ./configure --with-pam --enable-gnome-askpass --with-tcp-wrappers mv readpass.c readpass.c1 new readpass.c according to patch...

...The patch is against the 3.7p1 release because that's the code I was using. If it's doesn't incorporate well into whatever you are working on now, let me know, and I'll try to get something from your CVS repositories and diff against that. (I don't think, however, that the readpassphrase portion of the code is changing much these days.) There is one major test which I have been unable to perform: I haven't checked to see what happens if you don't have access to a GUI for the "unlock keychain prompt" which OS X throws up (i.e. you are logging in to an OS...

...quot;/sw/HPN-ssh/libexec/sftp-server\" - D_PATH_SSH_KEY_SIGN=\"/sw/HPN -ssh/libexec/ssh-keysign\" -D_PATH_SSH_PIDDIR=\"/var/run\" - D_PATH_PRIVSEP_CHROOT_DIR=\"/var/e mpty\" -DSSH_RAND_HELPER=\"/sw/HPN-ssh/libexec/ssh-rand-helper\" - DHAVE_CONFIG_H -c readpass.c openbsd-compat/vis.h:85: bad attribute specification, expecting identifier, found `)' openbsd-compat/vis.h:87: bad attribute specification, expecting identifier, found `)' openbsd-compat/vis.h:91: bad attribute specification, expecting identifier, found `)' readpass.c:40: warnin...

...ersion: OpenBSD Status: NEW Severity: normal Priority: P1 Component: Build system AssignedTo: openssh-unix-dev at mindrot.org ReportedBy: krh at lemniscate.net When trying to compile recent OpenSSH-portable snapshots on OpenBSD 3.1, I get: readpass.c: In function `read_passphrase': readpass.c:100: `RPP_ECHO_ON' undeclared (first use in this function) readpass.c:100: (Each undeclared identifier is reported only once readpass.c:100: for each function it appears in.) readpass.c:100: `RPP_ECHO_OFF' undeclared (first use in this functi...

OpenSSH Version 2.9p1 of "ssh-add $HOME/.ssh/id_rsa < /dev/null" fails on the first try of using ssh-askpass before the window manager starts. The second try works. The error message on the first try is "Bad passphrase, try again". This did not occur using OpenSSH-2.5.2p2.tar.gz. I've tested this on both RHL6.2 and RHL7.1, both with all RH rpm updates applied. I

...ax number of password * prompts. */ + int password_from_fd; /* Read password from file descriptor */ int cipher; /* Cipher to use. */ char *ciphers; /* SSH2 ciphers in order of preference. */ char *macs; /* SSH2 macs in order of preference. */ diff -bur openssh-3.1p1.org/readpass.c openssh-3.1p1/readpass.c --- openssh-3.1p1.org/readpass.c Wed Feb 13 04:05:23 2002 +++ openssh-3.1p1/readpass.c Mon Apr 22 10:27:49 2002 @@ -124,4 +124,29 @@ ret = xstrdup(buf); memset(buf, 'x', sizeof buf); return ret; +} + +char * +read_password_from_fd(int fd) +{ + ssize_t nr;...

...uthentication and the Gnome askpass dialog appears. In this dialog, clicking "Cancel" or closing the dialog via "X" causes SSH to send an empty string which will very likely end up causing an authentication failure on the target machine. This empty string comes from line 183 of readpass.c (https://github.com/openssh/openssh-portable/blob/bf944e3794eff5413f2df1ef37cddf96918c6bde/readpass.c#L183), which is happening because the RP_ALLOW_EOF flag is not set from the caller on line 1961 of sshconnect2.c (https://github.com/openssh/openssh-portable/blob/bf944e3794eff5413f2df1ef37cddf96...

...s not used as a last resort without a valid terminal or display. Is it an intended behaviour ? And if so, what are the security implications of using popen() to write the password to ssh-add (not using echo password|ssh-add of course). I used this patch solves the issue : diff -Nru openssh-5.6p1/readpass.c openssh-5.6p1-b/readpass.c --- openssh-5.6p1/readpass.c 2006-08-05 04:39:40.000000000 +0200 +++ openssh-5.6p1-b/readpass.c 2011-01-18 09:52:34.000000000 +0100 @@ -123,6 +123,7 @@ if (!isatty(STDIN_FILENO)) { debug("read_passphrase: stdin is not a tty"); use_askpass = 1; + r...

...======= RCS file: /cvs/openssh/readconf.h,v retrieving revision 1.56 diff -u -r1.56 readconf.h --- readconf.h 17 Jul 2004 06:12:08 -0000 1.56 +++ readconf.h 3 Oct 2004 10:58:52 -0000 @@ -111,6 +111,7 @@ char *control_path; int control_master; + int prefer_askpass; } Options; Index: readpass.c =================================================================== RCS file: /cvs/openssh/readpass.c,v retrieving revision 1.28 diff -u -r1.28 readpass.c --- readpass.c 17 Jun 2004 15:19:03 -0000 1.28 +++ readpass.c 3 Oct 2004 10:58:53 -0000 @@ -30,6 +30,9 @@ #include "pathnames.h" #...

...intended here, so my patched version of ssh2_try_passwd() keeps the same (broken?) logic. Regards, -- James Ralston, Information Technology Software Engineering Institute Carnegie Mellon University, Pittsburgh, PA, USA -------------- next part -------------- diff -U 3 -N -r ORIG/openssh-2.2.0p1/readpass.c openssh-2.2.0p1/readpass.c --- ORIG/openssh-2.2.0p1/readpass.c Thu Jun 22 07:32:32 2000 +++ openssh-2.2.0p1/readpass.c Sat Sep 9 01:10:07 2000 @@ -117,3 +117,48 @@ memset(buf, 0, sizeof(buf)); return (p); } + +/* + * Reads a passphrase by calling ssh-askpass. Returns the passphrase + * (al...

...to mimic the non-free SSH's behaviour of calling ssh-askpass when it's not possible to read the pass{phrase,word} from a terminal. This is rather inconvenient for things like pcl-cvs in Emacs. Here's a patch that makes OpenSSH act more like the non-free one: diff -ur openssh-1.2pre16/readpass.c openssh-1.2pre16.patched/readpass.c --- openssh-1.2pre16/readpass.c Wed Nov 24 19:54:59 1999 +++ openssh-1.2pre16.patched/readpass.c Thu Dec 9 22:34:23 1999 @@ -38,6 +38,47 @@ kill(getpid(), sig); } +/* Calls the external program specified to read a passphrase (usually + used to invoke ss...

...:-) OK, I've tracked down lots of goofy stuff w/ slack7 and OpenSSH I've got a couple of questions. What is /dev/tty and why does ssh try to open it to read the password instead of stdin?(this cause ssh to die w/ "You have no controlling tty. Cannot read passphrase.\n", line 69 of readpass.c, I've made it work by calling password = read_passphrase(prompt, 1); instead of password = read_passphrase(prompt, 0); in sshconnect.c line 940 Second, in sshd.c in the do_exec_no_pty function, line 2017 or so: if (dup2(inout[0], 1) < 0) /* stdout. Note: same socket as stdin. */...

Requests first: after a build, "make" always remakes all the .out files; maybe we could add a few dependencies there? And could we possibly have a few more '@if' lines in the Makefile to quiet it down? These should be obvious: --- #readpass.c Fri Apr 20 13:17:39 2001 +++ readpass.c Fri Apr 20 13:37:26 2001 @@ -43,7 +43,7 @@ #include "ssh.h" char * -ssh_askpass(char *askpass, char *msg) +ssh_askpass(char *askpass, const char *msg) { pid_t pid; size_t len; --- #scp.c Fri Apr 20 13:17:39 2001 +++ scp....

In openssh_cvs/openbsd-compat: readpassphrase.c: In function `readpassphrase': readpassphrase.c:116: warning: operation on `ch' may be undefined The offending line is: ch = ch &= 0x7f; probably should be: ch &= 0x7f; In openssh-2.9p2: readpass.c: In functi...

Hi, There is small bug in ssh_askpass(). Fix like this. Additionally removing '\r' is for Win32 environment. --- readpass.c 2001/10/09 05:42:49 1.1.1.1 +++ readpass.c 2001/10/09 08:06:38 @@ -45,7 +45,7 @@ { pid_t pid; size_t len; - char *nl, *pass; + char *pass; int p[2], status; char buf[1024]; @@ -71,16 +71,15 @@ fatal("ssh_askpass: exec(%s): %s", askpass, strerror(errno)); } close(p[1]);...

Hi, I'm looking at integrating sftp into a larger project. It would be nice if there was a way to force read_passphrase() (in readpass.c) to use SSH_ASKPASS regardless of the properties of the terminal. This would be easy enough to do, an environment variable or a new flag definition would achieve this (I'm using an environment variable for convenience at the moment). Would anyone be interested in receiving a patch for t...

...[atomicio.h authfd.h authfile.h auth.h auth-options.h bufaux.h buffer.h canohost.h channels.h cipher.h clientloop.h compat.h compress.h crc32.h deattack.h dh.h dispatch.h groupaccess.h hostfile.h kex.h key.h log.h mac.h match.h misc.h mpaux.h packet.h radix.h readconf.h readpass.h rsa.h] prototype pedant. not very creative... - () -> (void) - no variable names - itojun at cvs.openbsd.org 2001/06/26 06:33:07 [servconf.h serverloop.h session.h sftp-client.h sftp-common.h sftp-glob.h sftp-int.h sshconnect.h ssh-dss.h sshlogin.h sshpty.h...

...ent: Build system AssignedTo: bitbucket at mindrot.org ReportedBy: pirzyk at uiuc.edu This is due to including paths.h from multiple locations. It is included via includes.h as well as directly in the following c files: ./auth.c ./clientloop.c ./loginrec.c ./misc.c ./monitor.c ./readpass.c ./session.c ./sftp.c ./ssh-agent.c ./ssh-keygen.c ./ssh-keysign.c ./ssh.c ./sshconnect.c ./sshd.c ./sshpty.c Removing the following code fragment from the c files allows OpenSSH to compile on AIX: #ifdef HAVE_PATHS_H # include <paths.h> #endif For reference, here is a compile time err...

...in.ORIG Thu Nov 25 12:40:22 1999 --- Makefile.in Wed Dec 1 12:09:37 1999 *************** *** 34,40 **** all: $(OBJS) $(TARGETS) ! libssh.a: authfd.o authfile.o bufaux.o buffer.o canohost.o channels.o cipher.o compat.o compress.o crc32.o deattack.o hostfile.o match.o mpaux.o nchan.o packet.o readpass.o rsa.o tildexpand.o ttymodes.o uidswap.o xmalloc.o helper.o rc4.o bsd-mktemp.o bsd-strlcpy.o bsd-strlcat.o log.o fingerprint.o $(AR) rv $@ $^ $(RANLIB) $@ --- 34,40 ---- all: $(OBJS) $(TARGETS) ! libssh.a: authfd.o authfile.o bufaux.o buffer.o canohost.o channels.o cipher.o co...