search for: readonlydisk

This is only lightly tested at the moment. For context see: https://bugzilla.redhat.com/show_bug.cgi?id=1138203#c40 https://bugzilla.redhat.com/show_bug.cgi?id=1075143 https://bugzilla.redhat.com/show_bug.cgi?id=1075164 Note this is not a complete fix. At least one more libguestfs patch is required (to implement virDomainPtr in the python bindings). Plus a virt-manager patch. Rich.

This completes the implementation on the libguestfs side, allowing python-libvirt dom pointers to be passed to guestfs_add_libvirt_dom. For context see: https://bugzilla.redhat.com/show_bug.cgi?id=1138203#c40 https://bugzilla.redhat.com/show_bug.cgi?id=1075143 https://bugzilla.redhat.com/show_bug.cgi?id=1075164 Rich.

A hopefully cleaner implementation this time. It doesn't require any special insights into how libvirt-python is implemented. Instead, it requires a change to libvirt-python to add a .c_pointer() method: https://www.redhat.com/archives/libvir-list/2014-December/msg00615.html Rich.

This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. This is now working, after fixing the rather stupid bug in fstrim. I've pushed the ones which were ACKed previously + the fstrim fix. Rich.

Since v3: - Fix labelling over overlays (see 6/6) - Tested it with a test program which simulates what virt-manager will do. See the attachment here: https://bugzilla.redhat.com/show_bug.cgi?id=1075164#c7 Rich.

...ernel(1) man page for further information.") - | Some _, Some _ -> - error (f_"you cannot give -a and -d options together. Read virt-get-kernel(1) man page for further information.") - | None, Some dom -> - fun (g : Guestfs.guestfs) -> - let readonlydisk = "ignore" (* ignore CDs, data drives *) in - ignore (g#add_domain - ~readonly:true ~allowuuid:true ~readonlydisk - ?libvirturi dom) - | Some uri, None -> - fun g -> - let { URI.path = path; protocol = protocol; -...

This still isn't working at the moment. See: http://marc.info/?t=139457409300003&r=1&w=2 This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. Rich.

Just refactoring, no change. --- sparsify/cmdline.ml | 49 +++++++++++++++++++++++-------------------------- 1 file changed, 23 insertions(+), 26 deletions(-) diff --git a/sparsify/cmdline.ml b/sparsify/cmdline.ml index ce2b913..bd49e71 100644 --- a/sparsify/cmdline.ml +++ b/sparsify/cmdline.ml @@ -98,6 +98,7 @@ read the man page virt-sparsify(1). let check_tmpdir = !check_tmpdir in let

...formal API and can be removed or changed at any time."); - ("add_domain", (RInt "nrdisks", [String "dom"], [OString "libvirturi"; OBool "readonly"; OString "iface"; OBool "live"; OBool "allowuuid"; OString "readonlydisk"]), -1, [FishAlias "domain"], + ("add_domain", (RInt "nrdisks", [String "dom"], [OString "libvirturi"; OBool "readonly"; OString "iface"; OBool "live"; OBool "allowuuid"; OString "readonlydisk"...

https://bugzilla.redhat.com/show_bug.cgi?id=912499 (especially comments 7 & 10) This patch set is the final fix so that we can access disks in use by other guests when SELinux and sVirt are enabled. Previously such disks were inaccessible because sVirt labels the disks with a random SELinux label to prevent other instances of qemu from being able to read them. So naturally the libguestfs

...server, const char *username, void *data); +static int add_disk (guestfs_h *g, const char *filename, const char *format, int readonly, const char *protocol, char *const *server, const char *username, const char *secret, void *data); static int connect_live (guestfs_h *g, virDomainPtr dom); enum readonlydisk { @@ -325,7 +331,7 @@ static int add_disk (guestfs_h *g, const char *filename, const char *format, int readonly_in_xml, const char *protocol, char *const *server, const char *username, - void *datavp) + const char *secret, void *datavp) { struct add_disk...

...found or fixed in this release) New APIs compress-out, compress-device-out, copy-device-to-device, copy-device-to-file, copy-file-to-device, copy-file-to-file, get-smp, part-to-partnum, set-smp. The mount API no longer implicitly adds -o sync,noatime options. add-domain has a new 'readonlydisk' optional parameter to control how <readonly/> disks are handled. Internals - Coverity was run on the source and more bugs were identified and fixed. - PCRE library is now required to build libguestfs. - APIC is now the default for the appliance. You can also enable SMP su...

...Do not edit the output.* Examining the guest ... libguestfs: trace: set_verbose true libguestfs: trace: set_verbose = 0 libguestfs: create: flags = 0, handle = 0x1d9fcc0, program = virt-sysprep libguestfs: trace: add_domain "ryu" "readonly:false" "allowuuid:true" "readonlydisk:ignore" libguestfs: opening libvirt handle: URI = NULL, auth = virConnectAuthPtrDefault, flags = 1 libguestfs: successfully opened libvirt handle: conn = 0x1da04a0 libguestfs: trace: internal_set_libvirt_selinux_norelabel_disks false libguestfs: trace: internal_set_libvirt_selinux_norelabel_di...

Move the checks for empty xmlXPathObjectPtr, and for extracting the result string out of it, to a new helper functions. This is just code motion, there should be no behaviour changes. --- src/libvirt-domain.c | 122 +++++++++++++++++++++------------------------------ 1 file changed, 50 insertions(+), 72 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 4d4142d..baab307

...gt; attribute of E<lt>blockio/E<gt> +tag in libvirt XML will be passed as C<blocksize> parameter to +C<guestfs_add_drive_opts>. + The other optional parameters are passed directly through to C<guestfs_add_drive_opts>." }; @@ -597,6 +611,10 @@ The optional C<readonlydisk> parameter controls what we do for disks which are marked E<lt>readonly/E<gt> in the libvirt XML. See C<guestfs_add_domain> for possible values. +If present, the value of C<logical_block_size> attribute of E<lt>blockio/E<gt> +tag in libvirt XML will be pas...

On Thu, Dec 04, 2014 at 04:53:21PM +0800, cuimingwen@incito.com.cn wrote: > Hello， Richard， > I run command as example： " virt-df -d `virsh domuuid 5`" > some errors show : > libguestfs: warning: supermin-helper -f checksum returned a short string > libguestfs: error: cannot find any suitable libguestfs supermin, fixed or old-style appliance on

...gt; attribute of E<lt>blockio/E<gt> +tag in libvirt XML will be passed as C<blocksize> parameter to +C<guestfs_add_drive_opts>. + The other optional parameters are passed directly through to C<guestfs_add_drive_opts>." }; @@ -597,6 +623,10 @@ The optional C<readonlydisk> parameter controls what we do for disks which are marked E<lt>readonly/E<gt> in the libvirt XML. See C<guestfs_add_domain> for possible values. +If present, the value of C<logical_block_size> attribute of E<lt>blockio/E<gt> +tag in libvirt XML will be pas...

...+ diff_usage (EXIT_FAILURE); + } + } + + if (sdrv == NULL) + diff_usage (EXIT_FAILURE); + if (ddrv == NULL) + diff_usage (EXIT_FAILURE); + + struct guestfs_add_domain_argv optargs = { + .bitmask = 0, + .libvirturi = libvirt_uri, + .readonly = 1, + .allowuuid = 1, + .readonlydisk = "read", + }; + nr = guestfs_add_domain_argv (sg, sdrv->d.guest, &optargs); + if (nr == -1) + exit (EXIT_FAILURE); + sdrv->nr_drives = nr; + nr = guestfs_add_domain_argv (dg, ddrv->d.guest, &optargs); + if (nr == -1) + exit (EXIT_FAILURE); + ddrv->nr_driv...

...`virsh domuuid 5` libguestfs: trace: set_verbose true libguestfs: trace: set_verbose = 0 libguestfs: create: flags = 0, handle = 0x15ee130, program = virt-df libguestfs: trace: add_domain "572e2069-1d61-4e0a-9a7d-fc9e726c22cb" "readonly:true" "allowuuid:true" "readonlydisk:read" libguestfs: opening libvirt handle: URI = NULL, auth = virConnectAuthPtrDefault, flags = 1 libguestfs: successfully opened libvirt handle: conn = 0x15ee5c0 libguestfs: trace: internal_set_libvirt_selinux_norelabel_disks false libguestfs: trace: internal_set_libvirt_selinux_norelabel_...

...ernel(1) man page for further information.") + | Some _, Some _ -> + error (f_"you cannot give -a and -d options together. Read virt-get-kernel(1) man page for further information.") + | None, Some dom -> + fun (g : Guestfs.guestfs) -> + let readonlydisk = "ignore" (* ignore CDs, data drives *) in + ignore (g#add_domain + ~readonly:true ~allowuuid:true ~readonlydisk + ?libvirturi dom) + | Some uri, None -> + fun g -> + let { URI.path = path; protocol = protocol; +...