search for: readkeystrok

...may hang indefinitely when no keyboard is present on a machine (or when UEFI has chosen to not init USB due to fast boot). Reproducible at least with "EFI v2.31 by American Megatrends" on an Asrock H81M-ITX board. Reason is the input draining loop near the end in efi/main.c; it calls ReadKeyStroke() as long as EFI_NOT_READY is not returned. On machines without keyboard, EFI_DEVICE_ERROR may be returned instead, causing infinite looping. Positively checking for EFI_SUCCESS keeps the intent while avoiding this behavior. Patch is against 6.03; the issue is still present in 6.04 as per e46...

...fs_init(ops, (void *)&priv); + Print(L"fs_init done.\n"); /* * There may be pending user input that wasn't processed by @@ -1383,8 +1385,10 @@ EFI_STATUS efi_main(EFI_HANDLE image, EFI_SYSTEM_TABLE *table) status = uefi_call_wrapper(in->ReadKeyStroke, 2, in, &key); } while (status == EFI_SUCCESS); + Print(L"load_env32 start\n"); if (!setjmp(load_error_buf)) load_env32(NULL); + Print(L"load_env32 done.\n"); /* load_env32() failed.. cancel timer and bailout */...

...2015-02-18 19:48:27.215899105 -0700 @@ -1,4 +1,8 @@ /* + * EFI image boot capabilities by Patrick Masotta (Serva) (c)2015 + */ + +/* * Copyright 2011-2014 Intel Corporation - All Rights Reserved */ @@ -348,7 +352,11 @@ char efi_getchar(char *hi) do { status = uefi_call_wrapper(in->ReadKeyStroke, 2, in, &key); - } while (status == EFI_NOT_READY); + } while (status != EFI_NOT_READY); + + status = WaitForSingleEvent(in->WaitForKey, 0); + status = uefi_call_wrapper(in->ReadKeyStroke, 2, in, &key); + if (!key.ScanCode) return (char)key.UnicodeChar; @@ -356,1...

...oration - All Rights Reserved > */ I'm not a legal expert but I've more typically seen newer lines below the old lines and as a part of the same comment. > @@ -348,7 +352,11 @@ char efi_getchar(char *hi) > > do { > status = uefi_call_wrapper(in->ReadKeyStroke, 2, in, &key); > - } while (status == EFI_NOT_READY); > + } while (status != EFI_NOT_READY); > + > + status = WaitForSingleEvent(in->WaitForKey, 0); > + status = uefi_call_wrapper(in->ReadKeyStroke, 2, in, &key); > + > > if (!...

...keyboard is present on a > machine (or when UEFI has chosen to not init USB due to fast boot). > Reproducible at least with "EFI v2.31 by American Megatrends" on an > Asrock H81M-ITX board. > > Reason is the input draining loop near the end in efi/main.c; it calls > ReadKeyStroke() as long as EFI_NOT_READY is not returned. On machines > without keyboard, EFI_DEVICE_ERROR may be returned instead, causing > infinite looping. Positively checking for EFI_SUCCESS keeps the intent > while avoiding this behavior. > > Patch is against 6.03; the issue is still pr...

...v); > + Print(L"fs_init done.\n"); > > /* > * There may be pending user input that wasn't processed by > @@ -1383,8 +1385,10 @@ EFI_STATUS efi_main(EFI_HANDLE image, EFI_SYSTEM_TABLE *table) > status = uefi_call_wrapper(in->ReadKeyStroke, 2, in, &key); > } while (status == EFI_SUCCESS); > > + Print(L"load_env32 start\n"); > if (!setjmp(load_error_buf)) > load_env32(NULL); > + Print(L"load_env32 done.\n"); > > /* load_env32() fai...

...> + Print(L"fs_init done.\n"); > > /* > * There may be pending user input that wasn't processed by @@ - > 1383,8 +1385,10 @@ EFI_STATUS efi_main(EFI_HANDLE image, > EFI_SYSTEM_TABLE *table) > status = uefi_call_wrapper(in->ReadKeyStroke, 2, in, &key); > } while (status == EFI_SUCCESS); > > + Print(L"load_env32 start\n"); > if (!setjmp(load_error_buf)) > load_env32(NULL); > + Print(L"load_env32 done.\n"); > > /* load_env32() failed....

...hat we failed to execute correctly, which ????? * will trigger the next entry in the EFI Boot Manager list. ????? */ -??? longjmp(&load_error_buf, 1); +??? longjmp(load_error_buf, 1); ?} ?void bios_timer_cleanup(void) @@ -1382,7 +1383,7 @@ ??????????????? status = uefi_call_wrapper(in->ReadKeyStroke, 2, in, &key); ??????? } while (status == EFI_SUCCESS); -?????? if (!setjmp(&load_error_buf)) +?????? if (!setjmp(load_error_buf)) ??????????????? load_env32(NULL); ??????? /* load_env32() failed.. cancel timer and bailout */ I was able to test to make sure it works with a configur...

> On Wed, Oct 07, 2015 at 05:06:41PM -0500, Clements, James via Syslinux > wrote: > > > On Wed, Oct 07, 2015 at 06:01:30PM +0200, Geert Stappers via Syslinux > wrote: > > > is for BIOS, not for EFI. So that suggestion can be scraped. > > > > > > Which makes > > > * text which is on the screen of the netbooting (virtual) machine > > >

...ment\n"); + pressanykey(); + + return 0; +} + +#else + +char efi_getchar(char *hi) +{ + SIMPLE_INPUT_INTERFACE *in = ST->ConIn; + EFI_INPUT_KEY key; + EFI_STATUS status; + + + status = WaitForSingleEvent(in->WaitForKey, 0); // 0=> no timeout + status = uefi_call_wrapper(in->ReadKeyStroke, 2, in, &key); // get the char + + if (!key.ScanCode) + return (char)key.UnicodeChar; + + /* + * We currently only handle scan codes that fit in 8 bits. + */ + if(hi) + *hi = (char)key.ScanCode; + + return 0; + +} + +EFI_HANDLE image = NULL; +EFI_SYSTEM_TABLE* systab = NULL; + +int...

Package: src:xen Version: 4.14.1+11-gb0b734a8b3-1 Severity: critical Justification: causes serious data loss X-Debbugs-Cc: debianbts at virtualzone.hu Dear Maintainer, after a clean install of bullseye/testing the xen dmesg shows the following message: (XEN) AMD-Vi: IO_PAGE_FAULT: 0000:01:00.1 d0 addr fffffffdf8000000 flags 0x8 I this is the sata device: 01:00.1 SATA controller: Advanced Micro