search for: read_frame_

On Thu, Dec 11, 2014 at 11:12:25AM +0100, Martijn van Beurden wrote: > Op 11-12-14 om 10:53 schreef Martijn van Beurden: > > Op 11-12-14 om 10:05 schreef Miroslav Lichvar: > >> but I'd rather see the real seeking bug fixed instead > > > > I think I might have a fix [...] So the problem is that FLAC__stream_decoder_process_single returns error before it finds a

...s used for this test (hopefully ruling out any issue with the encoder). Details of the issue: When calling FLAC__stream_decoder_process_single() the error callback is triggered with the error FLAC__STREAM_DECODER_ERROR_STATUS_BAD_HEADER (the error callback is from line 1806 of stream_decoder.c in read_frame_). One thing I noticed is that FLAC__stream_decoder_process_single() still returns TRUE when our read callback returns FLAC__STREAM_DECODER_ABORTED (this was previously causing an endless loop in CRAM, since it didn't detect that an error had occurred). This behavior doesn't seem quite rig...

...e a fix [...] > > So the problem is that FLAC__stream_decoder_process_single returns > error before it finds a valid frame? > I'm not sure whether we mean the same thing, but I think the problem is that seek_to_absolute_sample_ calls FLAC__stream_decoder_process_single, which calls read_frame_, which calls read_subframe_, which calls either read_subframe_fixed_ or read_subframe_lpc_, which call read_residual_partitioned_rice_. The return false set there is propagated all the way down. So, because the decoding of the frame is aborted upon finding a situation in which a heap overflow migh...

...ut any issue with > the encoder). > > Details of the issue: > > When calling FLAC__stream_decoder_process_single() the error callback is > triggered with the error FLAC__STREAM_DECODER_ERROR_STATUS_BAD_HEADER > (the error callback is from line 1806 of stream_decoder.c in > read_frame_). One thing I noticed is that > FLAC__stream_decoder_process_single() still returns TRUE when our read > callback returns FLAC__STREAM_DECODER_ABORTED (this was previously > causing an endless loop in CRAM, since it didn't detect that an error > had occurred). This behavior doesn&...

...e_fixed_ (decoder=0x805ba58, channel=1, bps=16, order=3) at stream_decoder.c:1832 subframe = (FLAC__Subframe_Fixed *) 0x805f988 i32 = -31667 u32 = 14 u = 14 #3 0x4021ecd7 in read_subframe_ (decoder=0x805ba58, channel=1, bps=1) at stream_decoder.c:1751 x = 22 wasted_bits = 0 #4 0x4021e190 in read_frame_ (decoder=0x805ba58, got_a_frame=0xbffff360) at stream_decoder.c:1353 bps = 4294966980 channel = 1 i = 4294966980 mid = 1 side = 4608 left = 8 frame_crc = 4608 x = 248 #5 0x4021c6e0 in FLAC__stream_decoder_process_single (decoder=0x805ba58) at stream_decoder.c:596 got_a_frame = 0 #6 0x080...

...; > > Details of the issue: > > > > When calling FLAC__stream_decoder_process_single() the error > callback is > > triggered with the error > FLAC__STREAM_DECODER_ERROR_STATUS_BAD_HEADER > > (the error callback is from line 1806 of stream_decoder.c in > > read_frame_). One thing I noticed is that > > FLAC__stream_decoder_process_single() still returns TRUE when our > read > > callback returns FLAC__STREAM_DECODER_ABORTED (this was previously > > causing an endless loop in CRAM, since it didn't detect that an > error > > had oc...

...= mid - side; + *(lchan++) = left >> 1; + *(rchan++) = right >> 1; + } + break; + default: + FLAC__ASSERT(0); + break; + } +} + FLAC__bool allocate_output_(FLAC__StreamDecoder *decoder, unsigned size, unsigned channels) { unsigned i; @@ -1380,8 +1418,6 @@ FLAC__bool read_frame_(FLAC__StreamDecoder *decoder, FLAC__bool *got_a_frame, FLAC__bool do_full_decode) { unsigned channel; - unsigned i; - FLAC__int32 mid, side, left, right; FLAC__uint16 frame_crc; /* the one we calculate from the input stream */ FLAC__uint32 x; @@ -1446,41 +1482,9 @@ if(!FLAC__bitbuffer_re...