search for: read_batch_csum_info

I needed a tool to produce diffs of binary volumes, and to apply them as patches accordingly. So I tried the 'batch mode' that was added to rsync, but it invariably segfaulted on reading the batches... $ sh foo.rsync_argvs foo.rsync_argvs: line 1: 8971 Segmentation fault rsync -a -v --stats --read-batch=foo ${1:-FOO} rsync: error writing 64 unbuffered bytes - exiting: Broken pipe

> Just curious: what about the rsync+ patch? Thanks for the reminder. I've just committed Jos's rsync+ patch onto the "branch_mbp_rsyncplus_merge" branch. If it works OK and nobody screams I will move it across onto the main tree tomorrow or Wednesday. I see the patch doesn't add documentation about the new options to the man page, so we should fix that in the future.

...util.c:1000 #99 0x080514c1 in show_malloc_stats () at main.c:194 #100 0x08062628 in write_batch_flist_info (flist_count=3, files=0x3) at batch.c:43 #101 0x08062d35 in write_batch_csum_info (flist_entry=0x3, s=0x3) at batch.c:202 #102 0x0805d2be in read_longint (f=873) at io.c:710 #103 0x08062f73 in read_batch_csum_info (flist_entry=0, s=0x0, checksums_match=0x1) at batch.c:256 #104 0x0805219b in do_server_recv (f_in=0, f_out=0, argc=1501700484, argv=0x2a2514bc) at main.c:518 #105 0x2a287cf9 in ?? () #106 0x00000000 in ?? () #107 0x00000000 in ?? () #108 0x59822184 in ?? () #109 0x2a2514bc in ?? () #110 0x00000003...

...close(fdb); exit_cleanup(1); } @@ -450,14 +447,14 @@ if (bytes_read == -1) { rprintf(FERROR, "Batch file %s read error: %s\n", - rsync_csums_file, strerror(errno)); + filename, strerror(errno)); close(fdb); exit_cleanup(1); } + return bytes_read; } - void read_batch_csum_info(int flist_entry, struct sum_struct *s, int *checksums_match) { @@ -468,11 +465,9 @@ char file_sum2[SUM_LENGTH]; extern int csum_length; - read_batch_csums_file((char *) &file_flist_entry, sizeof(int)); if (file_flist_entry != flist_entry) { - rprintf(FINFO, "file_list_ent...