Displaying 3 results from an estimated 3 matches for "re_valid_id".
2017 Nov 14
1
Re: [PATCH v12 3/3] New tool: virt-builder-repository
...e will flush stdout anyway.
> + if not (Str.string_match (Str.regexp "[a-zA-Z0-9-_.]+") id 0) then (
It's not wrong to use Str, but you might want to use PCRE instead (see
common/mlpcre) since Perl regexps are more familiar for most people.
This could be written as:
let re_valid_id = PCRE.compile ~anchored:true "[-a-zA-Z0-9_.]+"
...
if not (PCRE.matches re_valid_id id) then (
etc.
Note that Str regexps are anchored by default but PCRE regexps are not.
> + warning (f_"Allowed characters are letters, digits, - _ and .");
> +...
2017 Nov 21
5
[PATCH v13 0/3] virt-builder-repository
Hey there,
Here is an update of the series. The changes:
* Incorporate Richard's comments. Left out the with_openfile one
since that leads to a double close.
* Change the ask option return type to string (removing the option)
since if the use doesn't input anything we're using the default,
and the default is now a mandatory parameter.
* Make sure there are items in the
2017 Nov 13
6
[PATCH v12 0/3] virt-builder-repository tool
Hi there!
Here is the latest version of the series including Richard's comments.
I also reworked the repository_main.ml code to avoid setting an
empty entry if not found.
Cédric Bosdonnat (3):
builder: change arch type to distinguish guesses
builder: add a template parameter to get_index
New tool: virt-builder-repository
.gitignore | 4 +