search for: raw_bit

Hi, Just to let you know that I've added a "raw_bits" branch in git. It's still a bit experimental, but the idea is to do a direct encoding of all the bits that are written explicitly. This bypasses the range coder when possible and just writes the bits at the end of the stream. There's an overhead of about one bit, but it should save a...

...r, max_partition_order); precompute_partition_info_sums_(residual, abs_residual_partition_sums, residual_samples, predictor_order, min_partition_order, max_partition_order, bps); @@ -3735,7 +3726,7 @@ unsigned find_best_partition_order_( unsigned partition; /* save best parameters and raw_bits */ - FLAC__format_entropy_coding_method_partitioned_rice_contents_ensure_size(prc, max(6, best_partition_order)); + FLAC__format_entropy_coding_method_partitioned_rice_contents_ensure_size(prc, flac_max(6u, best_partition_order)); memcpy(prc->parameters, private_->partitioned_rice_conte...

I changed just the FLAC__EntropyCodingMethod_PartitionedRice struct, but it hasn't changed a thing. I'm still getting the same behaviour. typedef struct { unsigned order; unsigned parameters[1 << 6]; unsigned raw_bits[1 << 6]; } FLAC__EntropyCodingMethod_PartitionedRice; Any other thoughts? Thanks, Reza Josh Coalson wrote: > --- Reza Naima <reza@reza.net> wrote: > >>Thanks for that email. The one lihe change I made is this : >> >>from #define FLAC__MAX_RICE_PARTITION_O...

...:254 #5 0x8061153 in FLAC__bitbuffer_write_rice_signed (bb=0x4085c800, val=-2147483630, parameter=4) at bitbuffer.c:658 #6 0x8056603 in subframe_add_residual_partitioned_rice_ (bb=0x4085c800, residual=0x8361200, residual_samples=4580, predictor_order=28, rice_parameters=0x407dc520, raw_bits=0x407fc520, partition_order=0) at encoder_framing.c:366 #7 0x80563eb in FLAC__subframe_add_lpc (subframe=0x407dc518, residual_samples=4580, subframe_bps=17, wasted_bits=0, bb=0x4085c800) at encoder_framing.c:310 #8 0x80544c8 in encoder_add_subframe_ (encoder=0x8314758, frame_he...

Thanks for that email. The one lihe change I made is this : from #define FLAC__MAX_RICE_PARTITION_ORDER (15u) to #define FLAC__MAX_RICE_PARTITION_ORDER (6u) and that seemed to make decoder_new() happy, but it's promptly crashing after making a call to the read callback (below), then to the meta callback. The meta callback did nothing but print a string and return. I removed it, and

> > I also had this verify error encoding a wav I ripped from a CD. I > didn't > > report this as it happended on flac running on debian linux > -current unstable. > > This error happened only with one track of a CD I was ripping. > > > > Another reason for me not reporting this was, that flac 1.0 running > on OpenBSD > > 2.9 encoded the wav with