search for: ratelimit_calculate_delay

Displaying 3 results from an estimated 3 matches for "ratelimit_calculate_delay".

2014 Feb 24
2
Re: [Qemu-devel] Adjust disk image migration (NBD)
On Fri, Feb 14, 2014 at 11:58:56AM +0100, Michal Privoznik wrote: > On 14.02.2014 10:40, Joaquim Barrera wrote: > > Hi all, > > > > As I am doing some tests with qemu, I realized that the way it does > > 'migrate -i tcp:DEST:444' is not the same as 'libvirt migrate > > --copy-storage-inc'. Basically qemu uses the same stream as RAM > >
2014 Feb 24
0
Re: [Qemu-devel] Adjust disk image migration (NBD)
...the guest? > The main > copy loop does take the speed limit into account but perhaps that's > broken too. Yeah, it looks broken. Each iteration of the loop can write much more than sectors_per_chunk sectors, but here: if (s->common.speed) { delay_ns = ratelimit_calculate_delay(&s->limit, sectors_per_chunk); } else { delay_ns = 0; } the second argument is fixed. :/ Paolo
2014 Feb 28
2
Re: [Qemu-devel] Adjust disk image migration (NBD)
...; copy loop does take the speed limit into account but perhaps that's >> broken too. > Yeah, it looks broken. Each iteration of the loop can write much more > than sectors_per_chunk sectors, but here: > > if (s->common.speed) { > delay_ns = ratelimit_calculate_delay(&s->limit, sectors_per_chunk); > } else { > delay_ns = 0; > } > > the second argument is fixed. :/ > > Paolo > Thanks for the answer. Something is still not clear to me. Are we in front of a bug (that means, something that...