Displaying 2 results from an estimated 2 matches for "rargvt".
Did you mean:
largvt
2013 Oct 03
2
[LLVMdev] Question about DAGCombiner::MatchRotate function
...ecific type(LHS's type) through
"TLI.isOperationLegalOrCustom" function. I guess the reason is following
"LegalizeType" can not promote "ROTL" and "ROTR".
The problem is that code does not check this with new specific type
"LArgVT" and "RArgVT" while processing above patterns. How do you think
about this? I think checking code is needed. I have attached simple
patch to fix it. Please review this.
Thanks,
JinGu Kang
-------------- next part --------------
Index: lib/CodeGen/SelectionDAG/DAGCombiner.cpp
============================...
2013 Oct 03
0
[LLVMdev] Question about DAGCombiner::MatchRotate function
Hi JinGu,
It's normally best to send patches to the llvm-commits list. That's
where most of the reviews happen.
> The problem is that code does not check this with new specific type "LArgVT"
> and "RArgVT" while processing above patterns. How do you think about this? I
> think checking code is needed.
I agree.
> I have attached simple patch to fix it. Please review this.
Which target does this affect (that you know of)? It would be really
good to have a test (like the other .ll files i...