search for: r_legacy_rcomplex

...be helpful here. You can see that bindgen is already generating a placeholder name ("__bindgen_anon_1"). A meaningful name might be nice instead, but I get the impression that isn't an option here since that would break the C API. Can I ask, would it make sense for us to hard code in R_LEGACY_RCOMPLEX so that Rust can just ignore the union? Because as I understand the only compiler that actually needs to "see" the union is gfortran, and if we pretend it's still a struct in Rust everything should work as before, no? Is this guaranteed to be a stable macro? On Tue, Apr 4, 2023 at 5:...

...eviously it was a struct, but now it's a union by default <https://github.com/r-devel/r-svn/commit/862f9f816ff3ff3cb3f851603f19e99f60a98475#diff-e9b09a44d9dc69444eca2300325e790a0cc6d2c8c3960f47519c7f8ef896f9e4>, which breaks downstream code that relied on this layout. I'm aware of the R_LEGACY_RCOMPLEX variable, but I still wouldn't expect an unreported breaking change especially if it's aimed at R 4.3 (although I'm not sure if it is). I believe src/include/R_ext/Complex.h, which this patch affects, is considered part of the public R ABI since it's included by R.h. What should I,...

...ruct, > but now it's a union by default > <https://github.com/r-devel/r-svn/commit/862f9f816ff3ff3cb3f851603f19e99f60a98475#diff-e9b09a44d9dc69444eca2300325e790a0cc6d2c8c3960f47519c7f8ef896f9e4>, > which breaks downstream code that relied on this layout. I'm aware of > the R_LEGACY_RCOMPLEX variable, but I still wouldn't expect an unreported > breaking change especially if it's aimed at R 4.3 (although I'm not sure if > it is). I believe src/include/R_ext/Complex.h, which this patch affects, is > considered part of the public R ABI since it's included by R.h....

...t > > > <https://github.com/r-devel/r-svn/commit/862f9f816ff3ff3cb3f851603f19e99f60a98475#diff-e9b09a44d9dc69444eca2300325e790a0cc6d2c8c3960f47519c7f8ef896f9e4>, > > which breaks downstream code that relied on this layout. I'm > aware of > > the R_LEGACY_RCOMPLEX variable, but I still wouldn't expect an > unreported > > breaking change especially if it's aimed at R 4.3 (although I'm > not sure if > > it is). I believe src/include/R_ext/Complex.h, which this patch > affects, is > > considered par...

On Tue, 4 Apr 2023 09:31:33 +0200 Tomas Kalibera <tomas.kalibera at gmail.com> wrote: > it also matters how Rust can handle anonymous nested structures, or > what is the right mapping of the involved C types to Rust It's worth mentioning that Rust's RFC 2102 [1] defines unnamed structs and unions for the purpose of C interoperability, but it's not yet implemented. Would

...>> > < >> https://github.com/r-devel/r-svn/commit/862f9f816ff3ff3cb3f851603f19e99f60a98475#diff-e9b09a44d9dc69444eca2300325e790a0cc6d2c8c3960f47519c7f8ef896f9e4 >> >, >> > which breaks downstream code that relied on this layout. I'm aware of >> > the R_LEGACY_RCOMPLEX variable, but I still wouldn't expect an >> unreported >> > breaking change especially if it's aimed at R 4.3 (although I'm not >> sure if >> > it is). I believe src/include/R_ext/Complex.h, which this patch >> affects, is >> > considered par...

...<https://github.com/r-devel/r-svn/commit/862f9f816ff3ff3cb3f851603f19e99f60a98475#diff-e9b09a44d9dc69444eca2300325e790a0cc6d2c8c3960f47519c7f8ef896f9e4>, >> > which breaks downstream code that relied on this layout. >> I'm aware of >> > the R_LEGACY_RCOMPLEX variable, but I still wouldn't expect >> an unreported >> > breaking change especially if it's aimed at R 4.3 (although >> I'm not sure if >> > it is). I believe src/include/R_ext/Complex.h, which this >> patch...