Displaying 3 results from an estimated 3 matches for "r279417".
2016 Aug 26
2
Use of array type in globals in LTO
...just make
> + // sure the alignment is correct.
>
> We compare the existing type to an ArrayType constructed from the
> recorded merged common size. So
> the original i32 type does not look the same (since it compares
> against [4 x i8]).
Right, but that the code I wrote in r279417 right? I guess we should compare the *size* first, and only do something if the size differs.
How was Gold doing it before r278338?
—
Mehdi
>
> Not that familiar with type handling in LLVM, but I guess I need to
> just check if the type size is the same?
>
> On Fri, Aug 26,...
2016 Aug 26
2
Use of array type in globals in LTO
...;> int GVi32_b ;
>
> These are common variables, this is what I mentioned in my first email. Compiling with -fno-commons or defining them with “int GVi32_a = 0;” should solve it.
>
> However r278338 is not supposed to have changed anything on this aspect. I would have expected maybe r279417 playing a role there.
>
> Anyway I don’t have Gold, so I’ll leave Teresa investigate why the change in behavior.
>
> Do you want to try improving global merge to try to handle this case?
>
> —
> Mehdi
>
>
>
>
>
>>
>> __attribute__((noinline)) void set...
2016 Aug 26
3
Use of array type in globals in LTO
On 2016-08-26 12:47, Mehdi Amini wrote:
>> On Aug 26, 2016, at 9:06 AM, junbuml at codeaurora.org wrote:
>>
>> On 2016-08-26 11:32, Mehdi Amini wrote:
>>> Hi,
>>>> Recently, I noticed that less number of global variables are merged
>>>> in global-merge pass and in some global variable, array types are
>>>> used instead of its