search for: r270454

...urns void. Out of tree targets will need to be updated to replace the argument node and remove any dead nodes in cases where they currently return an SDNode * from this interface. http://llvm.org/docs/ReleaseNotes.html You can look at the changes to the various in-tree targets between r268693 and r270454 (e.g., r269144 for x86). -Ahmed > > > MartinO > > > > From: Martin J. O'Riordan [mailto:martin.oriordan at movidius.com] > Sent: 28 June 2016 16:49 > To: 'LLVM Developers' <llvm-dev at lists.llvm.org> > Subject: Question about changes to...

It occurred to me that instead of the various breakout 'Select*' functions returning the 'SDNode*' result, maybe I should be calling: ReplaceNode(N, newValue); return; or: SelectCode(N); return; Perhaps? MartinO From: Martin J. O'Riordan [mailto:martin.oriordan at movidius.com] Sent: 28 June 2016 16:49 To: 'LLVM Developers'

...urns void. Out of tree targets will need to be updated to replace the argument node and remove any dead nodes in cases where they currently return an SDNode * from this interface. http://llvm.org/docs/ReleaseNotes.html You can look at the changes to the various in-tree targets between r268693 and r270454 (e.g., r269144 for x86). -Ahmed > > > MartinO > > > > From: Martin J. O'Riordan [mailto:martin.oriordan at movidius.com] > Sent: 28 June 2016 16:49 > To: 'LLVM Developers' <llvm-dev at lists.llvm.org> > Subject: Question about changes to...

...targets will need to be updated to replace the argument node and remove any dead nodes in cases where they currently return an SDNode * from this interface. > > http://llvm.org/docs/ReleaseNotes.html > > You can look at the changes to the various in-tree targets between > r268693 and r270454 (e.g., r269144 for x86). > > -Ahmed > >> >> >> MartinO >> >> >> >> From: Martin J. O'Riordan [mailto:martin.oriordan at movidius.com] >> Sent: 28 June 2016 16:49 >> To: 'LLVM Developers' <llvm-dev at lists.llv...

...rst place :) > Thanks, > Hans > > On Sat, May 21, 2016 at 10:57 AM, Justin Bogner via llvm-dev > <llvm-dev at lists.llvm.org> wrote: >> Update: All in tree backends now implement `void Select`. I'll be >> removing the SelectImpl path on Monday. This is done in r270454. >> Justin Bogner <mail at justinbogner.com> writes: >>> TLDR: Heads up for out of tree backends - you're going to need to update >>> your *DAGToDAGISel::Select method to unconditionally replace nodes >>> directly instead of returning the desired replacem...

Can you put something in the release notes when this happens? Thanks, Hans On Sat, May 21, 2016 at 10:57 AM, Justin Bogner via llvm-dev <llvm-dev at lists.llvm.org> wrote: > Update: All in tree backends now implement `void Select`. I'll be > removing the SelectImpl path on Monday. > > Justin Bogner <mail at justinbogner.com> writes: >> TLDR: Heads up for out of