search for: r266477

Hi, After r256521 - which removes InlineCostAnalysis class - I think there is no strong reason for InlineCost.cpp to be part of the Analysis library. Is it fine to make it part of TransformUtils? I submitted r266477 (which has now been reverted) that made Analysis depend on ProfileData in order to obtain ProfileSummary for the module, but there is an existing dependency of ProfileData on Analysis (through Object and BitCode). Moving InlineCost.cpp under Transforms/Utils will fix this issue. There are other way...

...to be part of the >> Analysis library. Is it fine to make it part of TransformUtils? >> > > Given that InlineCost is not really an analysis any longer, I think this is fine. Isn't it? It is not a pass, but I see it as an analysis utils. > >> >> I submitted r266477 (which has now been reverted) that made Analysis >> depend on ProfileData in order to obtain ProfileSummary for the >> module, but there is an existing dependency of ProfileData on >> Analysis (through Object and BitCode). The real issue is that BitCode depends on Analysis I thin...

...Utils? >> >> >> > >> > Given that InlineCost is not really an analysis any longer, I think >> this is fine. >> >> Isn't it? It is not a pass, but I see it as an analysis utils. >> >> > >> >> >> >> I submitted r266477 (which has now been reverted) that made Analysis >> >> depend on ProfileData in order to obtain ProfileSummary for the >> >> module, but there is an existing dependency of ProfileData on >> >> Analysis (through Object and BitCode). >> >> The real issu...

...; > >>> > Given that InlineCost is not really an analysis any longer, I think >>> this is fine. >>> >>> Isn't it? It is not a pass, but I see it as an analysis utils. >>> >>> > >>> >> >>> >> I submitted r266477 (which has now been reverted) that made Analysis >>> >> depend on ProfileData in order to obtain ProfileSummary for the >>> >> module, but there is an existing dependency of ProfileData on >>> >> Analysis (through Object and BitCode). >>> >&g...

...> > > > > > > Isn't it? It is not a pass, but I see it as an analysis utils. > > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > >> I submitted r266477 (which has now been reverted) that made > > > > >> Analysis > > > > > > > > > > >> depend on ProfileData in order to obtain ProfileSummary for > > > > >> the > > > > > > > > > > >> modu...