search for: r242281

...s.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] On Behalf Of Chandler Carruth Sent: 15 July 2015 10:45 To: Chandler Carruth; Gerolf Hoflehner Cc: LLVM Developers Mailing List Subject: Re: [LLVMdev] GlobalsModRef (and thus LTO) is completely broken I've fixed the obvious bugs I spotted in r242281. These should be pure correctness improvements. I've sent the two patches I'm imagining to address the core issue here: http://reviews.llvm.org/D11213 <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11213&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn...

Replying here, but several of the questions raised boil down to "couldn't you make the usage of GetUnderlyingObject conservatively correct?". I'll try and address that. I think this *is* the right approach, but I think it is very hard to do without effectively disabling this part of GlobalsModRef. That is, the easy ways are likely to fire very frequently IMO. The core idea is

...ehalf Of *Chandler Carruth > > > *Sent:* 15 July 2015 10:45 > *To:* Chandler Carruth; Gerolf Hoflehner > *Cc:* LLVM Developers Mailing List > *Subject:* Re: [LLVMdev] GlobalsModRef (and thus LTO) is completely broken > > > > I've fixed the obvious bugs I spotted in r242281. These should be pure > correctness improvements. > > > > I've sent the two patches I'm imagining to address the core issue here: > > http://reviews.llvm.org/D11213 > <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11213&d=AwMFaQ&c=8...

...ehalf Of *Chandler Carruth > > > *Sent:* 15 July 2015 10:45 > *To:* Chandler Carruth; Gerolf Hoflehner > *Cc:* LLVM Developers Mailing List > *Subject:* Re: [LLVMdev] GlobalsModRef (and thus LTO) is completely broken > > > > I've fixed the obvious bugs I spotted in r242281. These should be pure > correctness improvements. > > > > I've sent the two patches I'm imagining to address the core issue here: > > http://reviews.llvm.org/D11213 > <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11213&d=AwMFaQ&c=8...

...ehalf Of *Chandler Carruth > > > *Sent:* 15 July 2015 10:45 > *To:* Chandler Carruth; Gerolf Hoflehner > *Cc:* LLVM Developers Mailing List > *Subject:* Re: [LLVMdev] GlobalsModRef (and thus LTO) is completely broken > > > > I've fixed the obvious bugs I spotted in r242281. These should be pure > correctness improvements. > > > > I've sent the two patches I'm imagining to address the core issue here: > > http://reviews.llvm.org/D11213 > <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11213&d=AwMFaQ&c=8...

...ehalf Of *Chandler Carruth > > > *Sent:* 15 July 2015 10:45 > *To:* Chandler Carruth; Gerolf Hoflehner > *Cc:* LLVM Developers Mailing List > *Subject:* Re: [LLVMdev] GlobalsModRef (and thus LTO) is completely broken > > > > I've fixed the obvious bugs I spotted in r242281. These should be pure > correctness improvements. > > > > I've sent the two patches I'm imagining to address the core issue here: > > http://reviews.llvm.org/D11213 > <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11213&d=AwMFaQ&c=8...

...gt; >> >> Sent: 15 July 2015 10:45 >> To: Chandler Carruth; Gerolf Hoflehner >> Cc: LLVM Developers Mailing List >> Subject: Re: [LLVMdev] GlobalsModRef (and thus LTO) is completely broken >> >> >> >> I've fixed the obvious bugs I spotted in r242281. These should be pure >> correctness improvements. >> >> >> >> I've sent the two patches I'm imagining to address the core issue here: >> >> http://reviews.llvm.org/D11213 >> >> http://reviews.llvm.org/D11214 >> >> >> &...