Displaying 2 results from an estimated 2 matches for "r23915".
Did you mean:
r253915
2020 Nov 10
1
unusual use of getenv
...t a thing.
I concluded this was a windows thing because the origin of the code
seems to be in 00d5508496c1ec0540da5714b0ed66e64b623df5 which uses the
windows only `GetCurrentProcess` instead of `getenv`. Chris Lattner then
changed it to use `getenv` in 63e504ff437d88f0d4bdb0cd50b045655dea6ab1
(svn r23915).
00d550849 is svn r19307 and predates 1c5b428ff823 by ~9 months. The
"new header" patch you identified as the origin of this code seems to be a copy
of the original. Reid Spencer then consolidated the two in the subsequent patch
a3223665010b9a.
That's as far as my archaeology went o...
2020 Nov 02
4
unusual use of getenv
Oh, right, this stuff. I guess the non-windows solution might've been a
volatile read, for instance? So maybe not so much that the general
machinery isn't needed, but that perhaps MSVC does something interesting
with a volatile read or whatever other solution might've been used.
Hmm, not sure why the whole file was added only when MSVC support was added
- if it is a "static