search for: r194356

2013/11/10 Alp Toker <alp at nuanti.com>: > #ifndef NDEBUG > > This is the biggest violation. NDEBUG should only ever be used in source > files. That way if something is crashing we can swap in a debug build > without rebuilding every single dependent application. Win! I wish; - NDEBUG may not modify API. class structure (member offset, vtables) should be stable and

...() / NDEBUG (I think a few uses might have been incorrectly changed, will check over), as do the C++ sources and non-public headers. llvm_assert() is a bit more verbose but it actually fits into the coding style well, and it's grown on me. Extract from README.txt: |This patchset against LLVM r194356 implements API stability.|| || ||Embedding is now fully independent of build configuration, with the exception of C++11 feature checks in Compiler.h which still need to be autoconf'ed.|| || ||External applications should include llvm-config.h. || || ||Only supported with the CMake build system,...

With the recent thread on using C++11 in LLVM/clang, one of the recurring themes was a desire to make the internal headers more consumable. While I don't personally want any kind of stability guarantee for internal headers, I do think we can do more to ensure that any given snapshot of the headers is consumable from different compilers and build configurations. In practice this means