Displaying 5 results from an estimated 5 matches for "r194071".
Did you mean:
r194073
2013 Dec 08
5
[LLVMdev] lit: deprecating trailing \ in RUN lines
...d like to understand the rate at which this happens (per RUN-line?
> per test-file?). It's never been a problem for me, but that is in part
> because I check that my tests fail without my change in addition to
> passing with my change.
If only everyone did check their changes.
See r194071 where trailing backslash caused a test to always succeed,
and r194073 for the kind of long-term a broken test has on code quality.
Looking at the SVN log for test/ in clang, and to a lesser extent LLVM
core, I've been doing nearly all the no-op test fixes in the last few
months. Not all of...
2013 Dec 08
0
[LLVMdev] lit: deprecating trailing \ in RUN lines
...the rate at which this happens (per RUN-line?
> per test-file?). It's never been a problem for me, but that is in part
> because I check that my tests fail without my change in addition to passing
> with my change.
>
>
> If only everyone did check their changes.
>
> See r194071 where trailing backslash caused a test to always succeed, and
> r194073 for the kind of long-term a broken test has on code quality.
>
> Looking at the SVN log for test/ in clang, and to a lesser extent LLVM
> core, I've been doing nearly all the no-op test fixes in the last few
>...
2013 Dec 10
0
[LLVMdev] lit: deprecating trailing \ in RUN lines
...ike to understand the rate at which this happens (per RUN-line? per test-file?). It's never been a problem for me, but that is in part because I check that my tests fail without my change in addition to passing with my change.
>
> If only everyone did check their changes.
>
> See r194071 where trailing backslash caused a test to always succeed, and r194073 for the kind of long-term a broken test has on code quality.
>
> Looking at the SVN log for test/ in clang, and to a lesser extent LLVM core, I've been doing nearly all the no-op test fixes in the last few months. Not...
2013 Dec 08
0
[LLVMdev] lit: deprecating trailing \ in RUN lines
On Sun, Dec 8, 2013 at 2:11 AM, Alp Toker <alp at nuanti.com> wrote:
> I'd like to propose deprecating and shortly thereafter removing the lit
> test runner feature that concatenates RUN lines ending in a trailing \
>
I'm really opposed to this. Especially for the Clang test suite where run
lines are often *very* long and hard to organize, read, and edit without
this
2013 Dec 08
2
[LLVMdev] lit: deprecating trailing \ in RUN lines
I'd like to propose deprecating and shortly thereafter removing the lit
test runner feature that concatenates RUN lines ending in a trailing \
*Rationale:**
*
* Trailing \ has a special meaning in various language standards that
we support nowadays. In the C preprocessor, for example, it's
handled _before_ comments. Various compilers handle this differently
and it