Displaying 2 results from an estimated 2 matches for "r175788".
Did you mean:
r175088
2013 Feb 19
2
[LLVMdev] eliminateCallFramePseudoInstr belongs in TargetRegisterInfo or TargetFrameLowering
Hi all,
I ran into this while trying to figure out why the X86
getSUBriOpcode/getADDriOpcode functions are duplicated, appearing once
in X86RegisterInfo.cpp and once in X86FrameLowering.cpp,
The method TargetRegisterInfo::eliminateCallFramePseudoInstr doesn't
appear to really belong in this interface. It adds instructions into
the MachineFunction given to it, which isn't what
2013 Feb 19
0
[LLVMdev] eliminateCallFramePseudoInstr belongs in TargetRegisterInfo or TargetFrameLowering
> ISTM that eliminateCallFramePseudoInstr belongs in
> TargerFrameLowering, since it's being used during prolog/epilog
> insertion. Moving it there would avoid the code duplication and
> possibly other layering problems.
> What do you think
Go ahead and move. It's s historical artifact why it is inside TRI.
--
With best regards, Anton Korobeynikov
Faculty of Mathematics