Displaying 3 results from an estimated 3 matches for "r148206".
Did you mean:
148206
2012 Jan 14
0
[LLVMdev] Unreachable code in Mutex.cpp
On Jan 13, 2012, at 11:17 PM, David Blaikie wrote:
>> On some (linux?) implementations, various pthread APIs are defined as "weak extern" symbols in libc and strong definitions in libpthreads. The idea of this check is thus to detect if pthreads is linked into the app and enable threads if so.
>
> Sorry, right - I should've been more clear. I understand that that's
2012 Jan 15
1
[LLVMdev] Unreachable code in Mutex.cpp
...e just
>> remove the variable & all the conditions (unconditionally using
>> pthreads), or reinstate the smarts it used to have (testing the weak
>> symbol)?
>
> Aha, I'm completely fine with constant folding this all away. Simple is good.
Sounds good. Committed as r148206 (including a similar fix in
RWMutex.cpp - which propagated the same quirk when it was
copy/pasted/created from Mutex.cpp)
I've attached a patch containing some other fixes to remove
unreachable code in LLVM - this isn't comprehensive, but a start based
on -Wunreachable-code. Is this sort o...
2012 Jan 14
2
[LLVMdev] Unreachable code in Mutex.cpp
On Fri, Jan 13, 2012 at 10:24 PM, Chris Lattner <clattner at apple.com> wrote:
>
> On Jan 13, 2012, at 4:43 PM, David Blaikie wrote:
>
>> It looks like for a while now (5 years) some code that was meant to do
>> smart things in Mutex.cpp hasn't been doing such smart things:
>>
>>