Displaying 1 result from an estimated 1 matches for "quoted_tables".
2011 May 05
9
[threadsafe] Arel ToSql visitor is not threadsafe
...ng:
Arel::Visitors::ENGINE_VISITORS is a cache of visitors instances.
These instances are not inherently threadsafe because it contains
state ''@last_column'', ''@connection'' that is shared between threads.
The other variables ''@pool'', ''@quoted_tables'' and ''@quoted_columns''
seem just fine. I''d like to propose a patch
(https://github.com/ketan/arel/commit/52dc69f5bebebb75b7b3d7bd42e839f2db54b88a)
that fixes this using ruby''s threadlocal for the last_column and
connection instance variables. Would be gr...