search for: quota_set_error

Hello. After using Dovecot for over a year, I have just started experimenting with the filesystem quotas, and I have a suggestion for improvement. On my mail server, I use group-based quotas, and would like to have Dovecot be able to report these quotas. It should be simple to implement, requiring only changes to the quota-fs.c file of the quota plugin. Simply changing USRQUOTA to

...0) { + /* XFS */ + struct fs_disk_quota xdqblk; - if (quotactl(QCMD(Q_XGETQUOTA, USRQUOTA), - root->mount->device_path, - root->uid, (caddr_t)&xdqblk) < 0) { - i_error("quotactl(Q_XGETQUOTA, %s) failed: %m", - root->mount->device_path); - quota_set_error(_root->setup->quota, - "Internal quota error"); - return -1; - } + if (quotactl(QCMD(Q_XGETQUOTA, args[i]), + root->mount->device_path, + what[i], (caddr_t)&xdqblk) < 0) { + quota_error = quota_error + 1; + } - /* values always returned...

...is nearly full anyway). The attached patch fixes it for me, and I suspect is also correct for others BSDs. I don't know for AIX. --- src/plugins/quota/quota-fs.c.orig 2007-01-28 22:35:32.000000000 +0100 +++ src/plugins/quota/quota-fs.c 2007-01-28 22:36:12.000000000 +0100 @@ -250,8 +250,8 @@ quota_set_error(_root->setup->quota, "Internal quota error"); return -1; } - *value_r = (uint64_t)dqblk.dqb_curblocks * 1024 / DEV_BSIZE; - *limit_r = (uint64_t)dqblk.dqb_bsoftlimit * 1024 / DEV_BSIZE; + *value_r = (uint64_t)dqblk.dqb_curblocks * DEV_BSIZE / 1024; + *limit_r = (uint64_t)dqblk....