search for: quota_global

Signed-off-by: Joe Perches <joe at perches.com> --- fs/ocfs2/quota_global.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c index edfa60c..05ed815 100644 --- a/fs/ocfs2/quota_global.c +++ b/fs/ocfs2/quota_global.c @@ -143,7 +143,7 @@ static int ocfs2_get_quota_block(struct inode *inode, int block...

ocfs2_quota_write needs to release the lock if it fails to read quota block. So use "goto out" instead of "return err". Cc: Jan Kara <jack at suse.cz> Signed-off-by: Tao Ma <tao.ma at oracle.com> --- fs/ocfs2/quota_global.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c index edfa60c..e1c40e3 100644 --- a/fs/ocfs2/quota_global.c +++ b/fs/ocfs2/quota_global.c @@ -234,7 +234,7 @@ ssize_t ocfs2_quota_write(struct super_block *sb, int type, }...

Hi, here is the second version of OCFS2 quota fixes with Joel's comments fixed. Also I've added a patch defining counts of credits for quota operations as Joel asked. Honza

Hi, I did some more in-depth testing of OCFS2 quota code, especially with ECC feature enabled and spotted some problems. First four patches fix them. I need the fifth patch to be able to mount OCFS2 filesystem with 2.6.31-rc3. The sixth patch fixes a potential problem when quota syncing interval is updated while the cluster is running (which is not possible currently). Joel, could you please

Hi, All, When mount ocfs2 with option usrquota and grpquota, we will see below message: (mount.ocfs2,9434,1):ocfs2_global_read_info:403 ERROR: status = 24 (mount.ocfs2,9434,3):ocfs2_global_read_info:403 ERROR: status = 24 But actually this should not be a error. In ocfs2_global_read_info, if read_quota() succeed, status is the size of the struct ocfs2_global_disk_dqinfo, only when it is not

...an appropriate answer. Make ocfs2_read_quota_block() check the condition and handle it by calling ocfs2_error() and returning EIO. Reported-by: Tristan Ye <tristan.ye at oracle.com> Signed-off-by: Jan Kara <jack at suse.cz> --- Joel, could you please merge this fix? Thanks. fs/ocfs2/quota_global.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c index d604a6a..8988d8b 100644 --- a/fs/ocfs2/quota_global.c +++ b/fs/ocfs2/quota_global.c @@ -23,6 +23,7 @@ #include "sysfile.h" #include "dlmglue.h&...

This patch implements functions and timer setup which handles periodic syncing of locally cached quota information to global quota file. Signed-off-by: Jan Kara <jack at suse.cz> --- fs/ocfs2/quota.h | 3 ++ fs/ocfs2/quota_global.c | 66 +++++++++++++++++++++++++++++++++++++++++++++++ fs/ocfs2/quota_local.c | 4 +++ 3 files changed, 73 insertions(+), 0 deletions(-) diff --git a/fs/ocfs2/quota.h b/fs/ocfs2/quota.h index 33b47eb..f837265 100644 --- a/fs/ocfs2/quota.h +++ b/fs/ocfs2/quota.h @@ -14,6 +14,7 @@ #include &...

...RRENT_JOURNAL_FILL); - num_blocks = ocfs2_blocks_for_bytes(inode->i_sb, inode->i_size); + num_blocks = ocfs2_blocks_for_bytes(inode->i_sb, i_size_read(inode)); v_blkno = 0; while (v_blkno < num_blocks) { status = ocfs2_extent_map_get_blocks(inode, v_blkno, diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c index 1ed0f7c..df46418 100644 --- a/fs/ocfs2/quota_global.c +++ b/fs/ocfs2/quota_global.c @@ -210,7 +210,7 @@ ssize_t ocfs2_quota_write(struct super_block *sb, int type, } mutex_lock_nested(&gqinode->i_mutex, I_MUTEX_QUOTA); - if (gqinode->i_size < off...

Hi, I'm resending this patch series. It's rediffed against linux-next branch of Joel's git tree. The first four patches are obvious fixes of deadlocks in quota code and should go in as soon as possible. The other three patches implement lockdep support for OCFS2 cluster locks. So you can have a look whether the code make sence to you and possibly merge them. They should be NOP when

There is an error path in ocfs2_quota_write() that doesn't unlock &gqinode->i_mutex(). That seems unintentional. Found by smatch (http://repo.or.cz/w/smatch.git). Compile tested. regards, dan carpenter Signed-off-by: Dan Carpenter <error27 at gmail.com> --- orig/fs/ocfs2/quota_global.c 2009-04-07 19:34:22.000000000 +0300 +++ devel/fs/ocfs2/quota_global.c 2009-04-07 19:34:25.000000000 +0300 @@ -232,10 +232,8 @@ err = ocfs2_get_quota_block(gqinode, blk, &bh); ja_type = OCFS2_JOURNAL_ACCESS_CREATE; } - if (err) { - mlog_errno(err); - return err; - } + if (err) + go...

Hello, the following series of patches fixes some issues with OCFS2 quotas. The first patch modifies VFS quota locking, the next patch uses the fact to simplify OCFS2 quota locking and solves a few deadlock issues. The third and the fourth patches fix another possible deadlocks in OCFS2 quota code and the last patch is a minor cleanup. Honza

...2 ++++- fs/ocfs2/journal.h | 85 ++- fs/ocfs2/namei.c | 44 ++- fs/ocfs2/ocfs2.h | 7 +- fs/ocfs2/ocfs2_fs.h | 126 ++++- fs/ocfs2/ocfs2_lockid.h | 5 + fs/ocfs2/quota.h | 117 ++++ fs/ocfs2/quota_global.c | 990 ++++++++++++++++++++++++++++ fs/ocfs2/quota_local.c | 1253 ++++++++++++++++++++++++++++++++++++ fs/ocfs2/super.c | 277 ++++++++- fs/ocfs2/xattr.c | 567 +++++++++-------- fs/quota.c | 11 +- fs/quota_...

Hi, the first four patches in this series fix locking problems in OCFS2 quota code (three of them can lead to potential deadlocks). The fifth patch reorders ip_alloc_sem for directories to be acquired before localalloc locks. Mark would you please merge these? The last two patches implement lockdep annotations for OCFS2 cluster locks. We annotate all the cluster locks except for special ones

...configfs/dir.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++ fs/ocfs2/alloc.c | 3 ++ fs/ocfs2/dcache.c | 42 +++++++++++++++++++++++++++++++-- fs/ocfs2/dcache.h | 9 ++++++- fs/ocfs2/dlmglue.c | 4 +++ fs/ocfs2/ocfs2.h | 6 ++++ fs/ocfs2/quota_global.c | 4 ++- fs/ocfs2/super.c | 3 ++ fs/ocfs2/xattr.c | 17 ++++++------- 9 files changed, 133 insertions(+), 14 deletions(-) Jan Kara (2): ocfs2: Push out dropping of dentry lock to ocfs2_wq ocfs2: Fix possible deadlock in ocfs2_write_dquot() Joel Becker (1):...

...| 51 ++++++++++++ fs/ocfs2/dlmglue.h | 11 +++ fs/ocfs2/file.c | 56 ++++++++------ fs/ocfs2/journal.c | 111 ++++++++++++++++++++++++++ fs/ocfs2/journal.h | 4 + fs/ocfs2/ocfs2.h | 16 ++++ fs/ocfs2/ocfs2_lockid.h | 5 + fs/ocfs2/quota_global.c | 4 +- fs/ocfs2/quota_local.c | 21 ++++-- fs/ocfs2/super.c | 66 ++++++++++++---- fs/ocfs2/xattr.c | 5 +- 17 files changed, 610 insertions(+), 96 deletions(-) -- Life's Little Instruction Book #99 "Think big thoughts, but relish small pleasure...

...| 3 + fs/ocfs2/dlm/dlmast.c | 1 - fs/ocfs2/dlm/dlmrecovery.c | 2 +- fs/ocfs2/file.c | 5 +- fs/ocfs2/journal.c | 8 ++- fs/ocfs2/journal.h | 19 ++++--- fs/ocfs2/ocfs2.h | 22 ++++++- fs/ocfs2/quota.h | 1 - fs/ocfs2/quota_global.c | 134 +++++++++++++++++++++++-------------------- fs/ocfs2/quota_local.c | 110 +++++++++++++++++++++++++++++++----- fs/ocfs2/stack_o2cb.c | 3 +- fs/ocfs2/super.c | 30 +++++++++- fs/ocfs2/xattr.c | 3 +- 16 files changed, 357 insertions(+), 135 deletio...

...ain.c | 3 +- fs/ocfs2/dlm/dlmmaster.c | 22 ++- fs/ocfs2/dlm/dlmrecovery.c | 2 +- fs/ocfs2/file.c | 309 +++++++++++++++++++++++++++++++++++--------- fs/ocfs2/file.h | 6 +- fs/ocfs2/journal.c | 30 ++-- fs/ocfs2/localalloc.c | 7 + fs/ocfs2/quota_global.c | 2 +- fs/ocfs2/quota_local.c | 4 +- fs/ocfs2/refcounttree.c | 12 ++ fs/ocfs2/suballoc.c | 2 +- fs/ocfs2/xattr.c | 200 +++++++++++++++++++--------- include/linux/jbd2.h | 11 +- 16 files changed, 504 insertions(+), 224 deletions(-)

...0644 fs/ocfs2/ver.c delete mode 100644 fs/ocfs2/ver.h diff --git a/fs/ocfs2/Makefile b/fs/ocfs2/Makefile index f17e58b..ce210d4 100644 --- a/fs/ocfs2/Makefile +++ b/fs/ocfs2/Makefile @@ -38,7 +38,6 @@ ocfs2-objs := \ symlink.o \ sysfile.o \ uptodate.o \ - ver.o \ quota_local.o \ quota_global.o \ xattr.o \ diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c index c414929..a4382d1 100644 --- a/fs/ocfs2/super.c +++ b/fs/ocfs2/super.c @@ -68,7 +68,6 @@ #include "super.h" #include "sysfile.h" #include "uptodate.h" -#include "ver.h" #include &quo...

...2/localalloc.c | 275 ++++++++---- fs/ocfs2/localalloc.h | 3 + fs/ocfs2/mmap.c | 48 +-- fs/ocfs2/namei.c | 91 ++--- fs/ocfs2/ocfs2.h | 22 + fs/ocfs2/ocfs2_fs.h | 144 +++++- fs/ocfs2/quota_global.c | 4 +- fs/ocfs2/quota_local.c | 50 +-- fs/ocfs2/refcounttree.c | 74 ++-- fs/ocfs2/refcounttree.h | 4 +- fs/ocfs2/reservations.c | 847 ++++++++++++++++++++++++++++++++ fs/ocfs2/reservations.h | 159 ++++++ fs...

Hello, the following patch series implements quotas for OCFS2. The patch series is based on: git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2.git linux-next I've adressed Joel's comments, also node recovery is now fully working and I've fixed a few issues I found during my testing. So I'm currently not aware of any bugs. Please review, test, comment. Thanks.