Displaying 4 results from an estimated 4 matches for "quietfountain".
2023 Jul 11
3
[Bridge] [PATCH v1 net] bridge: Return an error when enabling STP in netns.
...set br0 type bridge stp_state 1
Error: bridge: STP can't be enabled in non-root netns.
Note this commit will be reverted later when we namespacify the whole LLC
infra.
Fixes: e730c15519d0 ("[NET]: Make packet reception network namespace safe")
Suggested-by: Harry Coin <hcoin at quietfountain.com>
Link: https://lore.kernel.org/netdev/0f531295-e289-022d-5add-5ceffa0df9bc at quietfountain.com/
Signed-off-by: Kuniyuki Iwashima <kuniyu at amazon.com>
---
net/bridge/br_stp_if.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c...
2023 Jul 12
0
[Bridge] [PATCH v1 net] bridge: Return an error when enabling STP in netns.
...; Error: bridge: STP can't be enabled in non-root netns.
>
> Note this commit will be reverted later when we namespacify the whole LLC
> infra.
>
> Fixes: e730c15519d0 ("[NET]: Make packet reception network namespace safe")
> Suggested-by: Harry Coin <hcoin at quietfountain.com>
> Link: https://lore.kernel.org/netdev/0f531295-e289-022d-5add-5ceffa0df9bc at quietfountain.com/
> Signed-off-by: Kuniyuki Iwashima <kuniyu at amazon.com>
> ---
> net/bridge/br_stp_if.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/net/bridge/br...
2023 Jul 12
2
[Bridge] [PATCH v1 net] bridge: Return an error when enabling STP in netns.
...can't be enabled in non-root netns.
>>
>> Note this commit will be reverted later when we namespacify the whole LLC
>> infra.
>>
>> Fixes: e730c15519d0 ("[NET]: Make packet reception network namespace safe")
>> Suggested-by: Harry Coin <hcoin at quietfountain.com>
>
> I'm not sure that's accurate. I read his response in the link below and
> he says "I'd rather be warned than blocked" and "But better warned and
> awaiting a fix than blocked", which I agree with. The patch has the
> potential to cause a l...
2023 Jul 12
0
[Bridge] llc needs namespace awareness asap, was Re: Patch fixing STP if bridge in non-default namespace.
(CC'ing bridge maintainers.)
Kuniyuki Iwashima <kuniyu at amazon.com> writes:
> From: Harry Coin <hcoin at quietfountain.com>
> Date: Tue, 11 Jul 2023 16:40:03 -0500
>> On 7/11/23 15:44, Andrew Lunn wrote:
>> >>>>>> The current llc_rcv.c around line 166 in net/llc/llc_input.c has
>> >>>>>>
>> >>>>>> if (!net_eq(dev_net(dev...