search for: queuepfn

Hi, "Appendix X: virtio-mmio" in the virtio spec says ? 0x040 | RW | QueuePFN [...] When the Guest stops using the queue it must write zero (0x0) to this register. [...] and Virtqueue Configuration [...] 2. Check if the queue is not already in use: read QueuePFN register, returned value should be zero (0x0). [...] I think this in its...

Hi, "Appendix X: virtio-mmio" in the virtio spec says ? 0x040 | RW | QueuePFN [...] When the Guest stops using the queue it must write zero (0x0) to this register. [...] and Virtqueue Configuration [...] 2. Check if the queue is not already in use: read QueuePFN register, returned value should be zero (0x0). [...] I think this in its...

My apologies, I used Anthony's previous (now obsolete) email. Updated it now & keeping full context below. Sorry. On 10/22/13 19:49, Laszlo Ersek wrote: > Hi, > > "Appendix X: virtio-mmio" in the virtio spec says > > ? 0x040 | RW | QueuePFN > [...] When the Guest stops using the queue it must write zero > (0x0) to this register. > [...] > > and > > Virtqueue Configuration > > [...] > 2. Check if the queue is not already in use: read QueuePFN > register, returned val...

On Mon, 2011-12-12 at 02:52 +0000, Paul Brook wrote: > I've taken a look at the virtion-mmio spec, and it looks fairly > reasonable. > > The only thing I'd change is the GuestPageSize/QueuePFN mess. Seems like just > using straight 64-bit addresses would be a better solution. Maybe split into > a high/low pair to keep all registers as 32-bit registers. This can be done fairly simple by: 1. Bumping Version register content. 2. Adding two registers: QueueAddrLow (0x44) and Queue...

On Mon, 2011-12-12 at 02:52 +0000, Paul Brook wrote: > I've taken a look at the virtion-mmio spec, and it looks fairly > reasonable. > > The only thing I'd change is the GuestPageSize/QueuePFN mess. Seems like just > using straight 64-bit addresses would be a better solution. Maybe split into > a high/low pair to keep all registers as 32-bit registers. This can be done fairly simple by: 1. Bumping Version register content. 2. Adding two registers: QueueAddrLow (0x44) and Queue...

...spec. To make the long story short, this is what came out of the discussion (feel free to correct me at any point, Peter ;-): diff --git a/virtio-spec.lyx b/virtio-spec.lyx index 6426f8f..79a6498 100644 --- a/virtio-spec.lyx +++ b/virtio-spec.lyx @@ -6681,7 +6681,9 @@ s on QueueNum, QueueAlign and QueuePFN apply to. Writing to this register notifies the Host what size of the queue the Guest will use. - This applies to the queue selected by writing to QueueSel. + This applies to the queue selected by writing to QueueSel and is allowed + only when QueuePFN is set to zero (0x0), so when the queue...

...spec. To make the long story short, this is what came out of the discussion (feel free to correct me at any point, Peter ;-): diff --git a/virtio-spec.lyx b/virtio-spec.lyx index 6426f8f..79a6498 100644 --- a/virtio-spec.lyx +++ b/virtio-spec.lyx @@ -6681,7 +6681,9 @@ s on QueueNum, QueueAlign and QueuePFN apply to. Writing to this register notifies the Host what size of the queue the Guest will use. - This applies to the queue selected by writing to QueueSel. + This applies to the queue selected by writing to QueueSel and is allowed + only when QueuePFN is set to zero (0x0), so when the queue...

"A number of virtqueues are created" seems clearer than "the number of virtqueues": it's virtqueues that are created not the number. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- I'm not a native english speaker but the below seems correct to me. Rusty? virtio-spec.lyx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

"A number of virtqueues are created" seems clearer than "the number of virtqueues": it's virtqueues that are created not the number. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- I'm not a native english speaker but the below seems correct to me. Rusty? virtio-spec.lyx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

On Mon, 2011-10-24 at 03:33 +0100, Rusty Russell wrote: > No, that's it I think. Please send a diff for the documentation, since > I'm updating the LyX master and I've already applied your previous > version. Here it goes (below). Also do you think you would be able to merge the driver (corresponding v4 patch follows) in the 3.2 merge window that seems to have just opened?

On Mon, 2011-10-24 at 03:33 +0100, Rusty Russell wrote: > No, that's it I think. Please send a diff for the documentation, since > I'm updating the LyX master and I've already applied your previous > version. Here it goes (below). Also do you think you would be able to merge the driver (corresponding v4 patch follows) in the 3.2 merge window that seems to have just opened?

...ge in bytes - * - * 0x030 W QueueSel Queue selector - * 0x034 R QueueNumMax Maximum size of the currently selected queue - * 0x038 W QueueNum Queue size for the currently selected queue - * 0x03c W QueueAlign Used Ring alignment for the current queue - * 0x040 RW QueuePFN PFN for the currently selected queue - * - * 0x050 W QueueNotify Queue notifier - * 0x060 R InterruptStatus Interrupt status register - * 0x064 W InterruptACK Interrupt acknowledge register - * 0x070 RW Status Device status register - * - * 0x100+ RW...

...ge in bytes - * - * 0x030 W QueueSel Queue selector - * 0x034 R QueueNumMax Maximum size of the currently selected queue - * 0x038 W QueueNum Queue size for the currently selected queue - * 0x03c W QueueAlign Used Ring alignment for the current queue - * 0x040 RW QueuePFN PFN for the currently selected queue - * - * 0x050 W QueueNotify Queue notifier - * 0x060 R InterruptStatus Interrupt status register - * 0x064 W InterruptACK Interrupt acknowledge register - * 0x070 RW Status Device status register - * - * 0x100+ RW...

...ge in bytes - * - * 0x030 W QueueSel Queue selector - * 0x034 R QueueNumMax Maximum size of the currently selected queue - * 0x038 W QueueNum Queue size for the currently selected queue - * 0x03c W QueueAlign Used Ring alignment for the current queue - * 0x040 RW QueuePFN PFN for the currently selected queue - * - * 0x050 W QueueNotify Queue notifier - * 0x060 R InterruptStatus Interrupt status register - * 0x064 W InterruptACK Interrupt acknowledge register - * 0x070 RW Status Device status register - * - * 0x100+ RW...

...ge in bytes - * - * 0x030 W QueueSel Queue selector - * 0x034 R QueueNumMax Maximum size of the currently selected queue - * 0x038 W QueueNum Queue size for the currently selected queue - * 0x03c W QueueAlign Used Ring alignment for the current queue - * 0x040 RW QueuePFN PFN for the currently selected queue - * - * 0x050 W QueueNotify Queue notifier - * 0x060 R InterruptStatus Interrupt status register - * 0x064 W InterruptACK Interrupt acknowledge register - * 0x070 RW Status Device status register - * - * 0x100+ RW...

...0x030 W QueueSel Queue selector > - * 0x034 R QueueNumMax Maximum size of the currently selected queue > - * 0x038 W QueueNum Queue size for the currently selected queue > - * 0x03c W QueueAlign Used Ring alignment for the current queue > - * 0x040 RW QueuePFN PFN for the currently selected queue > - * > - * 0x050 W QueueNotify Queue notifier > - * 0x060 R InterruptStatus Interrupt status register > - * 0x064 W InterruptACK Interrupt acknowledge register > - * 0x070 RW Status Device status register > -...

...0x030 W QueueSel Queue selector > - * 0x034 R QueueNumMax Maximum size of the currently selected queue > - * 0x038 W QueueNum Queue size for the currently selected queue > - * 0x03c W QueueAlign Used Ring alignment for the current queue > - * 0x040 RW QueuePFN PFN for the currently selected queue > - * > - * 0x050 W QueueNotify Queue notifier > - * 0x060 R InterruptStatus Interrupt status register > - * 0x064 W InterruptACK Interrupt acknowledge register > - * 0x070 RW Status Device status register > -...

...ge in bytes - * - * 0x030 W QueueSel Queue selector - * 0x034 R QueueNumMax Maximum size of the currently selected queue - * 0x038 W QueueNum Queue size for the currently selected queue - * 0x03c W QueueAlign Used Ring alignment for the current queue - * 0x040 RW QueuePFN PFN for the currently selected queue - * - * 0x050 W QueueNotify Queue notifier - * 0x060 R InterruptStatus Interrupt status register - * 0x064 W InterruptACK Interrupt acknowledge register - * 0x070 RW Status Device status register - * - * 0x100+ RW...

...ge in bytes - * - * 0x030 W QueueSel Queue selector - * 0x034 R QueueNumMax Maximum size of the currently selected queue - * 0x038 W QueueNum Queue size for the currently selected queue - * 0x03c W QueueAlign Used Ring alignment for the current queue - * 0x040 RW QueuePFN PFN for the currently selected queue - * - * 0x050 W QueueNotify Queue notifier - * 0x060 R InterruptStatus Interrupt status register - * 0x064 W InterruptACK Interrupt acknowledge register - * 0x070 RW Status Device status register - * - * 0x100+ RW...

...0x030 W QueueSel Queue selector > - * 0x034 R QueueNumMax Maximum size of the currently selected queue > - * 0x038 W QueueNum Queue size for the currently selected queue > - * 0x03c W QueueAlign Used Ring alignment for the current queue > - * 0x040 RW QueuePFN PFN for the currently selected queue > - * > - * 0x050 W QueueNotify Queue notifier > - * 0x060 R InterruptStatus Interrupt status register > - * 0x064 W InterruptACK Interrupt acknowledge register > - * 0x070 RW Status Device status register > -...