search for: qsz

...zation list, please keep me CC'd. Thanks! Laszlo Ersek (5): Receiving Used Buffers: fix typo in "ring empty" condition in example code Receiving Used Buffers: re-disable interrupts when staying in the loop Receiving Used Buffers: variable for Queue Size is called "qsz" elsewhere Receiving Used Buffers: switch . and -> operators, add missing & Receiving Used Buffers: prevent speculative load when not sequentially consistent virtio-spec.lyx | 16 +++++++++++++--- 1 files changed, 13 insertions(+), 3 deletions(-)

...zation list, please keep me CC'd. Thanks! Laszlo Ersek (5): Receiving Used Buffers: fix typo in "ring empty" condition in example code Receiving Used Buffers: re-disable interrupts when staying in the loop Receiving Used Buffers: variable for Queue Size is called "qsz" elsewhere Receiving Used Buffers: switch . and -> operators, add missing & Receiving Used Buffers: prevent speculative load when not sequentially consistent virtio-spec.lyx | 16 +++++++++++++--- 1 files changed, 13 insertions(+), 3 deletions(-)

Hi, (I'm not subscribed to either list,) using the word "descriptor" is misleading in the following sections: 2.4.1.2 Updating The Available Ring [...] However, in general we can add many descriptors before we update the idx fi eld (at which point they become visible to the device), so we keep a counter of how many we've added: [...] and 2.4.1.3 Updating The Index

Hi, (I'm not subscribed to either list,) using the word "descriptor" is misleading in the following sections: 2.4.1.2 Updating The Available Ring [...] However, in general we can add many descriptors before we update the idx fi eld (at which point they become visible to the device), so we keep a counter of how many we've added: [...] and 2.4.1.3 Updating The Index

...mand ref +reference "cha:Reserved-Feature-Bits" + +\end_inset + +). + +\change_unchanged +This interrupt suppression is merely an optimization; it may not suppress interrupts entirely. \end_layout @@ -1940,6 +2202,17 @@ struct vring_avail { \begin_layout Plain Layout u16 ring[qsz]; /* qsz is the Queue Size field read from device */ +\change_inserted 0 1304329945 + +\end_layout + +\begin_layout Plain Layout + +\change_inserted 0 1304329957 + + u16 used_event; +\change_unchanged + \end_layout \begin_layout Plain Layout @@ -1963,8 +2236,71 @@ The used ring is where the d...

...mand ref +reference "cha:Reserved-Feature-Bits" + +\end_inset + +). + +\change_unchanged +This interrupt suppression is merely an optimization; it may not suppress interrupts entirely. \end_layout @@ -1940,6 +2202,17 @@ struct vring_avail { \begin_layout Plain Layout u16 ring[qsz]; /* qsz is the Queue Size field read from device */ +\change_inserted 0 1304329945 + +\end_layout + +\begin_layout Plain Layout + +\change_inserted 0 1304329957 + + u16 used_event; +\change_unchanged + \end_layout \begin_layout Plain Layout @@ -1963,8 +2236,71 @@ The used ring is where the d...

...> Thanks! > > Laszlo Ersek (5): > Receiving Used Buffers: fix typo in "ring empty" condition in example > code > Receiving Used Buffers: re-disable interrupts when staying in the > loop > Receiving Used Buffers: variable for Queue Size is called "qsz" > elsewhere > Receiving Used Buffers: switch . and -> operators, add missing & > Receiving Used Buffers: prevent speculative load when not > sequentially consistent > > virtio-spec.lyx | 16 +++++++++++++--- > 1 files changed, 13 insertions(+), 3 del...

From: Erwan Yvin <erwan.yvin at stericsson.com> This driver depends on Rusty's new host virtio ring implementation, so this patch-set is based on the vringh branch in Rusty's git. with the vringh wrapper patch on top. They do not apply cleanly on top of the remoteproc virtio config patches from Sjur, but it merges fine. CAIF will use this new host virtio ring implementation. Ido,

From: Erwan Yvin <erwan.yvin at stericsson.com> This driver depends on Rusty's new host virtio ring implementation, so this patch-set is based on the vringh branch in Rusty's git. with the vringh wrapper patch on top. They do not apply cleanly on top of the remoteproc virtio config patches from Sjur, but it merges fine. CAIF will use this new host virtio ring implementation. Ido,

...mand ref +reference "cha:Reserved-Feature-Bits" + +\end_inset + +). + +\change_unchanged +This interrupt suppression is merely an optimization; it may not suppress interrupts entirely. \end_layout @@ -1940,6 +2221,17 @@ struct vring_avail { \begin_layout Plain Layout u16 ring[qsz]; /* qsz is the Queue Size field read from device */ +\change_inserted 1 1304329945 + +\end_layout + +\begin_layout Plain Layout + +\change_inserted 1 1304329957 + + u16 used_event; +\change_unchanged + \end_layout \begin_layout Plain Layout @@ -1963,8 +2255,71 @@ The used ring is where the d...

...mand ref +reference "cha:Reserved-Feature-Bits" + +\end_inset + +). + +\change_unchanged +This interrupt suppression is merely an optimization; it may not suppress interrupts entirely. \end_layout @@ -1940,6 +2221,17 @@ struct vring_avail { \begin_layout Plain Layout u16 ring[qsz]; /* qsz is the Queue Size field read from device */ +\change_inserted 1 1304329945 + +\end_layout + +\begin_layout Plain Layout + +\change_inserted 1 1304329957 + + u16 used_event; +\change_unchanged + \end_layout \begin_layout Plain Layout @@ -1963,8 +2255,71 @@ The used ring is where the d...

Changes from v2: added padding between avail idx and flags, and changed virtio to only publish used index when callbacks are enabled. Here's a rewrite of the original patch with a new layout. I haven't tested it yet so no idea how this performs, but I think this addresses the cache bounce issue raised by Avi. Posting for early flames/comments. Generally, the Host end of the virtio ring

Changes from v2: added padding between avail idx and flags, and changed virtio to only publish used index when callbacks are enabled. Here's a rewrite of the original patch with a new layout. I haven't tested it yet so no idea how this performs, but I think this addresses the cache bounce issue raised by Avi. Posting for early flames/comments. Generally, the Host end of the virtio ring

Here's a rewrite of the original patch with a new layout. I haven't tested it yet so no idea how this performs, but I think this addresses the cache bounce issue raised by Avi. Posting for early flames/comments. Generally, the Host end of the virtio ring doesn't need to see where Guest is up to in consuming the ring. However, to completely understand what's going on from the

Here's a rewrite of the original patch with a new layout. I haven't tested it yet so no idea how this performs, but I think this addresses the cache bounce issue raised by Avi. Posting for early flames/comments. Generally, the Host end of the virtio ring doesn't need to see where Guest is up to in consuming the ring. However, to completely understand what's going on from the

...rs/remoteproc/remoteproc_virtio.c Ohad Ben-Cohen 2012-02-13 97 memset(addr, 0, size); ac8954a41 drivers/remoteproc/remoteproc_rpmsg.c Ohad Ben-Cohen 2011-10-20 98 b5ab5e24e drivers/remoteproc/remoteproc_virtio.c Ohad Ben-Cohen 2012-05-30 99 dev_dbg(dev, "vring%d: va %p qsz %d notifyid %d\n", 7a1869416 drivers/remoteproc/remoteproc_virtio.c Ohad Ben-Cohen 2012-02-13 100 id, addr, len, rvring->notifyid); ac8954a41 drivers/remoteproc/remoteproc_rpmsg.c Ohad Ben-Cohen 2011-10-20 101 dd6da1c5e drivers/remoteproc/remoteproc_rpmsg.c Ohad Ben-Cohen...

...rs/remoteproc/remoteproc_virtio.c Ohad Ben-Cohen 2012-02-13 97 memset(addr, 0, size); ac8954a41 drivers/remoteproc/remoteproc_rpmsg.c Ohad Ben-Cohen 2011-10-20 98 b5ab5e24e drivers/remoteproc/remoteproc_virtio.c Ohad Ben-Cohen 2012-05-30 99 dev_dbg(dev, "vring%d: va %p qsz %d notifyid %d\n", 7a1869416 drivers/remoteproc/remoteproc_virtio.c Ohad Ben-Cohen 2012-02-13 100 id, addr, len, rvring->notifyid); ac8954a41 drivers/remoteproc/remoteproc_rpmsg.c Ohad Ben-Cohen 2011-10-20 101 dd6da1c5e drivers/remoteproc/remoteproc_rpmsg.c Ohad Ben-Cohen...

...E(rvdev->vring)) + return ERR_PTR(-ENODEV); + + ret = rproc_alloc_vring(rvdev, i); + if (ret) + return ERR_PTR(ret); + + addr = rvring->va; + len = rvring->len; + + /* zero vring */ + size = vring_size(len, rvring->align); + memset(addr, 0, size); + + dev_dbg(dev, "vring%d: va %p qsz %d notifyid %d\n", + id, addr, len, rvring->notifyid); + + /* + * Create the new vringh, and tell virtio we're not interested in + * the 'weak' smp barriers, since we're talking with a real device. + */ + vrh = rproc_create_new_vringh(rvring, id, callback); + if (!vrh...

...E(rvdev->vring)) + return ERR_PTR(-ENODEV); + + ret = rproc_alloc_vring(rvdev, i); + if (ret) + return ERR_PTR(ret); + + addr = rvring->va; + len = rvring->len; + + /* zero vring */ + size = vring_size(len, rvring->align); + memset(addr, 0, size); + + dev_dbg(dev, "vring%d: va %p qsz %d notifyid %d\n", + id, addr, len, rvring->notifyid); + + /* + * Create the new vringh, and tell virtio we're not interested in + * the 'weak' smp barriers, since we're talking with a real device. + */ + vrh = rproc_create_new_vringh(rvring, id, callback); + if (!vrh...

...2?dry#;P)tybSt-<Q3o@<W=BZ<Tc<e<aOZH<QzEXkT($DPu>K7&08QWAa8 at Pk-P)^ zBzYHj4SCP(+D`BUA4Vh7$@|g*d?4|MApiX%pb6w-WR4}DAU=+KY8LtoHQY-+2i{A* zK*o6TB at u_JuMnR>z6N~-`3Cq9`PMA(ohhyFk^i3`h){<gfe(<Mh)|QCrAD4bW&=47 z2~__A@<DRJEc-F&V at QK4uOLRL1d}>iy-W#=QH9Kuv8qszajK^LV?3fykO``s?r}Jc z)lXD~7EA(t9ht0(OVTOoWkx>fb&RO{A(-RjA>b1vP0`7%X9=B(YEF}>D0+%a13p8h zqwI at hhDwa)$`1q;=wv+Epk6f-oRigA;JH9%A>N?Q2A;0Y0cD&z7kCLM&`@<A at B(!{ z at FH~q at Xur+>Rhib0$!yq24$wY1bDu>6qGgUGQ`KK%YnzBl%_0JS0FwQb!y5|btU5G z$xPr$>MHQBRab+)Qe6W)QC$l>T...