search for: qiochannel

...filename = virtio_pstore_to_filename(s, req); + if (filename == NULL) + return -1; + + ret = unlink(filename); + + g_free(filename); + return ret; +} + +struct pstore_read_arg { + VirtIOPstore *vps; + VirtQueueElement *elem; + struct virtio_pstore_fileinfo info; + QIOChannel *ioc; +}; + +static gboolean pstore_async_read_fn(QIOChannel *ioc, GIOCondition condition, + gpointer data) +{ + struct pstore_read_arg *rarg = data; + struct virtio_pstore_fileinfo *info = &rarg->info; + VirtIOPstore *vps = rarg->vps; + Vir...

...> > + g_free(filename); > > > + return ret; > > > +} > > > + > > > +struct pstore_read_arg { > > > + VirtIOPstore *vps; > > > + VirtQueueElement *elem; > > > + struct virtio_pstore_fileinfo info; > > > + QIOChannel *ioc; > > > +}; > > > + > > > +static gboolean pstore_async_read_fn(QIOChannel *ioc, GIOCondition condition, > > > + gpointer data) > > > +{ > > > + struct pstore_read_arg *rarg = data; > > > +...

This is a cover letter to a series of patches being proposed in tandem to four different projects: - nbd: Document a new NBD_CMD_FLAG_FAST_ZERO command flag - qemu: Implement the flag for both clients and server - libnbd: Implement the flag for clients - nbdkit: Implement the flag for servers, including the nbd passthrough client If you want to test the patches together, I've pushed a

Hello, This is another iteration of the virtio-pstore work. In this patchset I addressed most of feedbacks from previous version and drooped the support for PSTORE_TYPE_CONSOLE for simplicity. It'll be added once the basic implementation * changes in v3) - use QIOChannel API (Stefan, Daniel) - add bound check for malcious guests (Daniel) - drop support PSTORE_TYPE_CONSOLE for now - update license to allow GPL v2 or later (Michael) - limit number of pstore files on qemu * changes in v2) - update VIRTIO_ID_PSTORE to 22 (Cornelia, Stefan) - make buff...

Hello, This is another iteration of the virtio-pstore work. In this patchset I addressed most of feedbacks from previous version and drooped the support for PSTORE_TYPE_CONSOLE for simplicity. It'll be added once the basic implementation * changes in v3) - use QIOChannel API (Stefan, Daniel) - add bound check for malcious guests (Daniel) - drop support PSTORE_TYPE_CONSOLE for now - update license to allow GPL v2 or later (Michael) - limit number of pstore files on qemu * changes in v2) - update VIRTIO_ID_PSTORE to 22 (Cornelia, Stefan) - make buff...

...goto out; > + > + filename = g_strdup_printf("%s/%s", s->directory, files[0]->d_name); > + if (filename == NULL) { > + ret = -1; > + goto out; > + } > + > + ret = unlink(filename); > +static gboolean pstore_async_read_fn(QIOChannel *ioc, GIOCondition condition, > + gpointer data) > +{ > + struct pstore_read_arg *rarg = data; > + struct virtio_pstore_fileinfo *info = &rarg->info; > + VirtIOPstore *vps = rarg->vps; > + VirtQueueElement *elem = rarg->...

...goto out; > + > + filename = g_strdup_printf("%s/%s", s->directory, files[0]->d_name); > + if (filename == NULL) { > + ret = -1; > + goto out; > + } > + > + ret = unlink(filename); > +static gboolean pstore_async_read_fn(QIOChannel *ioc, GIOCondition condition, > + gpointer data) > +{ > + struct pstore_read_arg *rarg = data; > + struct virtio_pstore_fileinfo *info = &rarg->info; > + VirtIOPstore *vps = rarg->vps; > + VirtQueueElement *elem = rarg->...

..., or more interestingly, info on a different name), as a patch against qemu commit 6f214b30445: | diff --git i/nbd/client.c w/nbd/client.c | index f6733962b49b..425292ac5ea9 100644 | --- i/nbd/client.c | +++ w/nbd/client.c | @@ -1038,6 +1038,14 @@ int nbd_receive_negotiate(AioContext *aio_context, QIOChannel *ioc, | * TLS). If it is not available, fall back to | * NBD_OPT_LIST for nicer error messages about a missing | * export, then use NBD_OPT_EXPORT_NAME. */ | + if (getenv ("HACK")) | + info->name[0]++; | + result = nbd_opt_info_o...

...; > > > Please look at include/io/channel.h. QEMU is event-driven and tends to > > use asynchronous I/O instead of spawning threads. The include/io/ APIs > > allow you to do asynchronous I/O in the event loop. > > That is true, except for I/O to/from plain files - the QIOChannelFile > impl doesn't do anything special (yet) to make that work correctly in > non-blocking mode. Of course that could be fixed... Yep, I don't know how I can use the QIOChannelFile for async IO. AFAICS it's just a wrapper for normal readv/writev. Who is responsible to do these I...

...; > > > Please look at include/io/channel.h. QEMU is event-driven and tends to > > use asynchronous I/O instead of spawning threads. The include/io/ APIs > > allow you to do asynchronous I/O in the event loop. > > That is true, except for I/O to/from plain files - the QIOChannelFile > impl doesn't do anything special (yet) to make that work correctly in > non-blocking mode. Of course that could be fixed... Yep, I don't know how I can use the QIOChannelFile for async IO. AFAICS it's just a wrapper for normal readv/writev. Who is responsible to do these I...

The first one is the nastiest - it is an assertion failure caused by a spec-compliant client and introduced by our security fix that was released in 1.14.1. Eric Blake (4): server: Fix regression for NBD_OPT_INFO before NBD_OPT_GO server: Fix back-to-back SET_META_CONTEXT server: Forbid NUL in export and context names server: Fix OPT_GO on different export than SET_META_CONTEXT

...quot;%s/%s", s->directory, files[0]->d_name); > > + if (filename == NULL) { > > + ret = -1; > > + goto out; > > + } > > + > > + ret = unlink(filename); > > > > > > > +static gboolean pstore_async_read_fn(QIOChannel *ioc, GIOCondition condition, > > + gpointer data) > > +{ > > + struct pstore_read_arg *rarg = data; > > + struct virtio_pstore_fileinfo *info = &rarg->info; > > + VirtIOPstore *vps = rarg->vps; > > + Virt...

...ther iteration of the virtio-pstore work. I've addressed all comments from Daniel Berrange on the qemu side. * changes in v4) - use qio_channel_file_new_path() (Daniel) - rename to delete_old_pstore_file (Daniel) - convert G_REMOVE_SOURCE to FALSE (Daniel) * changes in v3) - use QIOChannel API (Stefan, Daniel) - add bound check for malcious guests (Daniel) - drop support PSTORE_TYPE_CONSOLE for now - update license to allow GPL v2 or later (Michael) - limit number of pstore files on qemu * changes in v2) - update VIRTIO_ID_PSTORE to 22 (Cornelia, Stefan) - make buff...

...ther iteration of the virtio-pstore work. I've addressed all comments from Daniel Berrange on the qemu side. * changes in v4) - use qio_channel_file_new_path() (Daniel) - rename to delete_old_pstore_file (Daniel) - convert G_REMOVE_SOURCE to FALSE (Daniel) * changes in v3) - use QIOChannel API (Stefan, Daniel) - add bound check for malcious guests (Daniel) - drop support PSTORE_TYPE_CONSOLE for now - update license to allow GPL v2 or later (Michael) - limit number of pstore files on qemu * changes in v2) - update VIRTIO_ID_PSTORE to 22 (Cornelia, Stefan) - make buff...