search for: qinchuanyu

...ion is 16% Completed performance test on 40gbe shows no obvious changes in both throughput and cpu utilization with this patch. The patch only solve this issue when unlimited sndbuf. We still need a solution for limited sndbuf. Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Qin Chuanyu <qinchuanyu at huawei.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- Changes from V1: - Remove VHOST_MAX_PEND and switch to use half of the vq size as the limit - Add cpu utilization in commit log --- drivers/vhost/net.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 delet...

...ion is 16% Completed performance test on 40gbe shows no obvious changes in both throughput and cpu utilization with this patch. The patch only solve this issue when unlimited sndbuf. We still need a solution for limited sndbuf. Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Qin Chuanyu <qinchuanyu at huawei.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- Changes from V1: - Remove VHOST_MAX_PEND and switch to use half of the vq size as the limit - Add cpu utilization in commit log --- drivers/vhost/net.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 delet...

...on VM shotdown so might happen after a looooong time). Let's do what we probably should have done straight away: switch from kref to plain atomic, documenting the semantics, return the refcount value atomically after decrement, then use that to avoid the deadlock. Reported-by: Qin Chuanyu <qinchuanyu at huawei.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- This patch is needed for 3.14 and -stable. drivers/vhost/net.c | 41 ++++++++++++++++++++--------------------- 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net...

...on VM shotdown so might happen after a looooong time). Let's do what we probably should have done straight away: switch from kref to plain atomic, documenting the semantics, return the refcount value atomically after decrement, then use that to avoid the deadlock. Reported-by: Qin Chuanyu <qinchuanyu at huawei.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- This patch is needed for 3.14 and -stable. drivers/vhost/net.c | 41 ++++++++++++++++++++--------------------- 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net...

...m1 to External throughput is 93Mbit/s Simple performance test on 40gbe shows no obvious changes in throughput after this patch. The patch only solve this issue when unlimited sndbuf. We still need a solution for limited sndbuf. Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Qin Chuanyu <qinchuanyu at huawei.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/vhost/net.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index a0fa5de..3e96e47 100644 --- a/drivers/vhost/net.c +++ b/drivers/...

...m1 to External throughput is 93Mbit/s Simple performance test on 40gbe shows no obvious changes in throughput after this patch. The patch only solve this issue when unlimited sndbuf. We still need a solution for limited sndbuf. Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Qin Chuanyu <qinchuanyu at huawei.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/vhost/net.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index a0fa5de..3e96e47 100644 --- a/drivers/vhost/net.c +++ b/drivers/...

...oughput and cpu utilization with this patch. >> > >> > The patch only solve this issue when unlimited sndbuf. We still need a >> > solution for limited sndbuf. >> > >> > Cc: Michael S. Tsirkin <mst at redhat.com> >> > Cc: Qin Chuanyu <qinchuanyu at huawei.com> >> > Signed-off-by: Jason Wang <jasowang at redhat.com> > I thought hard about this. > Here's what worries me: if there are still head of line > blocking issues lurking in the stack, they will still > hurt guests such as windows which rely on timely...

...oughput and cpu utilization with this patch. >> > >> > The patch only solve this issue when unlimited sndbuf. We still need a >> > solution for limited sndbuf. >> > >> > Cc: Michael S. Tsirkin <mst at redhat.com> >> > Cc: Qin Chuanyu <qinchuanyu at huawei.com> >> > Signed-off-by: Jason Wang <jasowang at redhat.com> > I thought hard about this. > Here's what worries me: if there are still head of line > blocking issues lurking in the stack, they will still > hurt guests such as windows which rely on timely...

...est on 40gbe shows no obvious changes in >> throughput after this patch. >> >> The patch only solve this issue when unlimited sndbuf. We still need a >> solution for limited sndbuf. >> >> Cc: Michael S. Tsirkin<mst at redhat.com> >> Cc: Qin Chuanyu<qinchuanyu at huawei.com> >> Signed-off-by: Jason Wang<jasowang at redhat.com> > I think this needs some thought. > > In particular I think this works because VHOST_MAX_PEND > is much smaller than the ring size. > Shouldn't max_pend then be tied to the ring size if it's s...

...est on 40gbe shows no obvious changes in >> throughput after this patch. >> >> The patch only solve this issue when unlimited sndbuf. We still need a >> solution for limited sndbuf. >> >> Cc: Michael S. Tsirkin<mst at redhat.com> >> Cc: Qin Chuanyu<qinchuanyu at huawei.com> >> Signed-off-by: Jason Wang<jasowang at redhat.com> > I think this needs some thought. > > In particular I think this works because VHOST_MAX_PEND > is much smaller than the ring size. > Shouldn't max_pend then be tied to the ring size if it's s...

...; throughput after this patch. >>>> >>>> The patch only solve this issue when unlimited sndbuf. We still need a >>>> solution for limited sndbuf. >>>> >>>> Cc: Michael S. Tsirkin<mst at redhat.com> >>>> Cc: Qin Chuanyu<qinchuanyu at huawei.com> >>>> Signed-off-by: Jason Wang<jasowang at redhat.com> >>> I think this needs some thought. >>> >>> In particular I think this works because VHOST_MAX_PEND >>> is much smaller than the ring size. >>> Shouldn't max_...

...; throughput after this patch. >>>> >>>> The patch only solve this issue when unlimited sndbuf. We still need a >>>> solution for limited sndbuf. >>>> >>>> Cc: Michael S. Tsirkin<mst at redhat.com> >>>> Cc: Qin Chuanyu<qinchuanyu at huawei.com> >>>> Signed-off-by: Jason Wang<jasowang at redhat.com> >>> I think this needs some thought. >>> >>> In particular I think this works because VHOST_MAX_PEND >>> is much smaller than the ring size. >>> Shouldn't max_...

...est on 40gbe shows no obvious changes in both > throughput and cpu utilization with this patch. > > The patch only solve this issue when unlimited sndbuf. We still need a > solution for limited sndbuf. > > Cc: Michael S. Tsirkin <mst at redhat.com> > Cc: Qin Chuanyu <qinchuanyu at huawei.com> > Signed-off-by: Jason Wang <jasowang at redhat.com> I'd like some vhost experts reviewing this before I apply it.

...f. We still need a >>>>>> > >>>>solution for limited sndbuf. >>>>>> > >>>> >>>>>> > >>>>Cc: Michael S. Tsirkin<mst at redhat.com> >>>>>> > >>>>Cc: Qin Chuanyu<qinchuanyu at huawei.com> >>>>>> > >>>>Signed-off-by: Jason Wang<jasowang at redhat.com> >>>>> > >>>I think this needs some thought. >>>>> > >>> >>>>> > >>>In particular I think this work...

...f. We still need a >>>>>> > >>>>solution for limited sndbuf. >>>>>> > >>>> >>>>>> > >>>>Cc: Michael S. Tsirkin<mst at redhat.com> >>>>>> > >>>>Cc: Qin Chuanyu<qinchuanyu at huawei.com> >>>>>> > >>>>Signed-off-by: Jason Wang<jasowang at redhat.com> >>>>> > >>>I think this needs some thought. >>>>> > >>> >>>>> > >>>In particular I think this work...

Hi Qin, On Mon, Aug 26, 2013 at 10:32 PM, Qin Chuanyu <qinchuanyu@huawei.com> wrote: > Hi all > > I am participating in a project which try to port vhost_net on Xen。 Neat! > By change the memory copy and notify mechanism ，currently virtio-net with > vhost_net could run on Xen with good performance。 I think the key in doing this would be to im...

...gt; Simple performance test on 40gbe shows no obvious changes in > throughput after this patch. > > The patch only solve this issue when unlimited sndbuf. We still need a > solution for limited sndbuf. > > Cc: Michael S. Tsirkin <mst at redhat.com> > Cc: Qin Chuanyu <qinchuanyu at huawei.com> > Signed-off-by: Jason Wang <jasowang at redhat.com> I think this needs some thought. In particular I think this works because VHOST_MAX_PEND is much smaller than the ring size. Shouldn't max_pend then be tied to the ring size if it's small? Another question is...

...utilization with this patch. >>>> >>>> The patch only solve this issue when unlimited sndbuf. We still need a >>>> solution for limited sndbuf. >>>> >>>> Cc: Michael S. Tsirkin <mst at redhat.com> >>>> Cc: Qin Chuanyu <qinchuanyu at huawei.com> >>>> Signed-off-by: Jason Wang <jasowang at redhat.com> >> I thought hard about this. >> Here's what worries me: if there are still head of line >> blocking issues lurking in the stack, they will still >> hurt guests such as windows wh...

...tch. > >>>> > >>>>The patch only solve this issue when unlimited sndbuf. We still need a > >>>>solution for limited sndbuf. > >>>> > >>>>Cc: Michael S. Tsirkin<mst at redhat.com> > >>>>Cc: Qin Chuanyu<qinchuanyu at huawei.com> > >>>>Signed-off-by: Jason Wang<jasowang at redhat.com> > >>>I think this needs some thought. > >>> > >>>In particular I think this works because VHOST_MAX_PEND > >>>is much smaller than the ring size. > >&...

...est on 40gbe shows no obvious changes in both > throughput and cpu utilization with this patch. > > The patch only solve this issue when unlimited sndbuf. We still need a > solution for limited sndbuf. > > Cc: Michael S. Tsirkin <mst at redhat.com> > Cc: Qin Chuanyu <qinchuanyu at huawei.com> > Signed-off-by: Jason Wang <jasowang at redhat.com> I thought hard about this. Here's what worries me: if there are still head of line blocking issues lurking in the stack, they will still hurt guests such as windows which rely on timely completion of buffers, but i...