search for: qemuopts_to_argv

...ts *qopts) { - /* Nothing to do, the list is already well-formed. */ + struct qopt *qopt; + size_t len; + + qopt = last_option (qopts); + assert (qopt->type == QOPT_ARG_LIST); + len = count_strings (qopt->values); + if (len == 0) + return -1; + return 0; } @@ -816,7 +824,9 @@ qemuopts_to_argv (struct qemuopts *qopts) case QOPT_ARG_LIST: /* We only have to do comma-quoting here. */ values = qopts->options[i].values; - len = count_strings (values) - 1 /* one for each comma */; + len = count_strings (values); + assert (len > 0); + len -= 1 /* on...

Currently we have an OCaml library for generating the qemu command line (used only by ‘virt-v2v -o qemu’). However we also generate a qemu command line in ‘lib/launch-direct.c’, and we might in future need to generate a ‘-readconfig’-compatible configuration file if we want to go beyond 10,000 drives for scalability testing. Therefore this patch series reimplements the qemu command line code as

...x86_64 \\\n" - " -nodefconfig \\\n" + " -no-user-config \\\n" " -m 1024 \\\n" " -smp 4 \\\n" " -drive file=/tmp/foo,if=ide \\\n" @@ -139,7 +139,7 @@ main (int argc, char *argv[]) actual_argv = qemuopts_to_argv (qopts)); const char *expected_argv[] = { "qemu-system-x86_64", - "-nodefconfig", + "-no-user-config", "-m", "1024", "-smp", "4", "-drive", "file=/tmp/foo,if=ide", diff --git a/com...