search for: qemuioarg

...this: > > # Ancient qemu-io in RHEL 7 doesn't support -f FORMAT option. However > # we can just omit it and the tests still work fine. > for f in tests/*.sh; do > sed -i -e 's/qemu-io -f raw/qemu-io/g' $f > done > Possibly use something like this? qemuioargs="-f raw" qemu-io -h | grep -- -f > /dev/null 2>&1 || qemuioargs="" qemu-io $qemuioargs ... Seems to work here. > I reproduced this on FreeBSD. The path used in the tests is indeed > relative: > > #!../nbdkit > > However replacing this with an...

On Tue, Nov 13, 2018 at 02:18:34PM +0000, Richard W.M. Jones wrote: > On Tue, Nov 13, 2018 at 03:09:16PM +0100, François Revol wrote: > > Possibly use something like this? > > > > qemuioargs="-f raw" > > qemu-io -h | grep -- -f > /dev/null 2>&1 || qemuioargs="" > > > > qemu-io $qemuioargs ... > > > > Seems to work here. > > Yes we could do something like that, but perhaps with a better name > such as ‘$qemu_io_for...

...esn't support -f FORMAT option. However > > # we can just omit it and the tests still work fine. > > for f in tests/*.sh; do > > sed -i -e 's/qemu-io -f raw/qemu-io/g' $f > > done > > > > > Possibly use something like this? > > qemuioargs="-f raw" > qemu-io -h | grep -- -f > /dev/null 2>&1 || qemuioargs="" > > qemu-io $qemuioargs ... > > Seems to work here. Yes we could do something like that, but perhaps with a better name such as ‘$qemu_io_format_raw_args’. > > I reproduced t...

François, thanks for the patches so far. This morning I pushed: https://github.com/libguestfs/nbdkit/commit/e26fb6cea3fdba13b5472daf6767e76abacd8d03 build: add missing #include "byte-swapping.h" https://github.com/libguestfs/nbdkit/commit/b962272a561bfed087316d24b7d510e4ab29a985 build: more fallbacks for mkostemp The iconv patch makes iconv a requirement. I don't know