search for: qemudomainnvdimmalignsizepseries

On 9/10/20 4:56 PM, Daniel P. Berrangé wrote: > On Thu, Sep 10, 2020 at 04:54:08PM +0200, Milan Zamazal wrote: >> Daniel P. Berrangé <berrange@redhat.com> writes: >> >>> On Thu, Sep 10, 2020 at 04:26:40PM +0200, Milan Zamazal wrote: >>>> Daniel P. Berrangé <berrange@redhat.com> writes: >>>> >>> >>>>> On Thu, Jul

...e77 Author: Daniel Henrique Barboza <danielhb413@gmail.com> Date: Mon Jul 20 13:51:46 2020 -0300 formatdomain.html.in: mention pSeries NVDIMM 'align down' mechanic The reason why we align down the guest area (total-size - label-size) is explained in the body of qemuDomainNVDimmAlignSizePseries(). This behavior must also be documented in the user docs. Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com> Reviewed-by: Andrea Bolognani <abologna@redhat.com> but later reverted. See below. > > > > > For second, and more importantly, I...

...> If we're enforcing this 1 MB rounding though, we really should be > documenting it clearly, so that apps can pick the right backing file > size. I think we dropped the ball on docs. Yes, OK. I also wonder how exactly label size is counted in. It's added to the aligned value in qemuDomainNVDimmAlignSizePseries with the argument that label size is mandatory on ppc. But it's also permitted on other architectures and I can't see a similar adjustment for them. I think QEMU handles it fine in either case (by subtracting label size from the overall size and aligning the result down) and I guess the s...

Hi, I've met two situations with NVDIMM support in libvirt where I'm not sure all the parties (libvirt & I) do the things correctly. The first problem is with memory alignment and size changes. In addition to the size changes applied to NVDIMMs by QEMU, libvirt also makes some NVDIMM size changes for better alignments, in qemuDomainMemoryDeviceAlignSize. This can lead to the size