search for: qemu_put_be32s

Add routines to manage PCI capability list. First user will be MSI-X. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- hw/pci.c | 98 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++------ hw/pci.h | 18 +++++++++++- 2 files changed, 106 insertions(+), 10 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 361d741..ed011b5 100644 --- a/hw/pci.c +++ b/hw/pci.c @@

Add routines to manage PCI capability list. First user will be MSI-X. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- hw/pci.c | 98 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++------ hw/pci.h | 18 +++++++++++- 2 files changed, 106 insertions(+), 10 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 361d741..ed011b5 100644 --- a/hw/pci.c +++ b/hw/pci.c @@

Add routines to manage PCI capability list. First user will be MSI-X. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- hw/pci.c | 98 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++------ hw/pci.h | 18 +++++++++++- 2 files changed, 106 insertions(+), 10 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 5dcfb4e..6bc3819 100644 --- a/hw/pci.c +++ b/hw/pci.c @@

Add routines to manage PCI capability list. First user will be MSI-X. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- hw/pci.c | 98 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++------ hw/pci.h | 18 +++++++++++- 2 files changed, 106 insertions(+), 10 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 5dcfb4e..6bc3819 100644 --- a/hw/pci.c +++ b/hw/pci.c @@

...ES: +#ifdef SYNAPTIC if (last_com != AUX_SET_RES) { /* if its not 4 in a row, its not a command */ @@ -790,6 +812,7 @@ uu = val; break; } +#endif s->mouse_resolution = val; kbd_queue(s, AUX_ACK, 1); s->mouse_write_cmd = -1; @@ -871,8 +894,10 @@ qemu_put_be32s(f, &s->mouse_dy); qemu_put_be32s(f, &s->mouse_dz); qemu_put_8s(f, &s->mouse_buttons); +#ifdef SYNAPTIC qemu_put_be32s(f, &s->touchpad.absolute); qemu_put_be32s(f, &s->touchpad.high); +#endif } static int kbd_load(QEMUFile* f, void* opaque,...

...sel = 0; > vdev->status = 0; > vdev->isr = 0; > @@ -924,7 +925,8 @@ void virtio_save(VirtIODevice *vdev, QEMUFile *f) > qemu_put_8s(f, &vdev->status); > qemu_put_8s(f, &vdev->isr); > qemu_put_be16s(f, &vdev->queue_sel); > - qemu_put_be32s(f, &vdev->guest_features); > + /* XXX features >= 32 */ > + qemu_put_be32s(f, (uint32_t *)&vdev->guest_features); Casting a uint64_t* to a uint32_t* here sounds very wrong - this likely only works on little endian sytems, but certainly not on big-endian systems. If you...

...sel = 0; > vdev->status = 0; > vdev->isr = 0; > @@ -924,7 +925,8 @@ void virtio_save(VirtIODevice *vdev, QEMUFile *f) > qemu_put_8s(f, &vdev->status); > qemu_put_8s(f, &vdev->isr); > qemu_put_be16s(f, &vdev->queue_sel); > - qemu_put_be32s(f, &vdev->guest_features); > + /* XXX features >= 32 */ > + qemu_put_be32s(f, (uint32_t *)&vdev->guest_features); Casting a uint64_t* to a uint32_t* here sounds very wrong - this likely only works on little endian sytems, but certainly not on big-endian systems. If you...

...atus = 0; > > vdev->isr = 0; > > @@ -924,7 +925,8 @@ void virtio_save(VirtIODevice *vdev, QEMUFile *f) > > qemu_put_8s(f, &vdev->status); > > qemu_put_8s(f, &vdev->isr); > > qemu_put_be16s(f, &vdev->queue_sel); > > - qemu_put_be32s(f, &vdev->guest_features); > > + /* XXX features >= 32 */ > > + qemu_put_be32s(f, (uint32_t *)&vdev->guest_features); > > Casting a uint64_t* to a uint32_t* here sounds very wrong - this likely > only works on little endian sytems, but certainly not on b...

...atus = 0; > > vdev->isr = 0; > > @@ -924,7 +925,8 @@ void virtio_save(VirtIODevice *vdev, QEMUFile *f) > > qemu_put_8s(f, &vdev->status); > > qemu_put_8s(f, &vdev->isr); > > qemu_put_be16s(f, &vdev->queue_sel); > > - qemu_put_be32s(f, &vdev->guest_features); > > + /* XXX features >= 32 */ > > + qemu_put_be32s(f, (uint32_t *)&vdev->guest_features); > > Casting a uint64_t* to a uint32_t* here sounds very wrong - this likely > only works on little endian sytems, but certainly not on b...

...gt;config_vector); + else + virtio_update_irq(vdev); } void virtio_save(VirtIODevice *vdev, QEMUFile *f) @@ -692,6 +776,7 @@ void virtio_save(VirtIODevice *vdev, QEMUFile *f) int i; pci_device_save(&vdev->pci_dev, f); + msix_save(&vdev->pci_dev, f); qemu_put_be32s(f, &vdev->addr); qemu_put_8s(f, &vdev->status); @@ -701,6 +786,9 @@ void virtio_save(VirtIODevice *vdev, QEMUFile *f) qemu_put_be32(f, vdev->config_len); qemu_put_buffer(f, vdev->config, vdev->config_len); + if (msix_present(&vdev->pci_dev)) +...

...gt;config_vector); + else + virtio_update_irq(vdev); } void virtio_save(VirtIODevice *vdev, QEMUFile *f) @@ -692,6 +776,7 @@ void virtio_save(VirtIODevice *vdev, QEMUFile *f) int i; pci_device_save(&vdev->pci_dev, f); + msix_save(&vdev->pci_dev, f); qemu_put_be32s(f, &vdev->addr); qemu_put_8s(f, &vdev->status); @@ -701,6 +786,9 @@ void virtio_save(VirtIODevice *vdev, QEMUFile *f) qemu_put_be32(f, vdev->config_len); qemu_put_buffer(f, vdev->config, vdev->config_len); + if (msix_present(&vdev->pci_dev)) +...

On Wed, Dec 03, 2014 at 12:14:10PM +0100, Cornelia Huck wrote: > On Wed, 3 Dec 2014 12:52:51 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote: > > > > diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c > > > index 43b7e02..1e2a720 100644 > > > ---

On Wed, Dec 03, 2014 at 12:14:10PM +0100, Cornelia Huck wrote: > On Wed, 3 Dec 2014 12:52:51 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote: > > > > diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c > > > index 43b7e02..1e2a720 100644 > > > ---

On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote: > On Wed, 3 Dec 2014 10:27:36 +0100 > Cornelia Huck <cornelia.huck at de.ibm.com> wrote: > > > On Tue, 2 Dec 2014 21:03:45 +0200 > > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > > > On Tue, Dec 02, 2014 at 04:41:36PM +0100, Cornelia Huck wrote: > > > >

On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote: > On Wed, 3 Dec 2014 10:27:36 +0100 > Cornelia Huck <cornelia.huck at de.ibm.com> wrote: > > > On Tue, 2 Dec 2014 21:03:45 +0200 > > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > > > On Tue, Dec 02, 2014 at 04:41:36PM +0100, Cornelia Huck wrote: > > > >

Extend virtio to support many interrupt vectors, and rearrange code in preparation for multi-vector support (mostly move reset out to bindings, because we will have to reset the vectors in transport-specific code). Actual bindings in pci, and use in net, to follow. Load and save are not connected to bindings yet, so they are left stubbed out for now. Signed-off-by: Michael S. Tsirkin <mst at

Extend virtio to support many interrupt vectors, and rearrange code in preparation for multi-vector support (mostly move reset out to bindings, because we will have to reset the vectors in transport-specific code). Actual bindings in pci, and use in net, to follow. Load and save are not connected to bindings yet, so they are left stubbed out for now. Signed-off-by: Michael S. Tsirkin <mst at

Extend virtio to support many interrupt vectors, and rearrange code in preparation for multi-vector support (mostly move reset out to bindings, because we will have to reset the vectors in transport-specific code). Actual bindings in pci, and use in net, to follow. Load and save are not connected to bindings yet, so they are left stubbed out for now. Signed-off-by: Michael S. Tsirkin <mst at

Extend virtio to support many interrupt vectors, and rearrange code in preparation for multi-vector support (mostly move reset out to bindings, because we will have to reset the vectors in transport-specific code). Actual bindings in pci, and use in net, to follow. Load and save are not connected to bindings yet, so they are left stubbed out for now. Signed-off-by: Michael S. Tsirkin <mst at

Extend virtio to support many interrupt vectors, and rearrange code in preparation for multi-vector support (mostly move reset out to bindings, because we will have to reset the vectors in transport-specific code). Actual bindings in pci, and use in net, to follow. Load and save are not connected to bindings yet, so they are left stubbed out for now. Signed-off-by: Michael S. Tsirkin <mst at