Displaying 3 results from an estimated 3 matches for "qemu_log_mask".
2013 May 29
2
[PATCH RFC] virtio-pci: new config layout: using memory BAR
...effect,
> and it likely will if we let it continue.
Letting a misbehaving guest crash itself is fine. Killing
QEMU isn't.
> assert makes sure we don't let it escalate into some
> hard to debug security problem.
If you want to make guest bugs easier to spot and debug
this is what qemu_log_mask(LOG_GUEST_ERROR,...) is for.
>> If you really want to use offsetof like this you're
>> going to need to decorate the structs with QEMU_PACKED.
> Nope.
> These structs are carefully designed not to have any padding.
...on every compiler and OS combination that QEMU builds fo...
2013 May 29
0
[PATCH RFC] virtio-pci: new config layout: using memory BAR
...it does any damage.
Why keep QEMU running even though we know
there's a memory corruption somewhere?
> > assert makes sure we don't let it escalate into some
> > hard to debug security problem.
>
> If you want to make guest bugs easier to spot and debug
> this is what qemu_log_mask(LOG_GUEST_ERROR,...) is for.
We really want something that would also stop guest
and stop device model as well - we don't know where the bug is.
> >> If you really want to use offsetof like this you're
> >> going to need to decorate the structs with QEMU_PACKED.
>
&g...
2013 May 29
2
[PATCH RFC] virtio-pci: new config layout: using memory BAR
On 29 May 2013 09:24, Michael S. Tsirkin <mst at redhat.com> wrote:
> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
> index f4db224..fd09ea7 100644
> --- a/hw/virtio/virtio-pci.c
> +++ b/hw/virtio/virtio-pci.c
> @@ -467,51 +467,70 @@ static uint64_t virtio_pci_config_common_read(void *opaque, hwaddr addr,
> {
> VirtIOPCIProxy *proxy = opaque;
>