search for: qemu_build_bug_on

On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote: > On 14 September 2014 06:46, Michael S. Tsirkin <mst at redhat.com> wrote: > > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU. > > You have to stick it in a C file though, so it > > won't be visible in this patch. > > Why do you think that? We have several header files which > use QEMU_BUILD_BUG_ON and I don't see any reason why > it would have to be invoked from a .c file. > &...

On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote: > On 14 September 2014 06:46, Michael S. Tsirkin <mst at redhat.com> wrote: > > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU. > > You have to stick it in a C file though, so it > > won't be visible in this patch. > > Why do you think that? We have several header files which > use QEMU_BUILD_BUG_ON and I don't see any reason why > it would have to be invoked from a .c file. > &...

...> Yes. > > > Is it worth adding a compile-time assertion about the > > size of the struct to ensure the compiler doesn't add any additional > > padding? > > Makes sense. What is the usual trick to do that? > > thanks, > Gerd BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU. You have to stick it in a C file though, so it won't be visible in this patch. -- MST

...> Yes. > > > Is it worth adding a compile-time assertion about the > > size of the struct to ensure the compiler doesn't add any additional > > padding? > > Makes sense. What is the usual trick to do that? > > thanks, > Gerd BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU. You have to stick it in a C file though, so it won't be visible in this patch. -- MST

On 14 September 2014 06:46, Michael S. Tsirkin <mst at redhat.com> wrote: > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU. > You have to stick it in a C file though, so it > won't be visible in this patch. Why do you think that? We have several header files which use QEMU_BUILD_BUG_ON and I don't see any reason why it would have to be invoked from a .c file. -- PMM

On 14 September 2014 07:11, Michael S. Tsirkin <mst at redhat.com> wrote: > On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote: >> On 14 September 2014 06:46, Michael S. Tsirkin <mst at redhat.com> wrote: >> > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU. >> > You have to stick it in a C file though, so it >> > won't be visible in this patch. >> >> Why do you think that? We have several header files which >> use QEMU_BUILD_BUG_ON and I don't see any reason why >> it would have to be invoked...

...rote: > On 14 September 2014 07:11, Michael S. Tsirkin <mst at redhat.com> wrote: > > On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote: > >> On 14 September 2014 06:46, Michael S. Tsirkin <mst at redhat.com> wrote: > >> > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU. > >> > You have to stick it in a C file though, so it > >> > won't be visible in this patch. > >> > >> Why do you think that? We have several header files which > >> use QEMU_BUILD_BUG_ON and I don't see any reason why > >&gt...

...rote: > On 14 September 2014 07:11, Michael S. Tsirkin <mst at redhat.com> wrote: > > On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote: > >> On 14 September 2014 06:46, Michael S. Tsirkin <mst at redhat.com> wrote: > >> > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU. > >> > You have to stick it in a C file though, so it > >> > won't be visible in this patch. > >> > >> Why do you think that? We have several header files which > >> use QEMU_BUILD_BUG_ON and I don't see any reason why > >&gt...

On 09/12/2014 04:44 AM, Gerd Hoffmann wrote: >>> +enum virtgpu_ctrl_type { >>> + VIRTGPU_UNDEFINED = 0, >>> + >>> + /* 2d commands */ >>> + VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100, >> >> Please consider also adding: >> >> #define VIRTGPU_CMD_GET_DISPLAY_INFO VIRTGPU_CMD_GET_DISPLAY_INFO >> >> and

On 09/12/2014 04:44 AM, Gerd Hoffmann wrote: >>> +enum virtgpu_ctrl_type { >>> + VIRTGPU_UNDEFINED = 0, >>> + >>> + /* 2d commands */ >>> + VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100, >> >> Please consider also adding: >> >> #define VIRTGPU_CMD_GET_DISPLAY_INFO VIRTGPU_CMD_GET_DISPLAY_INFO >> >> and

On 09/11/2014 09:09 AM, Gerd Hoffmann wrote: > This patch adds the header file with structs and defines for > the virtio based gpu device. Covers 2d operations only. > > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> > --- > include/hw/virtio/virtgpu_hw.h | 158 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 158 insertions(+) > create mode 100644

On 09/11/2014 09:09 AM, Gerd Hoffmann wrote: > This patch adds the header file with structs and defines for > the virtio based gpu device. Covers 2d operations only. > > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> > --- > include/hw/virtio/virtgpu_hw.h | 158 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 158 insertions(+) > create mode 100644

...ame(VirtIONet *n, const char *name, const char *type); diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h index bf17cc9..f0c0a6e 100644 --- a/include/hw/virtio/virtio-scsi.h +++ b/include/hw/virtio/virtio-scsi.h @@ -253,11 +253,11 @@ QEMU_BUILD_BUG_ON(offsetof(VirtIOSCSIReq, req.cdb) != DEFINE_PROP_UINT32("cmd_per_lun", _state, _conf_field.cmd_per_lun, 128) #define DEFINE_VIRTIO_SCSI_FEATURES(_state, _feature_field) \ - DEFINE_PROP_BIT("any_layout", _state, _feature_field, \...

...ame(VirtIONet *n, const char *name, const char *type); diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h index bf17cc9..f0c0a6e 100644 --- a/include/hw/virtio/virtio-scsi.h +++ b/include/hw/virtio/virtio-scsi.h @@ -253,11 +253,11 @@ QEMU_BUILD_BUG_ON(offsetof(VirtIOSCSIReq, req.cdb) != DEFINE_PROP_UINT32("cmd_per_lun", _state, _conf_field.cmd_per_lun, 128) #define DEFINE_VIRTIO_SCSI_FEATURES(_state, _feature_field) \ - DEFINE_PROP_BIT("any_layout", _state, _feature_field, \...

...ame(VirtIONet *n, const char *name, const char *type); diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h index bf17cc9..f0c0a6e 100644 --- a/include/hw/virtio/virtio-scsi.h +++ b/include/hw/virtio/virtio-scsi.h @@ -253,11 +253,11 @@ QEMU_BUILD_BUG_ON(offsetof(VirtIOSCSIReq, req.cdb) != DEFINE_PROP_UINT32("cmd_per_lun", _state, _conf_field.cmd_per_lun, 128) #define DEFINE_VIRTIO_SCSI_FEATURES(_state, _feature_field) \ - DEFINE_PROP_BIT("any_layout", _state, _feature_field, \...

...ame(VirtIONet *n, const char *name, const char *type); diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h index bf17cc9..f0c0a6e 100644 --- a/include/hw/virtio/virtio-scsi.h +++ b/include/hw/virtio/virtio-scsi.h @@ -253,11 +253,11 @@ QEMU_BUILD_BUG_ON(offsetof(VirtIOSCSIReq, req.cdb) != DEFINE_PROP_UINT32("cmd_per_lun", _state, _conf_field.cmd_per_lun, 128) #define DEFINE_VIRTIO_SCSI_FEATURES(_state, _feature_field) \ - DEFINE_PROP_BIT("any_layout", _state, _feature_field, \...

Another iteration of virtio-1 patches for qemu, as always available on git://github.com/cohuck/qemu virtio-1 This one seems to work together with the current vhost-next patches (well, I can ping :) Changes from v4: - add helpers for feature bit manipulation and checking - use 64 bit feature bits instead of 32 bit arrays - infrastructure to allow devices to offer different sets of feature bits

Another iteration of virtio-1 patches for qemu, as always available on git://github.com/cohuck/qemu virtio-1 This one seems to work together with the current vhost-next patches (well, I can ping :) Changes from v4: - add helpers for feature bit manipulation and checking - use 64 bit feature bits instead of 32 bit arrays - infrastructure to allow devices to offer different sets of feature bits

And yet another iteration of virtio-1 support in qemu, tested with the latest virtio kernel patches. Find it at git://github.com/cohuck/qemu virtio-1 Changes from v5: - fixed stupid bug in "virtio: support more feature bits": we need to define a proper prop backend for 64 bit wide handling... - don't negotiate revision 1 unless VERSION_1 is offered - use 64 bit wide features

And yet another iteration of virtio-1 support in qemu, tested with the latest virtio kernel patches. Find it at git://github.com/cohuck/qemu virtio-1 Changes from v5: - fixed stupid bug in "virtio: support more feature bits": we need to define a proper prop backend for 64 bit wide handling... - don't negotiate revision 1 unless VERSION_1 is offered - use 64 bit wide features