search for: python_ext_suffix

This is the same fix I posted a few days ago for hivex (<1369351909-23821-3-git-send-email-bengen@hilluzination.de>). Cheers, -Hilko

...3c3..00ef507 100644 --- a/configure.ac +++ b/configure.ac @@ -1163,6 +1163,14 @@ AS_IF([test "x$enable_python" != "xno"],[ AC_MSG_RESULT([$PYTHON_INSTALLDIR]) fi + AC_MSG_CHECKING([for Python extension suffix (PEP-3149)]) + if test -z "$PYTHON_EXT_SUFFIX"; then + python_ext_suffix=`$PYTHON -c "import sysconfig; \ + print (sysconfig.get_config_var('EXT_SUFFIX') or sysconfig.get_config_var('SO'))"` + PYTHON_EXT_SUFFIX=$python_ext_suffix + fi + A...

Building against multiple versions of Python is a lot of fun as it is. Add autoconf/automake/libtool (and possible distribution-specific stuff) to the mix and things get really interesting: On Debian and Ubuntu, building against python 3.3 requires an extra include path as documented in <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692387>. As discussed in

...s(-) diff --git a/configure.ac b/configure.ac index 6785037..203f34f 100644 --- a/configure.ac +++ b/configure.ac @@ -329,8 +329,8 @@ AS_IF([test "x$enable_python" != "xno"], AC_MSG_CHECKING([for Python extension suffix (PEP-3149)]) if test -z "$PYTHON_EXT_SUFFIX"; then - python_ext_suffix=`$PYTHON -c "import sysconfig; \ - print (sysconfig.get_config_var('EXT_SUFFIX') or sysconfig.get_config_var('SO'))"` + python_ext_suffix=`$PYTHON -c "import dist...

...@XMLLINT@" +export PYCODESTYLE="@PYCODESTYLE@" diff --git a/m4/guestfs-python.m4 b/m4/guestfs-python.m4 index ac857915f..505eba5df 100644 --- a/m4/guestfs-python.m4 +++ b/m4/guestfs-python.m4 @@ -86,6 +86,9 @@ AS_IF([test "x$enable_python" != "xno"],[ PYTHON_EXT_SUFFIX=$python_ext_suffix fi AC_MSG_RESULT([$PYTHON_EXT_SUFFIX]) + + AC_CHECK_PROGS([PYCODESTYLE],[pycodestyle],[no]) + AM_CONDITIONAL([HAVE_PYCODESTYLE], [test "x$PYCODESTYLE" != "xno"]) fi AC_SUBST(PYTHON_PREFIX) diff --git a/python/Makefil...

...@XMLLINT@" +export PYCODESTYLE="@PYCODESTYLE@" diff --git a/m4/guestfs-python.m4 b/m4/guestfs-python.m4 index ac857915f..505eba5df 100644 --- a/m4/guestfs-python.m4 +++ b/m4/guestfs-python.m4 @@ -86,6 +86,9 @@ AS_IF([test "x$enable_python" != "xno"],[ PYTHON_EXT_SUFFIX=$python_ext_suffix fi AC_MSG_RESULT([$PYTHON_EXT_SUFFIX]) + + AC_CHECK_PROGS([PYCODESTYLE],[pycodestyle],[no]) + AM_CONDITIONAL([HAVE_PYCODESTYLE], [test "x$PYCODESTYLE" != "xno"]) fi AC_SUBST(PYTHON_PREFIX) diff --git a/python/Makefil...

This commit starts to split our massive, monolithic configure.ac file into smaller files, using the m4_include mechanism to combine them. I don't know if we should really do this, so I'm open to comments about it. However: - Our configure.ac script is 1800+ lines long, and that's pretty long. - configure.ac lacks structure; splitting it up might improve that. - From what I read,

...1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/m4/guestfs-python.m4 b/m4/guestfs-python.m4 index 505eba5df..2e736875c 100644 --- a/m4/guestfs-python.m4 +++ b/m4/guestfs-python.m4 @@ -88,7 +88,6 @@ AS_IF([test "x$enable_python" != "xno"],[ AC_MSG_RESULT([$PYTHON_EXT_SUFFIX]) AC_CHECK_PROGS([PYCODESTYLE],[pycodestyle],[no]) - AM_CONDITIONAL([HAVE_PYCODESTYLE], [test "x$PYCODESTYLE" != "xno"]) fi AC_SUBST(PYTHON_PREFIX) @@ -98,3 +97,5 @@ AS_IF([test "x$enable_python" != "xno"],[ ]) AM_CONDITIONAL([...

...le changed, 2 insertions(+), 8 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 87e066c..1bf291c 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1216,20 +1216,14 @@ AS_IF([test "x$enable_python" != "xno"],[ > AC_MSG_RESULT([$PYTHON_EXT_SUFFIX]) > > dnl Look for some optional symbols in libpython. > - old_LIBS="$LIBS" > - > - PYTHON_BLDLIBRARY=`$PYTHON -c "import distutils.sysconfig; \ > - print (distutils.sysconfig.get_config_var('BLDLIBR...

Patch #7 depends on: https://www.redhat.com/archives/libguestfs/2020-January/msg00035.html No, Python < 3 support is not dropped yet, however it will be easier after this series. Pino Toscano (7): build: enforce a minimum Python version python: drop code for Python < 2.5 python: assume support for Capsules python: remove compile time check for PyString_AsString python: replace

Fixes the majority of the pycodestyle issues in the Python bindings, leaving only an overly length line in setup.py. Add a simple optional pycodestyle-based test to avoid regressions in the future. Pino Toscano (7): python: PEP 8: adapt empty lines python: PEP 8: adapt whitespaces in lines python: tests: catch specific exception python: tests: improve variable naming python: tests:

Fixes all the pycodestyle issues in the Python bindings, overring one that does not make sense to change (and it's in setup.py, so almost irrelevant). Add a simple optional pycodestyle-based test to avoid regressions in the future. Pino Toscano (8): python: PEP 8: adapt empty lines python: PEP 8: adapt whitespaces in lines python: tests: catch specific exception python: tests:

...not found]) ]) ]) + AC_MSG_CHECKING([Python prefix]) PYTHON_PREFIX=`$PYTHON -c "import sys; print (sys.prefix)"` AC_MSG_RESULT([$PYTHON_PREFIX]) @@ -101,4 +105,4 @@ AS_IF([test "x$enable_python" != "xno"],[ AC_SUBST(PYTHON_EXT_SUFFIX) ]) AM_CONDITIONAL([HAVE_PYTHON], - [test "x$PYTHON" != "xno" && test "x$PYTHON_LIBS" != "x" ]) + [test "x$PYTHON" != "xno" && test "x$have_python_module" = "x1" ]) -- 2.21.0

...configure.ac | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 87e066c..1bf291c 100644 --- a/configure.ac +++ b/configure.ac @@ -1216,20 +1216,14 @@ AS_IF([test "x$enable_python" != "xno"],[ AC_MSG_RESULT([$PYTHON_EXT_SUFFIX]) dnl Look for some optional symbols in libpython. - old_LIBS="$LIBS" - - PYTHON_BLDLIBRARY=`$PYTHON -c "import distutils.sysconfig; \ - print (distutils.sysconfig.get_config_var('BLDLIBRARY'))"` AC_...

...= \ -DGUESTFS_PRIVATE=1 \ @@ -75,7 +76,6 @@ libguestfsmod_la_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) libguestfsmod_la_LIBADD = \ - $(top_builddir)/common/utils/libutils_la-utils.lo \ $(top_builddir)/lib/libguestfs.la libguestfsmod_la_LDFLAGS = -avoid-version -shared -module -shrext $(PYTHON_EXT_SUFFIX) @@ -97,39 +97,19 @@ setup-install: setup.py stamp-extra-files # Python's crappy MANIFEST file cannot graft single files, so we have # to hard-link any extra files we need into the local directory. stamp-extra-files: \ - c-ctype.h \ - cleanups.c \ - cleanups.h \ config.h \ - gues...

Two (not related to each other) refactorings: Patches 1-12 split configure.ac into smaller files using the m4_include mechanism. Patches 13-15 split out parts of guestfs.pod (ie. guestfs(3)) into three new manual pages: guestfs-hacking(3) - how to extend and contribute to libguestfs guestfs-internals(3) - architecture and internals guestfs-security(3) - security and CVEs Patch 16 is a

Make sure they can build also in no as-neede setups. Pino Toscano (1): utils: split string list functions in own file build: use split stringlist functions from common/utils utils/Makefile.am | 2 + utils/guestfs-stringlists-utils.h | 30 +++++ utils/guestfs-utils.h | 7 +- utils/stringlists-utils.c | 197 ++++++++++++++++++++++++++++++ utils/utils.c

Hi, continuing what started a couple of weeks ago [1], the attached patch series continues the work in making it easier to build and run libguestfs (in fixed appliance mode) on OSes different than Linux. The provided changes should cause no functional changes on Linux. [1] https://www.redhat.com/archives/libguestfs/2014-October/msg00176.html Thanks, -- Pino Pino Toscano (9): build: check

...libguestfsmod_la_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) libguestfsmod_la_LIBADD = \ - $(top_builddir)/src/libutils_la-utils.lo \ + $(top_builddir)/common/utils/libutils_la-utils.lo \ $(top_builddir)/src/libguestfs.la libguestfsmod_la_LDFLAGS = -avoid-version -shared -module -shrext $(PYTHON_EXT_SUFFIX) @@ -117,13 +118,13 @@ guestfs-internal-all.h: ln $(top_srcdir)/src/guestfs-internal-all.h $@ guestfs-internal-frontend-cleanups.h: - ln $(top_srcdir)/src/guestfs-internal-frontend-cleanups.h $@ + ln $(top_srcdir)/common/utils/guestfs-internal-frontend-cleanups.h $@ guestfs-internal-fronten...

...+76,7 @@ libguestfsmod_la_CFLAGS = \ libguestfsmod_la_LIBADD = \ $(top_builddir)/common/utils/libutils_la-utils.lo \ + $(top_builddir)/common/cleanups/libcleanups_la-stdlib-cleanups.lo \ $(top_builddir)/lib/libguestfs.la libguestfsmod_la_LDFLAGS = -avoid-version -shared -module -shrext $(PYTHON_EXT_SUFFIX) @@ -97,11 +99,12 @@ setup-install: setup.py stamp-extra-files # to hard-link any extra files we need into the local directory. stamp-extra-files: \ c-ctype.h \ + cleanups.h \ config.h \ guestfs-internal-all.h \ - guestfs-internal-frontend-cleanups.h \ guestfs-internal-fronten...