search for: pynon

...(%s_user_data) {\n" cbname; > + pr " /* Increment refcount since pointer may be saved by libnbd. */\n"; > + pr " Py_INCREF (%s_user_data);\n" cbname; > + pr " if (!PyCallable_Check (%s_user_data)) {\n" cbname; I don't think PyNone is callable; this probably needs to gain a special case for when the user omitted the optional argument and we thus... > + pr " PyErr_SetString (PyExc_TypeError,\n"; > + pr " \"callback parameter %s is not callable\");\n"...

When using optional arguments of type OStringList, the code free'ing the member in the optargs_s struct corresponding to that optional argument would just check for a non-PyNone PyObject for that argument. If before that optional argument there are other arguments which can cause an earlier error return from that binding function, the free'ing code will then act on garbage values. Enhance the check by also checking whether the optargs struct has the bitmask with the...

...cbname; > > + pr " /* Increment refcount since pointer may be saved by libnbd. */\n"; > > + pr " Py_INCREF (%s_user_data);\n" cbname; > > + pr " if (!PyCallable_Check (%s_user_data)) {\n" cbname; > > I don't think PyNone is callable; this probably needs to gain a special > case for when the user omitted the optional argument and we thus... Yeah I'm not sure about this, plus we don't have any test coverage of it. But it doesn't work ... $ nbdkit null --run './run nbdsh --connect nbd://localhos...

Patches 1-4 are basically uncontroversial, straightforward refactoring and IMHO we should just push them. Possibly 1-3 should be squashed together, but I posted them separately so they are easier to review. Patches 5 and 6 together implement OClosure. Patch 5 adds the feature and is simple to understand. Patch 6 changes the Closure completion callbacks into OClosure, but because it doesn't